CCM-8574: add more e2e scenarios

Author: harrim91

tests/test-team/fixtures/pdf-upload/multipart-pdf-letter-fixtures.ts

@@ -43,9 +43,10 @@ const getFile = (directory: string, filename: string) => {
 
 export const pdfUploadFixtures = {
   withPersonalisation: {
-    pdf: getFile('with-personalisation', 'template.pdf'),
     csv: getFile('with-personalisation', 'test-data.csv'),
+    csvWrongParams: getFile('with-personalisation', 'wrong-params.csv'),
     passwordPdf: getFile('with-personalisation', 'password.pdf'),
+    pdf: getFile('with-personalisation', 'template.pdf'),
   },
   noCustomPersonalisation: {
     pdf: getFile('no-custom-personalisation', 'template.pdf'),

tests/test-team/fixtures/pdf-upload/with-personalisation/wrong-params.csv

@@ -0,0 +1,5 @@
+Personalisation field,Short length data example,Medium length data example,Long length data example
+appt_date,Wednesday 10 September 2025,Saturday 10 April 2025,Monday 1 May 2025
+appt_time,12:56pm,11:56am,1:56pm
+appt_location,"City, Sandwell & Walsall BSS, The Rosewood Centre, Sandwell & West Birmingham Hospitals NHS Trust, The Birmingham Treatment Centre, City Hospital, Dudley Road, Birmingham, B18 7QH","The Royal Shrewsbury Hospital, Breast Screening Office, Treatment Centre, Mytton Oak Road, Shrewsbury, SY3 8XQ","The Epping Breast Screening Unit, St Margaret's Hospital, The Plain, Epping, Essex, CM16 6TN"
+contact_telephone_number,020 3299 9010,020 3299 9010,020 3299 9010

tests/test-team/template-mgmt-e2e-tests/template-mgmt-letter-file-validation.e2e.spec.ts

@@ -246,4 +246,147 @@ test.describe('letter file validation', () => {
       );
     }).toPass({ timeout: 10_000 });
   });
+
+  test('validation fails if pdf parameters and test data parameters do not match', async ({
+    page,
+  }) => {
+    const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
+
+    await createTemplatePage.loadPage();
+
+    await createTemplatePage.nameInput.fill('Wrong test data params');
+
+    await createTemplatePage.setPdfFile(
+      pdfUploadFixtures.withPersonalisation.pdf.filepath
+    );
+
+    await createTemplatePage.setCsvFile(
+      pdfUploadFixtures.withPersonalisation.csvWrongParams.filepath
+    );
+
+    await createTemplatePage.clickSaveAndPreviewButton();
+
+    await expect(page).toHaveURL(TemplateMgmtPreviewLetterPage.urlRegexp);
+
+    const maybeTemplateId = TemplateMgmtPreviewLetterPage.getTemplateId(
+      page.url()
+    );
+
+    expect(maybeTemplateId).not.toBeUndefined();
+
+    const templateId = maybeTemplateId as string;
+
+    const key = {
+      id: templateId,
+      owner: user.userId,
+    };
+
+    templateStorageHelper.addAdHocTemplateKey(key);
+
+    await expect(async () => {
+      const template = await templateStorageHelper.getTemplate({
+        id: templateId,
+        owner: user.userId,
+      });
+
+      expect(template.files?.pdfTemplate?.virusScanStatus).toBe('PASSED');
+      expect(template.files?.testDataCsv?.virusScanStatus).toBe('PASSED');
+      expect(template.templateStatus).toBe('VALIDATION_FAILED');
+      expect(template.personalisationParameters).toBeUndefined();
+      expect(template.csvHeaders).toBeUndefined();
+    }).toPass({ timeout: 10_000 });
+  });
+
+  test('validation fails if unexpected csv is uploaded', async ({ page }) => {
+    const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
+
+    await createTemplatePage.loadPage();
+
+    await createTemplatePage.nameInput.fill('With unexpected CSV');
+
+    await createTemplatePage.setPdfFile(
+      pdfUploadFixtures.noCustomPersonalisation.pdf.filepath
+    );
+
+    await createTemplatePage.setCsvFile(
+      pdfUploadFixtures.withPersonalisation.csv.filepath
+    );
+
+    await createTemplatePage.clickSaveAndPreviewButton();
+
+    await expect(page).toHaveURL(TemplateMgmtPreviewLetterPage.urlRegexp);
+
+    const maybeTemplateId = TemplateMgmtPreviewLetterPage.getTemplateId(
+      page.url()
+    );
+
+    expect(maybeTemplateId).not.toBeUndefined();
+
+    const templateId = maybeTemplateId as string;
+
+    const key = {
+      id: templateId,
+      owner: user.userId,
+    };
+
+    templateStorageHelper.addAdHocTemplateKey(key);
+
+    await expect(async () => {
+      const template = await templateStorageHelper.getTemplate({
+        id: templateId,
+        owner: user.userId,
+      });
+
+      expect(template.files?.pdfTemplate?.virusScanStatus).toBe('PASSED');
+      expect(template.files?.testDataCsv?.virusScanStatus).toBe('PASSED');
+      expect(template.templateStatus).toBe('VALIDATION_FAILED');
+      expect(template.personalisationParameters).toBeUndefined();
+      expect(template.csvHeaders).toBeUndefined();
+    }).toPass({ timeout: 10_000 });
+  });
+
+  test('validation fails if expected csv is not uploaded', async ({ page }) => {
+    const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
+
+    await createTemplatePage.loadPage();
+
+    await createTemplatePage.nameInput.fill('Missing CSV');
+
+    await createTemplatePage.setPdfFile(
+      pdfUploadFixtures.withPersonalisation.pdf.filepath
+    );
+
+    await createTemplatePage.clickSaveAndPreviewButton();
+
+    await expect(page).toHaveURL(TemplateMgmtPreviewLetterPage.urlRegexp);
+
+    const maybeTemplateId = TemplateMgmtPreviewLetterPage.getTemplateId(
+      page.url()
+    );
+
+    expect(maybeTemplateId).not.toBeUndefined();
+
+    const templateId = maybeTemplateId as string;
+
+    const key = {
+      id: templateId,
+      owner: user.userId,
+    };
+
+    templateStorageHelper.addAdHocTemplateKey(key);
+
+    await expect(async () => {
+      const template = await templateStorageHelper.getTemplate({
+        id: templateId,
+        owner: user.userId,
+      });
+
+      expect(template.files?.pdfTemplate?.virusScanStatus).toBe('PASSED');
+      expect(template.templateStatus).toBe('VALIDATION_FAILED');
+      expect(template.personalisationParameters).toBeUndefined();
+      expect(template.csvHeaders).toBeUndefined();
+    }).toPass({ timeout: 10_000 });
+  });
 });
+
+// TODO: Add test for parameter formatting in pdf