CCM-11007: Lambda log destination fix (#559)

Author: sidnhs

infrastructure/terraform/components/app/README.md

@@ -40,6 +40,7 @@
 | <a name="input_letter_suppliers"></a> [letter\_suppliers](#input\_letter\_suppliers) | Letter suppliers enabled in the environment | <pre>map(object({<br/>    email_addresses  = list(string)<br/>    enable_polling   = bool<br/>    default_supplier = optional(bool)<br/>  }))</pre> | `{}` | no |
 | <a name="input_log_retention_in_days"></a> [log\_retention\_in\_days](#input\_log\_retention\_in\_days) | The retention period in days for the Cloudwatch Logs events to be retained, default of 0 is indefinite | `number` | `0` | no |
 | <a name="input_observability_account_id"></a> [observability\_account\_id](#input\_observability\_account\_id) | The Observability Account ID that needs access | `string` | n/a | yes |
+| <a name="input_override_log_destination_arn"></a> [override\_log\_destination\_arn](#input\_override\_log\_destination\_arn) | Override the log destination ARN for this component. | `string` | `""` | no |
 | <a name="input_parent_acct_environment"></a> [parent\_acct\_environment](#input\_parent\_acct\_environment) | Name of the environment responsible for the acct resources used, affects things like DNS zone. Useful for named dev environments | `string` | `"main"` | no |
 | <a name="input_project"></a> [project](#input\_project) | The name of the tfscaffold project | `string` | n/a | yes |
 | <a name="input_region"></a> [region](#input\_region) | The AWS Region | `string` | n/a | yes |

infrastructure/terraform/components/app/cloudwatch_log_group_amplify.tf

@@ -7,6 +7,6 @@ resource "aws_cloudwatch_log_subscription_filter" "amplify" {
   name            = "${local.csi}-amplify-${aws_amplify_app.main.id}"
   log_group_name  = aws_cloudwatch_log_group.amplify.name
   filter_pattern  = ""
-  destination_arn = "arn:aws:logs:${var.region}:${var.observability_account_id}:destination:nhs-notify-main-acct-firehose-logs"
+  destination_arn = local.log_destination_arn
   role_arn        = local.acct.log_subscription_role_arn
 }

infrastructure/terraform/components/app/locals.tf

@@ -2,4 +2,5 @@ locals {
   cloudfront_files_domain_name = "files.${local.root_domain_name}"
   root_domain_name             = "${var.environment}.${local.acct.dns_zone["name"]}"
   lambdas_source_code_dir      = "../../../../lambdas"
+  log_destination_arn          = var.override_log_destination_arn != "" ? var.override_log_destination_arn : "arn:aws:logs:${var.region}:${var.observability_account_id}:destination:nhs-main-obs-firehose-logs" # TODO CCM-10579 Please remove this after we do dev/nonprod cutover for this BC
 }

infrastructure/terraform/components/app/module_backend_api.tf

@@ -23,7 +23,7 @@ module "backend_api" {
 
   enable_proofing           = var.enable_proofing
   letter_suppliers          = var.letter_suppliers
-  log_destination_arn       = "arn:aws:logs:${var.region}:${var.observability_account_id}:destination:nhs-notify-main-acct-firehose-logs"
+  log_destination_arn       = local.log_destination_arn
   log_subscription_role_arn = local.acct.log_subscription_role_arn
 
   send_to_firehose = true

infrastructure/terraform/components/app/variables.tf

@@ -218,3 +218,10 @@ variable "external_email_domain" {
   default     = null
   description = "Externally managed domain used to create an SES identity for sending emails from. Validation DNS records will need to be manually configured in the DNS provider."
 }
+
+variable "override_log_destination_arn" {
+  type        = string
+  description = "Override the log destination ARN for this component."
+  default     = ""
+}
+