Skip to content

Commit 810134d

Browse files
authored
Merge branch 'main' into feature/CCM-8873-accessibility-markdown-examples-hidden-text
2 parents 7df59d9 + aebb45a commit 810134d

File tree

9 files changed

+13
-93
lines changed

9 files changed

+13
-93
lines changed

frontend/src/__tests__/components/forms/LetterTemplateForm.test.tsx/__snapshots__/LetterTemplateForm.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ exports[`Client-side validation triggers 1`] = `
225225
for="letterTemplateLanguage"
226226
id="letterTemplateLanguage--label"
227227
>
228-
Additional language
228+
Letter language
229229
</label>
230230
<div
231231
class="nhsuk-hint"
@@ -726,7 +726,7 @@ exports[`renders page one error 1`] = `
726726
for="letterTemplateLanguage"
727727
id="letterTemplateLanguage--label"
728728
>
729-
Additional language
729+
Letter language
730730
</label>
731731
<div
732732
class="nhsuk-hint"
@@ -1235,7 +1235,7 @@ exports[`renders page with multiple errors 1`] = `
12351235
for="letterTemplateLanguage"
12361236
id="letterTemplateLanguage--label"
12371237
>
1238-
Additional language
1238+
Letter language
12391239
</label>
12401240
<div
12411241
class="nhsuk-hint"
@@ -1689,7 +1689,7 @@ exports[`renders page with preloaded field values 1`] = `
16891689
for="letterTemplateLanguage"
16901690
id="letterTemplateLanguage--label"
16911691
>
1692-
Additional language
1692+
Letter language
16931693
</label>
16941694
<div
16951695
class="nhsuk-hint"

frontend/src/__tests__/components/molecules/__snapshots__/TemplateSubmitted.test.tsx.snap

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,30 +43,13 @@ exports[`TemplateSubmitted component should render 1`] = `
4343
>
4444
template-id
4545
</p>
46-
<h2
46+
<h3
4747
class="nhsuk-u-margin-top-5"
4848
>
4949
What you need to do next
50-
</h2>
51-
<h3>
52-
If you're currently onboarding
53-
</h3>
54-
<p>
55-
Tell your onboarding manager once you've submitted all your templates.
56-
</p>
57-
<h3>
58-
If you've already onboarded
5950
</h3>
6051
<p>
61-
Once you've submitted all your templates
62-
<a
63-
href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"
64-
id="servicenow-link"
65-
rel="noopener noreferrer"
66-
target="_blank"
67-
>
68-
raise a request with the service desk (opens in a new tab).
69-
</a>
52+
Tell an onboarding manager once you've submitted all your templates.
7053
</p>
7154
<hr
7255
class="nhsuk-section-break--visible"

frontend/src/components/molecules/TemplateSubmitted/TemplateSubmitted.tsx

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ import Link from 'next/link';
44
import { NHSNotifyMain } from '@atoms/NHSNotifyMain/NHSNotifyMain';
55
import content from '@content/content';
66

7-
type TemplateSubmittedProps = {
8-
templateId: string;
9-
templateName: string;
10-
};
7+
type TemplateSubmittedProps = { templateId: string; templateName: string };
118

129
export const TemplateSubmitted = ({
1310
templateId,
@@ -19,11 +16,7 @@ export const TemplateSubmitted = ({
1916
templateNameHeading,
2017
templateIdHeading,
2118
doNextHeading,
22-
notLiveHeading,
23-
notLiveText,
24-
liveHeading,
25-
liveLinkText,
26-
liveText,
19+
doNextText,
2720
} = content.components.templateSubmitted;
2821

2922
return (
@@ -46,21 +39,8 @@ export const TemplateSubmitted = ({
4639
{templateIdHeading}
4740
</h2>
4841
<p id='template-id'>{templateId}</p>
49-
<h2 className='nhsuk-u-margin-top-5'>{doNextHeading}</h2>
50-
<h3>{notLiveHeading}</h3>
51-
<p>{notLiveText}</p>
52-
<h3>{liveHeading}</h3>
53-
<p>
54-
{liveText}{' '}
55-
<Link
56-
id='servicenow-link'
57-
href='https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5'
58-
target='_blank'
59-
rel='noopener noreferrer'
60-
>
61-
{liveLinkText}
62-
</Link>
63-
</p>
42+
<h3 className='nhsuk-u-margin-top-5'>{doNextHeading}</h3>
43+
<p>{doNextText}</p>
6444
<hr className='nhsuk-section-break--visible' />
6545
<p>
6646
<Link id='go-back-link' href='/message-templates'>

frontend/src/content/content.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ const templateFormLetter = {
461461
templateNameHintText: 'This will not be visible to recipients.',
462462
templateTypeLabelText: 'Letter type',
463463
templateTypeHintText: 'Choose the type of letter template you are uploading',
464-
templateLanguageLabelText: 'Additional language',
464+
templateLanguageLabelText: 'Letter language',
465465
templateLanguageHintText: 'Choose the language of this letter template',
466466
templatePdfLabelText: 'Letter template PDF',
467467
templatePdfHintText:
@@ -520,12 +520,8 @@ const templateSubmitted = {
520520
templateNameHeading: 'Template name',
521521
templateIdHeading: 'Template ID',
522522
doNextHeading: 'What you need to do next',
523-
notLiveHeading: "If you're currently onboarding",
524-
notLiveText:
525-
"Tell your onboarding manager once you've submitted all your templates.",
526-
liveHeading: "If you've already onboarded",
527-
liveText: "Once you've submitted all your templates",
528-
liveLinkText: 'raise a request with the service desk (opens in a new tab).',
523+
doNextText:
524+
"Tell an onboarding manager once you've submitted all your templates.",
529525
backLinkText: backToAllTemplates,
530526
};
531527

frontend/src/domain/errors/coded.error.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

frontend/src/domain/errors/db-operation.error.ts

Lines changed: 0 additions & 22 deletions
This file was deleted.

frontend/src/domain/errors/index.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/test-team/pages/template-mgmt-template-submitted-base-page.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ export abstract class TemplateMgmtTemplateSubmittedBasePage extends TemplateMgmt
88

99
public readonly createAnotherTemplateLink: Locator;
1010

11-
public readonly serviceNowLink: Locator;
12-
1311
public readonly goBackLink: Locator;
1412

1513
constructor(page: Page) {
@@ -19,7 +17,6 @@ export abstract class TemplateMgmtTemplateSubmittedBasePage extends TemplateMgmt
1917
this.createAnotherTemplateLink = page.locator(
2018
'[id="create-another-template"]'
2119
);
22-
this.serviceNowLink = page.locator('[id="servicenow-link"]');
2320
this.goBackLink = page.locator('#go-back-link');
2421
}
2522

tests/test-team/template-mgmt-component-tests/template-mgmt-submitted-page.component.spec.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,6 @@ test.describe('Template Submitted Page', () => {
103103
await expect(templateSubmittedPage.templateIdText).toHaveText(
104104
templates[channelIdentifier].id
105105
);
106-
107-
await expect(templateSubmittedPage.serviceNowLink).toHaveAttribute(
108-
'href',
109-
'https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5'
110-
);
111106
});
112107

113108
// eslint-disable-next-line no-loop-func

0 commit comments

Comments
 (0)