comments, cleanup

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -659,7 +659,7 @@ describe('templateClient', () => {
       }
     );
 
-    test('should return a failure result client configuration unexpectedly cant be fetched', async () => {
+    test('should return a failure result if client configuration unexpectedly cant be fetched', async () => {
       const { templateClient, mocks } = setup();
 
       const data: CreateUpdateTemplate = {
@@ -1787,38 +1787,6 @@ describe('templateClient', () => {
       });
     });
 
-    test('should return a failure result, when proofing is not enabled', async () => {
-      const { templateClient, mocks } = setup();
-
-      mocks.clientConfigRepository.get.mockResolvedValueOnce({
-        data: {
-          campaignId: 'campaignId',
-          features: {
-            proofing: false,
-          },
-        },
-      });
-
-      const result = await templateClient.requestProof(templateId, user);
-
-      expect(mocks.clientConfigRepository.get).toHaveBeenCalledWith(
-        user.clientId
-      );
-
-      expect(
-        mocks.templateRepository.proofRequestUpdate
-      ).not.toHaveBeenCalled();
-
-      expect(mocks.queueMock.send).not.toHaveBeenCalled();
-
-      expect(result).toEqual({
-        error: {
-          code: 403,
-          message: 'User cannot request a proof',
-        },
-      });
-    });
-
     test('should return a failure result, when user has no clientId (so proofing cannot be determined to be enabled)', async () => {
       const { templateClient, mocks } = setup();
 

lambdas/backend-api/src/__tests__/templates/infra/client-config-repository.test.ts

@@ -366,7 +366,7 @@ describe('ClientConfigRepository', () => {
         expect(cache.set).toHaveBeenCalledWith(mockKey, validClient);
       });
 
-      it('caches non-existance of configuration parameter', async () => {
+      it('caches non-existence of configuration parameter', async () => {
         const {
           mocks: { ssmClient, cache },
         } = setup();