CCM-8585: unit test fixes

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -78,7 +78,10 @@ describe('templateClient', () => {
         error: expect.objectContaining({
           code: 400,
           message: 'Request failed validation',
-          details: {},
+          details: {
+            templateType:
+              "Invalid enum value. Expected 'EMAIL' | 'NHSAPP' | 'SMS', received 'LETTER'",
+          },
         }),
       });
     });
@@ -775,8 +778,10 @@ describe('templateClient', () => {
       const result = await client.createLetterTemplate(data, owner, pdf);
 
       expect(result).toEqual({
-        code: 400,
-        message: 'request failed validation',
+        error: {
+          code: 400,
+          message: 'request failed validation',
+        },
       });
 
       expect(mocks.templateRepository.create).not.toHaveBeenCalled();

tests/test-team/helpers/factories/template-api-payload-factory.ts

@@ -91,31 +91,4 @@ export const TemplateAPIPayloadFactory = {
       ...multipartData,
     };
   },
-
-  /**
-   * Returns a request body payload to be used with an API request to update a letter template
-   */
-  getUpdateLetterTemplatePayload<
-    T extends TemplateInput<UpdateTemplatePayload>,
-  >(
-    template: T,
-    uploadSpec: PdfUploadPartSpec[]
-  ): {
-    templateData: TemplateOutput<UpdateTemplatePayload, T>;
-    multipart: Buffer;
-    contentType: string;
-  } {
-    const templateData = {
-      templateStatus: 'NOT_YET_SUBMITTED',
-      ...createTemplateBaseData(template.templateType),
-      ...template,
-    };
-
-    const multipartData = pdfLetterMultipart(uploadSpec, templateData);
-
-    return {
-      templateData,
-      ...multipartData,
-    };
-  },
 };