CCM-11966: Feedback

Author: m-salaudeen

lambdas/event-publisher/src/__tests__/domain/should-publish.test.ts

@@ -52,7 +52,6 @@ describe('shouldPublish', () => {
     PROOF_AVAILABLE: true,
     SUBMITTED: true,
     WAITING_FOR_PROOF: true,
-    TEMPLATE_PROOF_APPROVED: false,
     PENDING_UPLOAD: false,
     PENDING_VALIDATION: false,
     VALIDATION_FAILED: false,

utils/utils/src/__tests__/enum.test.ts

@@ -216,28 +216,28 @@ describe('statusToDisplayMapping', () => {
     }
   );
 
-  test('statusToDisplay if routing is enabled', () => {
+  test('statusToDisplay if no files', () => {
     expect(
       statusToDisplayMapping(
         {
-          ...mockLetterWithFilesTemplate,
+          ...mockLetterTemplate,
           templateStatus: 'SUBMITTED',
         },
         true
       )
-    ).toEqual('Template proof approved');
+    ).toEqual('Submitted');
   });
 
-  test('statusToDisplay if no files', () => {
+  test('statusToDisplay if routing is enabled', () => {
     expect(
       statusToDisplayMapping(
         {
-          ...mockLetterTemplate,
+          ...mockLetterWithFilesTemplate,
           templateStatus: 'SUBMITTED',
         },
-        false
+        true
       )
-    ).toEqual('Submitted');
+    ).toEqual('Template proof approved');
   });
 
   test('SUBMITTED', () => {