CCM-10422: unit tests

Author: alexnuttall

utils/utils/src/__tests__/lambda-cognito-authorizer.test.ts

@@ -401,7 +401,7 @@ describe('LambdaCognitoAuthorizer', () => {
     );
   });
 
-  test('returns failure when sub on Cognito UserAttributes does not match expected subject or clientId', async () => {
+  test('returns failure when expected resourc owner matches neither notify client id nor sub, from Cognito', async () => {
     const jwt = sign(
       {
         token_use: 'access',

utils/utils/src/lambda-cognito-authorizer.ts

@@ -92,8 +92,8 @@ export class LambdaCognitoAuthorizer {
 
       if (
         expectedSubjectOrClientId !== undefined &&
-        (expectedSubjectOrClientId !== sub ||
-          expectedSubjectOrClientId !== notifyClientId)
+        expectedSubjectOrClientId !== sub &&
+        expectedSubjectOrClientId !== notifyClientId
       ) {
         this.logger.warn(
           'Neither subject nor clientId matches expected resource owner'