CCM-8961: Seed all letter states for pa11y

Author: ClareJonesBJSS

tests/accessibility/.pa11y-ci.js

@@ -18,6 +18,7 @@ const {
   previewEmailTemplateErrorPage,
   previewEmailTemplatePage,
   previewLetterTemplatePage,
+  previewLetterTemplatePageWithError,
   previewNHSAppTemplateErrorPage,
   previewNHSAppTemplatePage,
   previewSubmittedEmailTemplatePage,
@@ -99,15 +100,30 @@ module.exports = {
         `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-pending-virus-check']}`
       )
     ),
+    performCheck(
+      previewLetterTemplatePageWithError(
+        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-failed-virus-check']}`
+      )
+    ),
+    performCheck(
+      previewLetterTemplatePage(
+        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-pending-validation']}`
+      )
+    ),
+    performCheck(
+      previewLetterTemplatePageWithError(
+        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-failed-validation']}`
+      )
+    ),
     performCheck(viewNotYetSubmittedLetterTemplatePage(messageTemplatesUrl)),
     performCheck(
       submitLetterTemplatePage(
-        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-passed-virus-check']}`
+        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-passed-validation']}`
       )
     ),
     performCheck(
       letterTemplateSubmittedPage(
-        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-passed-virus-check']}`
+        `${baseUrl}/preview-letter-template/${templateIds['pa11y-letter-passed-validation']}`
       )
     ),
     performCheck(previewSubmittedLetterTemplatePage(messageTemplatesUrl)),

tests/accessibility/actions/preview-letter-template.actions.js

@@ -2,7 +2,7 @@ const { signInPageActions } = require('./sign-in-page.actions');
 
 const pageActions = [
   ...signInPageActions,
-  'wait for #preview-letter-template-submit-button to be visible',
+  'wait for [data-testid="preview-message__heading"] to be visible',
 ];
 
 const previewLetterTemplatePage = (url) => ({
@@ -11,7 +11,18 @@ const previewLetterTemplatePage = (url) => ({
   actions: pageActions,
 });
 
+const previewLetterTemplatePageWithError = (url) => ({
+  name: 'preview-letter-template',
+  url,
+  actions: pageActions,
+  ignore: [
+    // NHS error summary component has a H2 above the H1.
+    'WCAG2AA.Principle1.Guideline1_3.1_3_1_AAA.G141',
+  ],
+});
+
 module.exports = {
   pageActions,
   previewLetterTemplatePage,
+  previewLetterTemplatePageWithError,
 };

tests/accessibility/pa11y-setup.ts

@@ -5,15 +5,16 @@ import { generate } from 'generate-password';
 import { DynamoDBClient } from '@aws-sdk/client-dynamodb';
 import { PutCommand, DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
 import { LetterTemplate } from 'nhs-notify-web-template-management-utils';
-import { VirusScanStatus } from 'nhs-notify-backend-client';
+import { TemplateStatus, VirusScanStatus } from 'nhs-notify-backend-client';
 import { BackendConfigHelper } from 'nhs-notify-web-template-management-util-backend-config';
 import path from 'node:path';
 
 // pa11y can't interact with a file upload dialogue, so letters must be seeded
 const generateLetterTemplateData = (
   name: string,
   owner: string,
-  virusScanStatus: VirusScanStatus
+  virusScanStatus: VirusScanStatus,
+  templateStatus: TemplateStatus
 ): LetterTemplate & { owner: string } => {
   const now = new Date().toISOString();
 
@@ -38,7 +39,7 @@ const generateLetterTemplateData = (
         virusScanStatus,
       },
     },
-    templateStatus: 'NOT_YET_SUBMITTED',
+    templateStatus,
   };
 };
 
@@ -70,14 +71,34 @@ const setup = async () => {
 
   const templates = [
     generateLetterTemplateData(
-      'pa11y-letter-passed-virus-check',
+      'pa11y-letter-pending-virus-check',
       userId,
-      'PASSED'
+      'PENDING',
+      'PENDING_UPLOAD'
     ),
     generateLetterTemplateData(
-      'pa11y-letter-pending-virus-check',
+      'pa11y-letter-failed-virus-check',
+      userId,
+      'FAILED',
+      'VIRUS_SCAN_FAILED'
+    ),
+    generateLetterTemplateData(
+      'pa11y-letter-pending-validation',
+      userId,
+      'PASSED',
+      'PENDING_VALIDATION'
+    ),
+    generateLetterTemplateData(
+      'pa11y-letter-failed-validation',
+      userId,
+      'PASSED',
+      'VALIDATION_FAILED'
+    ),
+    generateLetterTemplateData(
+      'pa11y-letter-passed-validation',
       userId,
-      'PENDING'
+      'PASSED',
+      'NOT_YET_SUBMITTED'
     ),
   ];
 

tests/test-team/template-mgmt-e2e-tests/template-mgmt-letter-file-validation.e2e.spec.ts

@@ -249,7 +249,7 @@ test.describe('letter file validation', () => {
       );
 
       expect(pdf?.ChecksumSHA256).toEqual(
-        pdfUploadFixtures.withPersonalisation.csv.checksumSha256()
+        pdfUploadFixtures.withPersonalisation.pdf.checksumSha256()
       );
     }).toPass({ timeout: 20_000 });