CCM-11492 Move util to get template IDs

Author: nicki-nhs

frontend/src/__tests__/utils/get-message-plan-template-ids.test.ts

@@ -0,0 +1,65 @@
+import { getMessagePlanTemplateIds } from '@utils/get-message-plan-template-ids';
+import type { RoutingConfig } from 'nhs-notify-backend-client';
+
+const baseConfig: RoutingConfig = {
+  id: 'test-id',
+  name: 'Test message plan',
+  status: 'DRAFT',
+  clientId: 'client-1',
+  campaignId: 'campaign-1',
+  createdAt: '2025-01-01T00:00:00.000Z',
+  updatedAt: '2025-01-01T00:00:00.000Z',
+  cascade: [],
+  cascadeGroupOverrides: [{ name: 'standard' }],
+};
+
+describe('getMessagePlanTemplateIds', () => {
+  it('should collect unique template IDs from defaults and conditionals', () => {
+    const plan: RoutingConfig = {
+      ...baseConfig,
+      cascade: [
+        {
+          cascadeGroups: ['standard'],
+          channel: 'NHSAPP',
+          channelType: 'primary',
+          defaultTemplateId: 'template-1',
+        },
+        {
+          cascadeGroups: ['standard'],
+          channel: 'EMAIL',
+          channelType: 'primary',
+          conditionalTemplates: [
+            { templateId: 'template-2', language: 'fr' },
+            { templateId: 'template-3', language: 'fr' },
+          ],
+        },
+        {
+          cascadeGroups: ['standard'],
+          channel: 'SMS',
+          channelType: 'primary',
+          defaultTemplateId: 'template-1',
+          conditionalTemplates: [{ templateId: 'template-2', language: 'fr' }],
+        },
+      ],
+    };
+
+    const ids = [...getMessagePlanTemplateIds(plan)].sort();
+    expect(ids).toEqual(['template-1', 'template-2', 'template-3']);
+  });
+
+  it('should return empty set when there are no templates', () => {
+    const plan: RoutingConfig = {
+      ...baseConfig,
+      cascade: [
+        {
+          cascadeGroups: ['standard'],
+          channel: 'NHSAPP',
+          channelType: 'primary',
+          defaultTemplateId: '',
+        },
+      ],
+    };
+    const ids = getMessagePlanTemplateIds(plan);
+    expect(ids.size).toBe(0);
+  });
+});

frontend/src/__tests__/utils/message-plans.test.ts

@@ -1,7 +1,6 @@
 import {
   getMessagePlan,
   updateMessagePlan,
-  getMessagePlanTemplateIds,
   getTemplatesByIds,
   getMessagePlanTemplates,
   getRoutingConfigs,
@@ -25,7 +24,6 @@ import {
   NHS_APP_TEMPLATE,
   SMS_TEMPLATE,
 } from '@testhelpers/helpers';
-import { error } from 'node:console';
 import { randomUUID } from 'node:crypto';
 
 jest.mock('@utils/amplify-utils');
@@ -456,59 +454,6 @@ describe('Message plans actions', () => {
     });
   });
 
-  describe('getMessagePlanTemplateIds', () => {
-    it('should collect unique template IDs from defaults and conditionals', () => {
-      const plan: RoutingConfig = {
-        ...baseConfig,
-        cascade: [
-          {
-            cascadeGroups: ['standard'],
-            channel: 'NHSAPP',
-            channelType: 'primary',
-            defaultTemplateId: 'template-1',
-          },
-          {
-            cascadeGroups: ['standard'],
-            channel: 'EMAIL',
-            channelType: 'primary',
-            conditionalTemplates: [
-              { templateId: 'template-2', language: 'fr' },
-              { templateId: 'template-3', language: 'fr' },
-            ],
-          },
-          {
-            cascadeGroups: ['standard'],
-            channel: 'SMS',
-            channelType: 'primary',
-            defaultTemplateId: 'template-1',
-            conditionalTemplates: [
-              { templateId: 'template-2', language: 'fr' },
-            ],
-          },
-        ],
-      };
-
-      const ids = [...getMessagePlanTemplateIds(plan)].sort();
-      expect(ids).toEqual(['template-1', 'template-2', 'template-3']);
-    });
-
-    it('should return empty set when there are no templates', () => {
-      const plan: RoutingConfig = {
-        ...baseConfig,
-        cascade: [
-          {
-            cascadeGroups: ['standard'],
-            channel: 'NHSAPP',
-            channelType: 'primary',
-            defaultTemplateId: '',
-          },
-        ],
-      };
-      const ids = getMessagePlanTemplateIds(plan);
-      expect(ids.size).toBe(0);
-    });
-  });
-
   describe('getTemplatesById', () => {
     it('should return a map of successful template fetches and ignore undefined/rejected', async () => {
       getTemplateMock.mockImplementation(async (id: string) => {

frontend/src/utils/get-message-plan-template-ids.ts

@@ -0,0 +1,23 @@
+import { RoutingConfig } from 'nhs-notify-backend-client';
+
+/**
+ * Extracts all template IDs from a RoutingConfig
+ */
+export function getMessagePlanTemplateIds(
+  messagePlan: RoutingConfig
+): Set<string> {
+  const templateIds = new Set<string>();
+
+  for (const cascadeItem of messagePlan.cascade) {
+    if (cascadeItem.defaultTemplateId)
+      templateIds.add(cascadeItem.defaultTemplateId);
+    if (cascadeItem.conditionalTemplates) {
+      for (const conditionalTemplate of cascadeItem.conditionalTemplates) {
+        if (conditionalTemplate.templateId)
+          templateIds.add(conditionalTemplate.templateId);
+      }
+    }
+  }
+
+  return templateIds;
+}

frontend/src/utils/message-plans.ts

@@ -7,6 +7,7 @@ import {
   TemplateDto,
   RoutingConfigStatusActive,
 } from 'nhs-notify-backend-client';
+import { getMessagePlanTemplateIds } from './get-message-plan-template-ids';
 import { getSessionServer } from './amplify-utils';
 import { logger } from 'nhs-notify-web-template-management-utils/logger';
 import { getTemplate } from './form-actions';
@@ -171,25 +172,6 @@ export async function getMessagePlanTemplates(
   return getTemplatesByIds([...templateIds]);
 }
 
-export function getMessagePlanTemplateIds(
-  messagePlan: RoutingConfig
-): Set<string> {
-  const templateIds = new Set<string>();
-
-  for (const cascadeItem of messagePlan.cascade) {
-    if (cascadeItem.defaultTemplateId)
-      templateIds.add(cascadeItem.defaultTemplateId);
-    if (cascadeItem.conditionalTemplates) {
-      for (const conditionalTemplate of cascadeItem.conditionalTemplates) {
-        if (conditionalTemplate.templateId)
-          templateIds.add(conditionalTemplate.templateId);
-      }
-    }
-  }
-
-  return templateIds;
-}
-
 export async function getTemplatesByIds(templateIds: string[]) {
   const results = await Promise.allSettled(
     templateIds.map(async (templateId) => {