CCM-11544 Fixes

Author: nicki-nhs

frontend/src/__tests__/components/forms/ChooseChannelTemplate/__snapshots__/ChooseChannelTemplate.test.tsx.snap

@@ -2370,7 +2370,7 @@ exports[`ChooseChannelTemplate when there are no templates renders correctly 1`]
             data-testid="channel-template-actions"
           >
             <a
-              class="nhsuk-u-font-size-19 nhsuk-u-display-block nhsuk-body-m"
+              class="nhsuk-u-font-size-19 nhsuk-body-m fit-content"
               data-testid="go-to-templates-link"
               href="/message-templates"
             >

frontend/src/__tests__/components/forms/ChooseLanguageLetterTemplates/ChooseLanguageLetterTemplates.test.tsx

@@ -165,14 +165,14 @@ describe('ChooseLanguageLetterTemplates', () => {
   });
 
   describe('when there are no templates', () => {
-    it('displays "You do not have any foreign language letter templates" message', () => {
+    it('displays "You do not have any other language letter templates" message', () => {
       renderComponent({
         templateList: [],
       });
 
       expect(
         screen.getByText(
-          'You do not have any foreign language letter templates yet.'
+          'You do not have any other language letter templates yet.'
         )
       ).toBeInTheDocument();
       expect(screen.queryByRole('checkbox')).not.toBeInTheDocument();

frontend/src/__tests__/components/forms/ChooseLanguageLetterTemplates/__snapshots__/ChooseLanguageLetterTemplates.test.tsx.snap

@@ -2402,14 +2402,14 @@ exports[`ChooseLanguageLetterTemplates when there are no templates renders corre
             class="nhsuk-body"
             data-testid="no-templates-message"
           >
-            You do not have any foreign language letter templates yet.
+            You do not have any other language letter templates yet.
           </p>
           <div
             class="nhsuk-form-group"
             data-testid="channel-template-actions"
           >
             <a
-              class="nhsuk-u-font-size-19 nhsuk-u-display-block nhsuk-body-m"
+              class="nhsuk-u-font-size-19 nhsuk-body-m fit-content"
               data-testid="go-to-templates-link"
               href="/message-templates"
             >

frontend/src/components/forms/ChooseChannelTemplate/ChooseChannelTemplate.tsx

@@ -128,7 +128,7 @@ export function ChooseChannelTemplate(props: ChooseChannelTemplateProps) {
               ) : (
                 <Link
                   href={content.actions.goToTemplates.href}
-                  className='nhsuk-u-font-size-19 nhsuk-u-display-block nhsuk-body-m'
+                  className='nhsuk-u-font-size-19 nhsuk-body-m fit-content'
                   data-testid='go-to-templates-link'
                 >
                   {content.actions.goToTemplates.text}

frontend/src/components/forms/ChooseLanguageLetterTemplates/ChooseLanguageLetterTemplates.tsx

@@ -157,7 +157,7 @@ export function ChooseLanguageLetterTemplates(
               ) : (
                 <Link
                   href={content.actions.goToTemplates.href}
-                  className='nhsuk-u-font-size-19 nhsuk-u-display-block nhsuk-body-m'
+                  className='nhsuk-u-font-size-19 nhsuk-body-m fit-content'
                   data-testid='go-to-templates-link'
                 >
                   {content.actions.goToTemplates.text}

frontend/src/styles/app.scss

@@ -137,3 +137,7 @@ a.nhsuk-link--no-visited-state {
     }
   }
 }
+
+.fit-content {
+  width: fit-content;
+}

tests/test-team/pages/routing/nhs-app/choose-nhs-app-template-page.ts

@@ -1,4 +1,3 @@
-import { type Page } from '@playwright/test';
 import { TemplateMgmtChooseTemplateForMessagePlanBasePage } from 'pages/template-mgmt-choose-template-base-page';
 
 export class RoutingChooseNhsAppTemplatePage extends TemplateMgmtChooseTemplateForMessagePlanBasePage {

tests/test-team/pages/template-mgmt-choose-template-base-page.ts

@@ -28,7 +28,7 @@ export abstract class TemplateMgmtChooseTemplateForMessagePlanBasePage extends T
     this.previousSelectionDetails = page.getByTestId(
       'previous-selection-details'
     );
-    this.formError = page.locator('#channel-template--error-message');
+    this.formError = page.locator('#channelTemplate--error-message');
     this.templatesTable = page.getByTestId('channel-templates-table');
   }
 

tests/test-team/template-mgmt-routing-component-tests/letter/choose-large-print-letter-template.routing-component.spec.ts

@@ -285,10 +285,10 @@ test.describe('Routing - Choose large print letter template page', () => {
 
     const errorLink =
       chooseLargePrintLetterTemplatePage.errorSummaryList.first();
-    await expect(errorLink).toHaveText('Choose a letter template');
+    await expect(errorLink).toHaveText('Choose a large print letter template');
 
     await expect(chooseLargePrintLetterTemplatePage.formError).toHaveText(
-      'Choose a letter template'
+      'Error: Choose a large print letter template'
     );
 
     await chooseLargePrintLetterTemplatePage
@@ -297,7 +297,7 @@ test.describe('Routing - Choose large print letter template page', () => {
 
     await chooseLargePrintLetterTemplatePage.saveAndContinueButton.click();
 
-    await expect(page).toHaveURL(
+    await page.waitForURL(
       `${baseURL}/templates/message-plans/choose-templates/${routingConfigs.valid.id}`
     );
   });

tests/test-team/template-mgmt-routing-component-tests/letter/choose-other-language-letter-template.routing-component.spec.ts

@@ -336,9 +336,7 @@ test.describe('Routing - Choose other language letter templates page', () => {
 
       await expect(
         chooseOtherLanguageLetterTemplatePage.noTemplatesMessage
-      ).toHaveText(
-        'You do not have any foreign language letter templates yet.'
-      );
+      ).toHaveText('You do not have any o language letter templates yet.');
 
       await chooseOtherLanguageLetterTemplatePage.goToTemplatesLink.click();