Skip to content

Commit 9368e03

Browse files
committed
fixed e2e and event tests
1 parent 16984aa commit 9368e03

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

tests/test-team/helpers/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ type TypeSpecificProperties = {
4242
personalisationParameters?: string[];
4343
testDataCsvHeaders?: string[];
4444
campaignId?: string;
45+
supplierReferences?: Record<string, string>;
4546
};
4647

4748
export type CreateTemplatePayload = TypeSpecificProperties & {

tests/test-team/template-mgmt-api-tests/update-template.api.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { TemplateAPIPayloadFactory } from '../helpers/factories/template-api-pay
1313
import { pdfUploadFixtures } from '../fixtures/pdf-upload/multipart-pdf-letter-fixtures';
1414
import { TemplateFactory } from '../helpers/factories/template-factory';
1515

16-
test.describe('POST /v1/template/:templateId', () => {
16+
test.describe('PUT /v1/template/:templateId', () => {
1717
const authHelper = createAuthHelper();
1818
const templateStorageHelper = new TemplateStorageHelper();
1919
let user1: TestUser;
@@ -32,7 +32,7 @@ test.describe('POST /v1/template/:templateId', () => {
3232
});
3333

3434
test('returns 401 if no auth token', async ({ request }) => {
35-
const response = await request.post(
35+
const response = await request.put(
3636
`${process.env.API_BASE_URL}/v1/template/some-template`
3737
);
3838
expect(response.status()).toBe(401);
@@ -1392,7 +1392,7 @@ test.describe('POST /v1/template/:templateId', () => {
13921392
clientId: user1.clientId,
13931393
});
13941394

1395-
const updateNHSAppResponse = await request.post(
1395+
const updateNHSAppResponse = await request.put(
13961396
`${process.env.API_BASE_URL}/v1/template/${created.data.id}`,
13971397
{
13981398
headers: {

tests/test-team/template-mgmt-e2e-tests/template-mgmt-proof-request.e2e.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,10 @@ test.describe('SFTP proof request send', () => {
110110
const updatedTemplate = await templateStorageHelper.getTemplate(key);
111111
const debugUpdated = JSON.stringify(updatedTemplate);
112112

113-
expect(updatedTemplate.updatedAt, debugUpdated).not.toBe(
114-
template.updatedAt
115-
);
113+
expect(
114+
Object.keys(updatedTemplate.supplierReferences ?? {}),
115+
debugUpdated
116+
).toEqual([MOCK_LETTER_SUPPLIER]);
116117
}).toPass({ timeout: 5000 });
117118

118119
const sftpCredentials = await sftpHelper.connect();

tests/test-team/template-mgmt-event-tests/digital-templates.event.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ test.describe('Event publishing - Digital', () => {
5757
clientId: user1.clientId,
5858
});
5959

60-
const updateResponse = await request.post(
60+
const updateResponse = await request.put(
6161
`${process.env.API_BASE_URL}/v1/template/${templateId}`,
6262
{
6363
headers: {

0 commit comments

Comments
 (0)