CCM-10424 Log in as user

Author: nicki-nhs

tests/test-team/config/component/component.setup.ts

@@ -5,11 +5,11 @@
 import path from 'node:path';
 import { test as setup } from '@playwright/test';
 import { BackendConfigHelper } from 'nhs-notify-web-template-management-util-backend-config';
-import { TemplateMgmtSignInPage } from '../../pages/templates-mgmt-login-page';
 import {
   createAuthHelper,
   testUsers,
 } from '../../helpers/auth/cognito-auth-helper';
+import { loginAsUser } from '../../helpers/auth/login-as-user';
 
 setup('component test setup', async ({ page }) => {
   const backendConfig = BackendConfigHelper.fromTerraformOutputsFile(
@@ -24,11 +24,7 @@ setup('component test setup', async ({ page }) => {
 
   const user = await auth.getTestUser(testUsers.User1.userId);
 
-  const loginPage = new TemplateMgmtSignInPage(page);
-
-  await loginPage.loadPage();
-
-  await loginPage.cognitoSignIn(user);
+  await loginAsUser(user, page)
 
   await page.waitForURL('/templates/create-and-submit-templates');
 

tests/test-team/helpers/auth/login-as-user.ts

@@ -0,0 +1,11 @@
+import { Page } from "@playwright/test";
+import { TestUser } from "./cognito-auth-helper";
+import { TemplateMgmtSignInPage } from "../../pages/templates-mgmt-login-page";
+
+export const loginAsUser = async (user: TestUser, page: Page) => {
+  const loginPage = new TemplateMgmtSignInPage(page);
+
+  await loginPage.loadPage();
+
+  await loginPage.cognitoSignIn(user);
+}

tests/test-team/template-mgmt-component-tests/letter/template-mgmt-create-letter-template-page.component.spec.ts

@@ -14,6 +14,7 @@ import {
 } from '../../helpers/auth/cognito-auth-helper';
 import { TemplateMgmtCreateLetterPage } from '../../pages/letter/template-mgmt-create-letter-page';
 import { TemplateMgmtCreateLetterMissingCampaignClientIdPage } from '../../pages/letter/template-mgmt-create-letter-missing-campaign-client-id-page';
+import { loginAsUser } from '../../helpers/auth/login-as-user';
 
 test.describe('Create Letter Template Page', () => {
   const templateStorageHelper = new TemplateStorageHelper();
@@ -49,35 +50,29 @@ test.describe('Create Letter Template Page', () => {
   });
 
   test('redirects to error page when campaign ID is missing', async ({ page, baseURL }) => {
-    // set user to userWithoutCampaignId
+    await loginAsUser(userWithoutCampaignId, page);
+
     const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
     const missingClientOrCampaignIdErrorPage = new TemplateMgmtCreateLetterMissingCampaignClientIdPage(page);
 
     createTemplatePage.loadPage();
 
     await expect(page).toHaveURL(`${baseURL}/${TemplateMgmtCreateLetterMissingCampaignClientIdPage.pageUrlSegment}`);
 
-    await expect(missingClientOrCampaignIdErrorPage.heading).toHaveText('You cannot create letter templates yet');
-    await expect(missingClientOrCampaignIdErrorPage.errorDetailsInsetText).toHaveText('Account needs a client ID and campaign ID');
-
-    await expect(missingClientOrCampaignIdErrorPage.goBackLink).toHaveText('Go back');
-    await expect(missingClientOrCampaignIdErrorPage.goBackLink).toHaveAttribute('href', '/templates/choose-a-template-type');
+    await assertMissingClientOrCampaignIdErrorPage(missingClientOrCampaignIdErrorPage);
   });
 
   test('redirects to error page when client ID is missing', async ({ page, baseURL }) => {
-    // set user to userWithoutClientId
+    await loginAsUser(userWithoutClientId, page);
+
     const createTemplatePage = new TemplateMgmtCreateLetterPage(page);
     const missingClientOrCampaignIdErrorPage = new TemplateMgmtCreateLetterMissingCampaignClientIdPage(page);
 
     createTemplatePage.loadPage();
 
     await expect(page).toHaveURL(`${baseURL}/${TemplateMgmtCreateLetterMissingCampaignClientIdPage.pageUrlSegment}`);
 
-    await expect(missingClientOrCampaignIdErrorPage.heading).toHaveText('You cannot create letter templates yet');
-    await expect(missingClientOrCampaignIdErrorPage.errorDetailsInsetText).toHaveText('Account needs a client ID and campaign ID');
-
-    await expect(missingClientOrCampaignIdErrorPage.goBackLink).toHaveText('Go back');
-    await expect(missingClientOrCampaignIdErrorPage.goBackLink).toHaveAttribute('href', '/templates/choose-a-template-type');
+    await assertMissingClientOrCampaignIdErrorPage(missingClientOrCampaignIdErrorPage);
   });
 
   test('Validate error messages on the create Letter template page with no template name or pdf', async ({
@@ -195,4 +190,12 @@ test.describe('Create Letter Template Page', () => {
       await expect(newTab).toHaveURL(`${baseURL}/${url}`);
     });
   }
+
+  const assertMissingClientOrCampaignIdErrorPage = async (page: TemplateMgmtCreateLetterMissingCampaignClientIdPage) => {
+    await expect(page.heading).toHaveText('You cannot create letter templates yet');
+    await expect(page.errorDetailsInsetText).toHaveText('Account needs a client ID and campaign ID');
+
+    await expect(page.goBackLink).toHaveText('Go back');
+    await expect(page.goBackLink).toHaveAttribute('href', '/templates/choose-a-template-type');
+  }
 });

tests/test-team/template-mgmt-component-tests/template-mgmt-logout-warning.component.modal.spec.ts

@@ -4,7 +4,7 @@ import {
   type TestUser,
   testUsers,
 } from '../helpers/auth/cognito-auth-helper';
-import { TemplateMgmtSignInPage } from '../pages/templates-mgmt-login-page';
+import { loginAsUser } from '../helpers/auth/login-as-user';
 
 test.use({ storageState: { cookies: [], origins: [] } });
 
@@ -26,11 +26,7 @@ test.describe('Logout warning', () => {
   test('logout warning should pop up and close after clicking "Stay signed in"', async ({
     page,
   }) => {
-    const loginPage = new TemplateMgmtSignInPage(page);
-
-    await loginPage.loadPage();
-
-    await loginPage.cognitoSignIn(staySignedInUser);
+    await loginAsUser(staySignedInUser, page);
 
     const dialog = page.locator('dialog');
 
@@ -44,11 +40,7 @@ test.describe('Logout warning', () => {
   test('logout warning should pop up and close after user clicks "Sign out"', async ({
     page,
   }) => {
-    const loginPage = new TemplateMgmtSignInPage(page);
-
-    await loginPage.loadPage();
-
-    await loginPage.cognitoSignIn(manualSignOutUser);
+    await loginAsUser(manualSignOutUser, page);
 
     const dialog = page.locator('dialog');
 
@@ -60,11 +52,7 @@ test.describe('Logout warning', () => {
   });
 
   test('logout warning should force logout after timeout', async ({ page }) => {
-    const loginPage = new TemplateMgmtSignInPage(page);
-
-    await loginPage.loadPage();
-
-    await loginPage.cognitoSignIn(automaticallySignedOutUser);
+    await loginAsUser(automaticallySignedOutUser, page);
 
     const dialog = page.locator('dialog');