CCM-8961: Only allow letter submit on NOT_YET_SUBMITTED (#393)

Author: ClareJonesBJSS

frontend/src/__tests__/components/molecules/__snapshots__/MessageTemplates.test.tsx.snap

@@ -484,6 +484,16 @@ exports[`MessageTemplates component matches snapshot with pending proof request
                     Copy
                   </a>
                 </p>
+                <p
+                  class="nhsuk-u-margin-bottom-2"
+                >
+                  <a
+                    aria-label="Delete Template 1"
+                    href="/delete-template/1"
+                  >
+                    Delete
+                  </a>
+                </p>
               </div>
             </td>
           </tr>

frontend/src/__tests__/components/molecules/__snapshots__/ZodErrorSummary.test.tsx.snap

@@ -25,11 +25,16 @@ exports[`Renders ZodErrorSummary correctly with errors 1`] = `
           Field error
         </a>
       </li>
-      <li>
-        <a>
-          Form error
-        </a>
-      </li>
+      <span
+        class="nhsuk-error-message"
+      >
+        <span
+          class="nhsuk-u-visually-hidden"
+        >
+          Error: 
+        </span>
+        Form error
+      </span>
     </ul>
   </div>
 </DocumentFragment>

frontend/src/__tests__/components/organisms/PreviewLetterTemplate.test.tsx

@@ -1,15 +1,42 @@
-import { render } from '@testing-library/react';
 import { PreviewLetterTemplate } from '@organisms/PreviewLetterTemplate/PreviewLetterTemplate';
+import { render } from '@testing-library/react';
 
 describe('PreviewLetterTemplate component', () => {
-  it('matches snapshot', () => {
+  it('matches snapshot when template status is VIRUS_SCAN_FAILED', () => {
+    const container = render(
+      <PreviewLetterTemplate
+        template={{
+          templateType: 'LETTER',
+          name: 'test-template-letter',
+          id: 'template-id',
+          templateStatus: 'VIRUS_SCAN_FAILED',
+          language: 'en',
+          letterType: 'q1',
+          files: {
+            pdfTemplate: {
+              fileName: 'file.pdf',
+              currentVersion: '4C728B7D-A028-4BA2-B180-A63CDD2AE1E9',
+              virusScanStatus: 'FAILED',
+            },
+            testDataCsv: undefined,
+          },
+          createdAt: '2025-04-02T09:33:25.729Z',
+          updatedAt: '2025-04-02T09:33:25.729Z',
+        }}
+      />
+    );
+
+    expect(container.asFragment()).toMatchSnapshot();
+  });
+
+  it('matches snapshot when template status is PENDING_PROOF_REQUEST', () => {
     const container = render(
       <PreviewLetterTemplate
         template={{
           id: '53525D03-1BC1-4563-ABF9-A74FF04142AF',
           name: 'letter',
           templateType: 'LETTER',
-          templateStatus: 'NOT_YET_SUBMITTED',
+          templateStatus: 'PENDING_PROOF_REQUEST',
           letterType: 'q4',
           language: 'ar',
           files: {
@@ -28,23 +55,53 @@ describe('PreviewLetterTemplate component', () => {
     expect(container.asFragment()).toMatchSnapshot();
   });
 
-  it('matches snapshot when template status is VIRUS_SCAN_FAILED', () => {
+  it('matches snapshot when template status is NOT_YET_SUBMITTED', () => {
+    const container = render(
+      <PreviewLetterTemplate
+        template={{
+          id: '0A097DCD-35F9-4DAD-A37E-AC358B71B74D',
+          name: 'letter',
+          templateType: 'LETTER',
+          templateStatus: 'NOT_YET_SUBMITTED',
+          letterType: 'x0',
+          language: 'en',
+          files: {
+            pdfTemplate: {
+              fileName: 'file.pdf',
+              currentVersion: 'b',
+              virusScanStatus: 'PASSED',
+            },
+          },
+          createdAt: '2025-04-02T09:33:25.729Z',
+          updatedAt: '2025-04-02T09:33:25.729Z',
+        }}
+      />
+    );
+
+    expect(container.asFragment()).toMatchSnapshot();
+  });
+
+  it('matches snapshot when template status is VALIDATION_FAILED', () => {
     const container = render(
       <PreviewLetterTemplate
         template={{
           templateType: 'LETTER',
           name: 'test-template-letter',
           id: 'template-id',
-          templateStatus: 'VIRUS_SCAN_FAILED',
+          templateStatus: 'VALIDATION_FAILED',
           language: 'en',
           letterType: 'q1',
           files: {
             pdfTemplate: {
               fileName: 'file.pdf',
-              currentVersion: '4C728B7D-A028-4BA2-B180-A63CDD2AE1E9',
-              virusScanStatus: 'FAILED',
+              currentVersion: 'a',
+              virusScanStatus: 'PASSED',
+            },
+            testDataCsv: {
+              fileName: 'file.csv',
+              currentVersion: 'a',
+              virusScanStatus: 'PASSED',
             },
-            testDataCsv: undefined,
           },
           createdAt: '2025-04-02T09:33:25.729Z',
           updatedAt: '2025-04-02T09:33:25.729Z',
@@ -55,21 +112,21 @@ describe('PreviewLetterTemplate component', () => {
     expect(container.asFragment()).toMatchSnapshot();
   });
 
-  it('matches snapshot when template status is PENDING_PROOF_REQUEST', () => {
+  it('matches snapshot when template status is PENDING_UPLOAD', () => {
     const container = render(
       <PreviewLetterTemplate
         template={{
-          id: '53525D03-1BC1-4563-ABF9-A74FF04142AF',
-          name: 'letter',
           templateType: 'LETTER',
-          templateStatus: 'PENDING_PROOF_REQUEST',
-          letterType: 'q4',
-          language: 'ar',
+          name: 'test-template-letter',
+          id: 'template-id',
+          templateStatus: 'PENDING_UPLOAD',
+          language: 'en',
+          letterType: 'q1',
           files: {
             pdfTemplate: {
               fileName: 'file.pdf',
               currentVersion: 'a',
-              virusScanStatus: 'PASSED',
+              virusScanStatus: 'PENDING',
             },
           },
           createdAt: '2025-04-02T09:33:25.729Z',
@@ -81,20 +138,20 @@ describe('PreviewLetterTemplate component', () => {
     expect(container.asFragment()).toMatchSnapshot();
   });
 
-  it('matches snapshot when template status is NOT_YET_SUBMITTED', () => {
+  it('matches snapshot when template status is PENDING_VALIDATION', () => {
     const container = render(
       <PreviewLetterTemplate
         template={{
-          id: '0A097DCD-35F9-4DAD-A37E-AC358B71B74D',
-          name: 'letter',
           templateType: 'LETTER',
-          templateStatus: 'NOT_YET_SUBMITTED',
-          letterType: 'x0',
+          name: 'test-template-letter',
+          id: 'template-id',
+          templateStatus: 'PENDING_VALIDATION',
           language: 'en',
+          letterType: 'q1',
           files: {
             pdfTemplate: {
               fileName: 'file.pdf',
-              currentVersion: 'b',
+              currentVersion: 'a',
               virusScanStatus: 'PASSED',
             },
           },