Merge pull request #164 from NHSDigital/feature/nhs-app-tests

CCM-7083: Add NHS App to submit template and template submitted tests

Author: chris-elliott-nhsd

src/app/submit-nhs-app-template/[sessionId]/page.tsx

@@ -2,15 +2,20 @@
 
 import { redirect, RedirectType } from 'next/navigation';
 import { SubmitTemplate } from '@forms/SubmitTemplate/SubmitTemplate';
-import { PageProps } from '@utils/types';
+import { PageProps, Session, TemplateType } from '@utils/types';
 import { getSession } from '@utils/form-actions';
 
+const isValid = (session?: Session) =>
+  session?.templateType === TemplateType.NHS_APP &&
+  Boolean(session?.nhsAppTemplateName) &&
+  Boolean(session?.nhsAppTemplateMessage);
+
 const SubmitNhsAppTemplatePage = async ({
   params: { sessionId },
 }: PageProps) => {
   const session = await getSession(sessionId);
 
-  if (!session) {
+  if (!session || !isValid(session)) {
     redirect('/invalid-session', RedirectType.replace);
   }
 

tests/test-team/helpers/session-factory.ts

@@ -15,6 +15,13 @@ export const SessionFactory = {
     });
   },
 
+  createNhsAppSession: (id: string): Session => {
+    return SessionFactory.create({
+      id,
+      templateType: TemplateType.NHS_APP,
+    });
+  },
+
   create: ({
     id,
     templateType,

tests/test-team/template-mgmt-component-tests/template-mgmt-submit-page.component.ts

@@ -30,6 +30,11 @@ const smsFields = {
   smsTemplateMessage: 'test-template-message',
 };
 
+const nhsAppFields = {
+  nhsAppTemplateName: 'test-template-name',
+  nhsAppTemplateMessage: 'test-template-message',
+};
+
 const sessions = {
   email: {
     empty: SessionFactory.createEmailSession('empty-email-submit-session'),
@@ -61,11 +66,29 @@ const sessions = {
       ...smsFields,
     },
   },
+  'nhs-app': {
+    empty: SessionFactory.createNhsAppSession('empty-nhs-app-submit-session'),
+    submit: {
+      ...SessionFactory.createNhsAppSession('submit-nhs-app-submit-session'),
+      ...nhsAppFields,
+    },
+    submitAndReturn: {
+      ...SessionFactory.createNhsAppSession(
+        'submit-and-return-nhs-app-session'
+      ),
+      ...nhsAppFields,
+    },
+    valid: {
+      ...SessionFactory.createNhsAppSession('valid-nhs-app-submit-session'),
+      ...nhsAppFields,
+    },
+  },
 };
 
 const sessionsList = [
   ...Object.values(sessions.email),
   ...Object.values(sessions['text-message']),
+  ...Object.values(sessions['nhs-app']),
 ];
 
 test.describe('Submit template Page', () => {
@@ -85,6 +108,7 @@ test.describe('Submit template Page', () => {
   for (const { channelName, channelIdentifier } of [
     { channelName: 'Email', channelIdentifier: 'email' },
     { channelName: 'SMS', channelIdentifier: 'text-message' },
+    { channelName: 'NHS App', channelIdentifier: 'nhs-app' },
   ] as const) {
     test(`when user visits ${channelName} page, then page is loaded`, async ({
       page,

tests/test-team/template-mgmt-component-tests/template-mgmt-submitted-page.component.ts

@@ -2,6 +2,7 @@ import { test, expect } from '@playwright/test';
 import { TemplateStorageHelper } from '../helpers/template-storage-helper';
 import {
   assertFooterLinks,
+  assertGoBackLinkNotPresent,
   assertLoginLink,
   assertNotifyBannerLink,
   assertSkipToMainContent,
@@ -27,6 +28,14 @@ const templates = {
       content: 'test example content',
     },
   }),
+  'nhs-app': TemplateFactory.create({
+    type: TemplateType.NHS_APP,
+    id: 'valid-nhs-app-template',
+    name: 'test-template-nhs-app',
+    fields: {
+      content: 'test example content',
+    },
+  }),
 };
 
 test.describe('Submit Email message template Page', () => {
@@ -45,6 +54,7 @@ test.describe('Submit Email message template Page', () => {
   for (const { channelName, channelIdentifier } of [
     { channelName: 'Email', channelIdentifier: 'email' },
     { channelName: 'SMS', channelIdentifier: 'text-message' },
+    { channelName: 'NHS App', channelIdentifier: 'nhs-app' },
   ] as const) {
     test(`when user visits ${channelName} page, then page is loaded`, async ({
       page,
@@ -91,6 +101,7 @@ test.describe('Submit Email message template Page', () => {
         await assertNotifyBannerLink(props);
         await assertFooterLinks(props);
         await assertLoginLink(props);
+        await assertGoBackLinkNotPresent(props);
       });
 
       test(`when user submits clicks ${channelName} "Create another template", then user is redirected to "create-template"`, async ({