undo pa11y changes

Author: alexnuttall

tests/accessibility/.pa11y-ci.js

@@ -14,7 +14,6 @@ const {
   emailTemplateSubmittedPage,
   letterTemplateSubmittedPage,
   messageTemplatesPage,
-  messagePlansPage,
   nhsAppTemplateSubmittedPage,
   previewEmailTemplateErrorPage,
   previewEmailTemplatePage,
@@ -114,10 +113,6 @@ const letters = [
   previewSubmittedLetterTemplatePage(messageTemplatesUrl),
 ];
 
-const messagePlans = [
-  messagePlansPage(`${baseUrl}/message-plans`)
-]
-
 const landingPage = [{ url: startUrl, name: 'landing-page' }];
 
 const errors = [
@@ -154,7 +149,6 @@ const allJourneys = {
   letters,
   userEmails,
   errors,
-  messagePlans,
 };
 
 const selectedJourney = process.env.JOURNEY && allJourneys[process.env.JOURNEY]

tests/accessibility/actions/index.js

@@ -8,7 +8,6 @@ module.exports = {
   ...require('./email-template-submitted.actions'),
   ...require('./letter-template-submitted.actions'),
   ...require('./message-templates.actions'),
-  ...require('./message-plans.actions'),
   ...require('./nhs-app-template-submitted.actions'),
   ...require('./preview-email-template.actions'),
   ...require('./preview-letter-template.actions'),

tests/accessibility/actions/message-plans.actions.js

@@ -64,34 +64,6 @@ const generateLetterTemplateData = (
   };
 };
 
-const generateRoutingConfig = ({
-  clientId,
-  now,
-}: {
-  clientId: string;
-  now: string;
-}) => ({
-  owner: `CLIENT#${clientId}`,
-  id: randomUUID(),
-  campaignId: 'campaignId',
-  cascade: [
-    {
-      cascadeGroups: ['standard'],
-      channel: 'EMAIL',
-      channelType: 'primary',
-      defaultTemplateId: 'email_id',
-    },
-  ],
-  cascadeGroupOverrides: [{ name: 'standard' }],
-  clientId,
-  createdAt: now,
-  createdBy: 'Accessibility tests',
-  name: 'Accessibility Test',
-  status: 'DRAFT',
-  updatedAt: now,
-  updatedBy: 'Accessibility tests',
-});
-
 const setup = async () => {
   const backendConfig = BackendConfigHelper.fromTerraformOutputsFile(
     path.join(__dirname, '..', '..', 'sandbox_tf_outputs.json')
@@ -176,40 +148,25 @@ const setup = async () => {
     ),
   ];
 
-  const routingConfigs = [
-    generateRoutingConfig({ clientId, now: new Date().toISOString() }),
-  ];
-
-  await Promise.all([
-    ...templates.map((template) => {
+  await Promise.all(
+    templates.map((template) =>
       ddbDocClient.send(
         new PutCommand({
           TableName: backendConfig.templatesTableName,
           Item: template,
         })
-      );
-    }),
-    ...routingConfigs.map((rc) =>
-      ddbDocClient.send(
-        new PutCommand({
-          TableName: backendConfig.routingConfigTableName,
-          Item: rc,
-        })
       )
-    ),
-  ]);
+    )
+  );
 
   const templateIds = Object.fromEntries(
     templates.map((t) => [t.templateStatus, t.id])
   );
 
-  const routingConfigIds = routingConfigs.map((r) => r.id);
-
   const fixtureData = {
     email: testEmail,
     password: testPassword,
     templateIds,
-    routingConfigIds,
     userId,
     clientId,
     clientName,

tests/accessibility/pa11y-setup.ts

@@ -5,7 +5,7 @@ import { DeleteCommand, DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
 import { BackendConfigHelper } from 'nhs-notify-web-template-management-util-backend-config';
 import path from 'node:path';
 
-const { email, templateIds, clientId, routingConfigIds } = JSON.parse(
+const { email, templateIds, clientId } = JSON.parse(
   readFileSync('./pa11y-fixtures.json', 'utf8')
 );
 
@@ -18,8 +18,8 @@ const teardown = async () => {
     path.join(__dirname, '..', '..', 'sandbox_tf_outputs.json')
   );
 
-  await Promise.all([
-    ...Object.values(templateIds).map((id) =>
+  await Promise.all(
+    Object.values(templateIds).map((id) =>
       ddbDocClient.send(
         new DeleteCommand({
           TableName: backendConfig.templatesTableName,
@@ -29,19 +29,8 @@ const teardown = async () => {
           },
         })
       )
-    ),
-    ...(routingConfigIds as string[]).map((id) =>
-      ddbDocClient.send(
-        new DeleteCommand({
-          TableName: backendConfig.routingConfigTableName,
-          Key: {
-            owner: `CLIENT#${clientId}`,
-            id,
-          },
-        })
-      )
-    ),
-  ]);
+    )
+  );
 
   await new TestUserClient(
     backendConfig.userPoolId,

tests/accessibility/pa11y-teardown.ts

@@ -38,7 +38,7 @@ export class TestUserClient {
       new PutParameterCommand({
         Name: `${this.clientSsmPathPrefix}/${clientId}`,
         Value: JSON.stringify({
-          features: { proofing: true, routing: true },
+          features: { proofing: true },
           campaignId: 'accessibility-test-campaign',
         } satisfies ClientConfiguration),
         Overwrite: true,