move sg list inside vpc object on lambda vars

Author: alexnuttall

infrastructure/terraform/modules/lambda-function/README.md

@@ -19,11 +19,10 @@ No requirements.
 | <a name="input_log_retention_in_days"></a> [log\_retention\_in\_days](#input\_log\_retention\_in\_days) | Specifies the number of days you want to retain log events in the log group for this Lambda | `number` | `0` | no |
 | <a name="input_memory_size"></a> [memory\_size](#input\_memory\_size) | Lambda memory size | `number` | `128` | no |
 | <a name="input_runtime"></a> [runtime](#input\_runtime) | Identifier of the function's runtime | `string` | `"nodejs20.x"` | no |
-| <a name="input_security_group_ids"></a> [security\_group\_ids](#input\_security\_group\_ids) | n/a | `list(string)` | `[]` | no |
 | <a name="input_source_code_hash"></a> [source\_code\_hash](#input\_source\_code\_hash) | Base64-encoded SHA256 hash of the package file specified by `filename` | `string` | n/a | yes |
 | <a name="input_sqs_event_source_mapping"></a> [sqs\_event\_source\_mapping](#input\_sqs\_event\_source\_mapping) | Configuration for SQS event source mapping | <pre>object({<br/>    sqs_queue_arn                      = string<br/>    batch_size                         = optional(number, 10)<br/>    maximum_batching_window_in_seconds = optional(number, 0)<br/>    scaling_config = optional(object({<br/>      maximum_concurrency = number<br/>    }), null)<br/>  })</pre> | `null` | no |
 | <a name="input_timeout"></a> [timeout](#input\_timeout) | Maximum running time before timeout | `number` | `3` | no |
-| <a name="input_vpc"></a> [vpc](#input\_vpc) | VPC details | <pre>object({<br/>    id         = string<br/>    cidr_block = string<br/>    subnet_ids = set(string)<br/>  })</pre> | `null` | no |
+| <a name="input_vpc"></a> [vpc](#input\_vpc) | VPC details | <pre>object({<br/>    id                 = string<br/>    cidr_block         = string<br/>    subnet_ids         = set(string)<br/>    security_group_ids = list(string)<br/>  })</pre> | `null` | no |
 ## Modules
 
 No modules.

infrastructure/terraform/modules/lambda-function/variables.tf

@@ -68,18 +68,14 @@ variable "dead_letter_target_arn" {
 variable "vpc" {
   description = "VPC details"
   type = object({
-    id         = string
-    cidr_block = string
-    subnet_ids = set(string)
+    id                 = string
+    cidr_block         = string
+    subnet_ids         = set(string)
+    security_group_ids = list(string)
   })
   default = null
 }
 
-variable "security_group_ids" {
-  type    = list(string)
-  default = []
-}
-
 variable "sqs_event_source_mapping" {
   description = "Configuration for SQS event source mapping"
   type = object({