CCM-8620: merge

Author: mark-r-bjss

frontend/src/__tests__/app/copy-template/page.test.tsx

@@ -9,7 +9,12 @@ import {
 } from 'nhs-notify-web-template-management-utils';
 import { redirect } from 'next/navigation';
 import { getTemplate } from '@utils/form-actions';
-import { TemplateDTO } from 'nhs-notify-backend-client';
+import {
+  Language,
+  LetterType,
+  TemplateDTO,
+  VirusScanStatus,
+} from 'nhs-notify-backend-client';
 
 jest.mock('@utils/form-actions');
 jest.mock('next/navigation');
@@ -21,7 +26,7 @@ const getTemplateMock = jest.mocked(getTemplate);
 describe('CopyTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
-  const template: TemplateDTO = {
+  const template = {
     id: 'template-id',
     templateType: TemplateType.EMAIL,
     templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
@@ -30,6 +35,29 @@ describe('CopyTemplatePage', () => {
     message: 'template-message',
     createdAt: '2025-01-13T10:19:25.579Z',
     updatedAt: '2025-01-13T10:19:25.579Z',
+  } satisfies TemplateDTO;
+
+  const letterTemplate: TemplateDTO = {
+    id: 'template-id',
+    templateType: TemplateType.LETTER,
+    templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
+    name: 'template-name',
+    createdAt: '2025-01-13T10:19:25.579Z',
+    updatedAt: '2025-01-13T10:19:25.579Z',
+    letterType: LetterType.Q4,
+    language: Language.FR,
+    files: {
+      pdfTemplate: {
+        fileName: 'file.pdf',
+        currentVersion: '61C1267A-0F37-4E1D-831E-494DE2BECC8C',
+        virusScanStatus: VirusScanStatus.PASSED,
+      },
+      testDataCsv: {
+        fileName: 'file.csv',
+        currentVersion: 'A8A76934-70F4-4735-8314-51CE097130DB',
+        virusScanStatus: VirusScanStatus.PASSED,
+      },
+    },
   };
 
   it('should load page', async () => {
@@ -53,4 +81,16 @@ describe('CopyTemplatePage', () => {
 
     expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
   });
+
+  it('should redirect to invalid-template when the template is a letter', async () => {
+    getTemplateMock.mockResolvedValueOnce(letterTemplate);
+
+    await CopyTemplatePage({
+      params: Promise.resolve({
+        templateId: 'template-id',
+      }),
+    });
+
+    expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
+  });
 });

frontend/src/__tests__/app/delete-template/page.test.tsx

@@ -23,7 +23,7 @@ describe('PreviewEmailTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should load page', async () => {
-    const templateDTO: TemplateDTO = {
+    const templateDTO = {
       id: 'template-id',
       templateType: TemplateType.EMAIL,
       templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
@@ -32,7 +32,7 @@ describe('PreviewEmailTemplatePage', () => {
       message: 'template-message',
       createdAt: '2025-01-13T10:19:25.579Z',
       updatedAt: '2025-01-13T10:19:25.579Z',
-    };
+    } satisfies TemplateDTO;
 
     const emailTemplate: EmailTemplate = {
       ...templateDTO,

frontend/src/__tests__/app/edit-email-template/page.test.tsx

@@ -19,7 +19,7 @@ jest.mock('@forms/EmailTemplateForm/EmailTemplateForm');
 const getTemplateMock = jest.mocked(getTemplate);
 const redirectMock = jest.mocked(redirect);
 
-const templateDTO: TemplateDTO = {
+const templateDTO = {
   id: 'template-id',
   templateType: TemplateType.EMAIL,
   templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
@@ -28,7 +28,7 @@ const templateDTO: TemplateDTO = {
   message: 'message',
   createdAt: '2025-01-13T10:19:25.579Z',
   updatedAt: '2025-01-13T10:19:25.579Z',
-};
+} satisfies TemplateDTO;
 
 describe('EditEmailTemplatePage', () => {
   beforeEach(jest.resetAllMocks);

frontend/src/__tests__/app/edit-nhs-app-template/page.test.tsx

@@ -23,15 +23,15 @@ describe('EditNhsAppTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   test('page loads', async () => {
-    const templateDTO: TemplateDTO = {
+    const templateDTO = {
       id: 'template-id',
       templateType: TemplateType.NHS_APP,
       templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
       name: 'name',
       message: 'message',
       createdAt: '2025-01-13T10:19:25.579Z',
       updatedAt: '2025-01-13T10:19:25.579Z',
-    };
+    } satisfies TemplateDTO;
 
     const nhsAppTemplate: NHSAppTemplate = {
       ...templateDTO,

frontend/src/__tests__/app/edit-text-message-template/page.test.tsx

@@ -19,15 +19,15 @@ jest.mock('@forms/SmsTemplateForm/SmsTemplateForm');
 const getTemplateMock = jest.mocked(getTemplate);
 const redirectMock = jest.mocked(redirect);
 
-const templateDTO: TemplateDTO = {
+const templateDTO = {
   id: 'template-id',
   templateType: TemplateType.SMS,
   templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
   name: 'name',
   message: 'message',
   createdAt: '2025-01-13T10:19:25.579Z',
   updatedAt: '2025-01-13T10:19:25.579Z',
-};
+} satisfies TemplateDTO;
 
 describe('EditSmsTemplatePage', () => {
   beforeEach(jest.resetAllMocks);

frontend/src/__tests__/app/manage-templates/page.test.tsx

@@ -46,6 +46,7 @@ describe('ManageTemplatesPage', () => {
 
     expect(screen.getByTestId('no-templates-available')).toBeInTheDocument();
   });
+
   test('renders the page with templates', async () => {
     jest.mocked(getTemplates).mockResolvedValue(mockTemplates);
     render(await ManageTemplatesPage());

frontend/src/__tests__/app/preview-email-template/page.test.tsx

@@ -2,19 +2,19 @@
  * @jest-environment node
  */
 import PreviewEmailTemplatePage from '@app/preview-email-template/[templateId]/page';
-import { ReviewEmailTemplate } from '@forms/ReviewEmailTemplate';
+import { PreviewEmailTemplate } from '@forms/PreviewEmailTemplate';
 import {
   EmailTemplate,
   TemplateType,
   TemplateStatus,
 } from 'nhs-notify-web-template-management-utils';
 import { redirect } from 'next/navigation';
 import { getTemplate } from '@utils/form-actions';
-import { TemplateDTO } from 'nhs-notify-backend-client';
+import { Language, LetterType, TemplateDTO } from 'nhs-notify-backend-client';
 
 jest.mock('@utils/form-actions');
 jest.mock('next/navigation');
-jest.mock('@forms/ReviewEmailTemplate');
+jest.mock('@forms/PreviewEmailTemplate');
 
 const redirectMock = jest.mocked(redirect);
 const getTemplateMock = jest.mocked(getTemplate);
@@ -23,7 +23,7 @@ describe('PreviewEmailTemplatePage', () => {
   beforeEach(jest.resetAllMocks);
 
   it('should load page', async () => {
-    const templateDTO: TemplateDTO = {
+    const templateDTO = {
       id: 'template-id',
       templateType: TemplateType.EMAIL,
       templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
@@ -32,7 +32,7 @@ describe('PreviewEmailTemplatePage', () => {
       message: 'template-message',
       createdAt: '2025-01-13T10:19:25.579Z',
       updatedAt: '2025-01-13T10:19:25.579Z',
-    };
+    } satisfies TemplateDTO;
 
     const emailTemplate: EmailTemplate = {
       ...templateDTO,
@@ -49,7 +49,7 @@ describe('PreviewEmailTemplatePage', () => {
       }),
     });
 
-    expect(page).toEqual(<ReviewEmailTemplate initialState={emailTemplate} />);
+    expect(page).toEqual(<PreviewEmailTemplate initialState={emailTemplate} />);
   });
 
   it('should redirect to invalid-template when no templateId is found', async () => {
@@ -75,6 +75,12 @@ describe('PreviewEmailTemplatePage', () => {
       subject: 'template-subject-line',
       message: 'template-message',
     },
+    {
+      templateType: TemplateType.LETTER,
+      name: 'template-name',
+      letterType: LetterType.X0,
+      language: Language.EN,
+    },
     {
       templateType: TemplateType.EMAIL,
       name: undefined as unknown as string,

frontend/src/__tests__/app/preview-letter-template/page.test.tsx

@@ -0,0 +1,147 @@
+/**
+ * @jest-environment node
+ */
+import PreviewLetterTemplatePage from '@app/preview-letter-template/[templateId]/page';
+import { PreviewLetterTemplate } from '@forms/PreviewLetterTemplate/PreviewLetterTemplate';
+import {
+  type LetterTemplate,
+  TemplateType,
+  TemplateStatus,
+} from 'nhs-notify-web-template-management-utils';
+import { redirect } from 'next/navigation';
+import { getTemplate } from '@utils/form-actions';
+import {
+  Language,
+  LetterType,
+  TemplateDTO,
+  VirusScanStatus,
+} from 'nhs-notify-backend-client';
+
+jest.mock('@utils/form-actions');
+jest.mock('next/navigation');
+jest.mock('@forms/PreviewLetterTemplate/PreviewLetterTemplate');
+
+const redirectMock = jest.mocked(redirect);
+const getTemplateMock = jest.mocked(getTemplate);
+
+const templateDTO = {
+  id: 'template-id',
+  templateType: TemplateType.LETTER,
+  templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
+  name: 'template-name',
+  createdAt: '2025-01-13T10:19:25.579Z',
+  updatedAt: '2025-01-13T10:19:25.579Z',
+  letterType: LetterType.X0,
+  language: Language.EN,
+  files: {
+    pdfTemplate: {
+      fileName: 'template.pdf',
+      currentVersion: 'saoj867b789',
+      virusScanStatus: VirusScanStatus.PASSED,
+    },
+    testDataCsv: {
+      fileName: 'test-data.csv',
+      currentVersion: '897asiahv87',
+      virusScanStatus: VirusScanStatus.FAILED,
+    },
+  },
+} satisfies TemplateDTO;
+
+const letterTemplate: LetterTemplate = {
+  ...templateDTO,
+  templateType: TemplateType.LETTER,
+  templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
+};
+
+describe('PreviewLetterTemplatePage', () => {
+  beforeEach(() => {
+    jest.resetAllMocks();
+  });
+
+  it('should load page', async () => {
+    getTemplateMock.mockResolvedValueOnce(templateDTO);
+
+    const page = await PreviewLetterTemplatePage({
+      params: Promise.resolve({
+        templateId: 'template-id',
+      }),
+    });
+
+    expect(page).toEqual(
+      <PreviewLetterTemplate initialState={letterTemplate} />
+    );
+  });
+
+  it('should redirect to invalid-template when no template is found', async () => {
+    await PreviewLetterTemplatePage({
+      params: Promise.resolve({
+        templateId: 'template-id',
+      }),
+    });
+
+    expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
+  });
+
+  test.each([
+    {
+      description: 'an email',
+      templateType: TemplateType.EMAIL,
+      name: 'template-name',
+      message: 'template-message',
+    },
+    {
+      description: 'an SMS',
+      templateType: TemplateType.SMS,
+      name: 'template-name',
+      message: 'template-message',
+    },
+    {
+      description: 'an app message',
+      templateType: TemplateType.NHS_APP,
+      name: 'template-name',
+      message: 'template-message',
+    },
+    {
+      description: 'a letter lacking language',
+      language: undefined as unknown as Language,
+    },
+    {
+      description: 'a letter lacking a name',
+      name: undefined as unknown as string,
+    },
+    {
+      description: 'a letter lacking letterType',
+      letterType: undefined as unknown as LetterType,
+    },
+    {
+      description: 'a letter lacking pdfTemplate fileName',
+      files: {
+        pdfTemplate: {
+          fileName: undefined as unknown as string,
+          currentVersion: 'uuid',
+          virusScanStatus: VirusScanStatus.FAILED,
+        },
+      },
+    },
+    {
+      description: 'a letter where files is the wrong data type',
+      files: [] as unknown as LetterTemplate['files'],
+    },
+  ])(
+    'should redirect to invalid-template when template is $description',
+    async ({ description: _, ...value }) => {
+      getTemplateMock.mockResolvedValueOnce({
+        ...templateDTO,
+        ...value,
+      });
+
+      await PreviewLetterTemplatePage({
+        params: Promise.resolve({
+          templateId: 'template-id',
+        }),
+      });
+
+      expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
+    }
+  );
+});