CCM-8420: remove confirmation email

Author: mark-r-bjss

.github/workflows/stage-4-acceptance.yaml

@@ -106,9 +106,6 @@ jobs:
       - name: "Repo setup"
         run: |
           npm ci
-      - name: "Generate dependencies"
-        run: |
-          npm run generate-dependencies --workspaces --if-present
       - name: Configure AWS credentials
         uses: aws-actions/configure-aws-credentials@v4
         with:
@@ -144,9 +141,6 @@ jobs:
       - name: "Repo setup"
         run: |
           npm ci
-      - name: "Generate dependencies"
-        run: |
-          npm run generate-dependencies --workspaces --if-present
       - name: Install Playwright Browsers
         run: npx playwright install --with-deps
       - name: Configure AWS credentials

README.md

@@ -37,40 +37,27 @@
 
 ### Running the project locally
 
-1. Convert the email HTML template into a JSON file that can be packaged with the email sending lambda.
-
-   ```shell
-   npm run generate-dependencies
-   ```
-
-2. (Optional) If you want to test sending emails then you will need to set the following environment variables locally.
-
-   ```shell
-   export ACCOUNT_ID=<aws_account_id>
-   export NOTIFY_DOMAIN_NAME=<ses_verified_domain>
-   ```
-
-3. To create a Terraform backend sandbox, run:
+1. To create a Terraform backend sandbox, run:
 
    ```shell
    npm run create-backend-sandbox <environment-name>
    ```
 
-4. Then in a separate terminal, run the app locally:
+2. Then in a separate terminal, run the app locally:
 
    ```shell
    npm run dev
    ```
 
-5. Open your browser and go to `localhost:3000` to view the app.
+3. Open your browser and go to `localhost:3000` to view the app.
 
-6. To destroy a Terraform backend sandbox, run:
+4. To destroy a Terraform backend sandbox, run:
 
    ```shell
    npm run destroy-backend-sandbox <environment-name>
    ```
 
-7. (Optional) Create a `.env` file at `frontend/.env` and add `INCLUDE_AUTH_PAGES=true` to include the local auth pages when doing a production Next build
+5. (Optional) Create a `.env` file at `frontend/.env` and add `INCLUDE_AUTH_PAGES=true` to include the local auth pages when doing a production Next build
 
 ### Other commands
 

amplify.yml

@@ -9,7 +9,6 @@ applications:
             - nvm install 20.13.1
             - nvm use 20.13.1
             - npm ci --cache .npm --prefer-offline
-            - npm run generate-dependencies --workspaces --if-present
             - npm run create-amplify-outputs env
             - cd frontend
     frontend:

frontend/jest.config.ts

@@ -28,7 +28,6 @@ const config: Config = {
     '.snap',
     'resource.ts',
     'backend.ts',
-    'generate-dependencies.ts',
     'jest.config.ts',
     '.dev.tsx',
   ],

frontend/src/__tests__/components/forms/SubmitTemplate/server-action.test.ts

@@ -4,7 +4,7 @@
 import { submitTemplate } from '@forms/SubmitTemplate/server-action';
 import { getMockFormData } from '@testhelpers';
 import { redirect } from 'next/navigation';
-import { getTemplate, saveTemplate, sendEmail } from '@utils/form-actions';
+import { getTemplate, saveTemplate } from '@utils/form-actions';
 import {
   TemplateType,
   TemplateStatus,
@@ -18,7 +18,6 @@ jest.mock('@utils/amplify-utils');
 const redirectMock = jest.mocked(redirect);
 const getTemplateMock = jest.mocked(getTemplate);
 const saveTemplateMock = jest.mocked(saveTemplate);
-const sendEmailMock = jest.mocked(sendEmail);
 
 const mockNhsAppTemplate = {
   templateType: TemplateType.NHS_APP,
@@ -65,25 +64,23 @@ describe('submitTemplate', () => {
     expect(redirectMock).toHaveBeenCalledWith('/invalid-template', 'replace');
   });
 
-  it('should handle error when failing to send email', async () => {
+  it('should handle error when failing to save template', async () => {
     getTemplateMock.mockResolvedValueOnce(mockNhsAppTemplate);
 
-    saveTemplateMock.mockResolvedValueOnce(mockNhsAppTemplate);
-
-    sendEmailMock.mockImplementationOnce(() => {
-      throw new Error('failed to send email');
+    saveTemplateMock.mockImplementationOnce(() => {
+      throw new Error('failed to save template');
     });
 
     const formData = getMockFormData({
       templateId: '1',
     });
 
     await expect(submitTemplate('submit-route', formData)).rejects.toThrow(
-      'failed to send email'
+      'failed to save template'
     );
   });
 
-  it('should redirect when successfully sent email', async () => {
+  it('should redirect when successfully submitted', async () => {
     getTemplateMock.mockResolvedValueOnce(mockNhsAppTemplate);
 
     const formData = getMockFormData({
@@ -92,31 +89,17 @@ describe('submitTemplate', () => {
 
     await submitTemplate('submit-route', formData);
 
-    expect(sendEmailMock).toHaveBeenCalledWith(mockNhsAppTemplate.id);
-
+    expect(saveTemplateMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        createdAt: '2025-01-13T10:19:25.579Z',
+        id: '1',
+        message: 'body',
+        name: 'name',
+        templateStatus: 'SUBMITTED',
+        templateType: 'NHS_APP',
+        updatedAt: '2025-01-13T10:19:25.579Z',
+      })
+    );
     expect(redirectMock).toHaveBeenCalledWith('/submit-route/1', 'push');
   });
-
-  it('should send an email with the subject line when template type is EMAIL', async () => {
-    const mockEmailTemplate = {
-      id: 'template-id',
-      templateType: TemplateType.EMAIL,
-      templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
-      name: 'name',
-      subject: 'subjectLine',
-      message: 'body',
-      createdAt: '2025-01-13T10:19:25.579Z',
-      updatedAt: '2025-01-13T10:19:25.579Z',
-    };
-
-    getTemplateMock.mockResolvedValueOnce(mockEmailTemplate);
-
-    const formData = getMockFormData({
-      templateId: 'template-id',
-    });
-
-    await submitTemplate('submit-route', formData);
-
-    expect(sendEmailMock).toHaveBeenCalledWith(mockEmailTemplate.id);
-  });
 });

frontend/src/__tests__/utils/form-actions.test.ts

@@ -11,7 +11,6 @@ import {
   createTemplate,
   saveTemplate,
   getTemplate,
-  sendEmail,
   getTemplates,
 } from '@utils/form-actions';
 import { getAccessTokenServer } from '@utils/amplify-utils';
@@ -274,42 +273,6 @@ describe('form-actions', () => {
     await expect(getTemplates()).rejects.toThrow('Failed to get access token');
   });
 
-  test('sendEmail', async () => {
-    mockedBackendClient.functions.sendEmail.mockResolvedValueOnce({
-      data: undefined,
-      error: undefined,
-    });
-
-    const response = await sendEmail('id');
-
-    expect(mockedBackendClient.functions.sendEmail).toHaveBeenCalledWith('id');
-
-    expect(response).toEqual(undefined);
-  });
-
-  test('sendEmail - should thrown error when no token', async () => {
-    authIdTokenServerMock.mockReset();
-    authIdTokenServerMock.mockResolvedValueOnce(undefined);
-
-    await expect(sendEmail('id')).rejects.toThrow('Failed to get access token');
-  });
-
-  test('getTemplates - should return nothing when an error occurs', async () => {
-    mockedBackendClient.functions.sendEmail.mockResolvedValueOnce({
-      data: undefined,
-      error: {
-        code: 404,
-        message: 'Not found',
-      },
-    });
-
-    const response = await sendEmail('id');
-
-    expect(mockedBackendClient.functions.sendEmail).toHaveBeenCalledWith('id');
-
-    expect(response).toEqual(undefined);
-  });
-
   test('getTemplates - order by createdAt and then id', async () => {
     const baseTemplate = {
       templateType: TemplateType.SMS,

frontend/src/components/forms/SubmitTemplate/server-action.ts

@@ -1,7 +1,7 @@
 'use server';
 
 import { redirect, RedirectType } from 'next/navigation';
-import { getTemplate, saveTemplate, sendEmail } from '@utils/form-actions';
+import { getTemplate, saveTemplate } from '@utils/form-actions';
 import { z } from 'zod';
 import { validateChannelTemplate } from '@utils/validate-template';
 import { TemplateStatus } from 'nhs-notify-web-template-management-utils';
@@ -31,8 +31,6 @@ export async function submitTemplate(route: string, formData: FormData) {
       ...validatedTemplate,
       templateStatus: TemplateStatus.SUBMITTED,
     });
-
-    await sendEmail(templateId);
   } catch (error) {
     logger.error('Failed to submit template', {
       error,

frontend/src/utils/form-actions.ts

@@ -71,23 +71,6 @@ export async function getTemplate(
   return data;
 }
 
-export async function sendEmail(templateId: string) {
-  const token = await getAccessTokenServer();
-
-  if (!token) {
-    throw new Error('Failed to get access token');
-  }
-
-  const { error } = await BackendClient(token).functions.sendEmail(templateId);
-
-  if (error) {
-    logger.error({
-      description: 'Error sending email',
-      error,
-    });
-  }
-}
-
 export async function getTemplates(): Promise<TemplateDTO[]> {
   const token = await getAccessTokenServer();
 

infrastructure/terraform/components/app/module_backend_api.tf

@@ -8,7 +8,6 @@ module "backend_api" {
   group                 = var.group
   csi                   = local.csi
   log_retention_in_days = var.log_retention_in_days
-  email_domain_name     = local.root_domain_name
 
   cognito_config        = jsondecode(data.aws_ssm_parameter.cognito_config.value)
 }

infrastructure/terraform/components/sandbox/module_backend_api.tf

@@ -8,7 +8,6 @@ module "backend_api" {
   group                 = var.group
   csi                   = local.csi
   log_retention_in_days = var.log_retention_in_days
-  email_domain_name     = "no-domain"
 
   cognito_config = {
     USER_POOL_ID        = aws_cognito_user_pool.sandbox.id