Merge pull request #157 from NHSDigital/feature/sms-tests

chris-elliott-nhsd · web-flow · commit ab2791bf2972 · 2024-10-31T09:59:40.000Z
CCM-7099: Add SMS component tests
diff --git a/src/__tests__/app/email-template-submitted/__snapshots__/page.test.tsx.snap b/src/__tests__/app/email-template-submitted/__snapshots__/page.test.tsx.snap
@@ -64,6 +64,7 @@ exports[`EmailTemplateSubmitted 1`] = `
       <p>
         <a
           href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"
+          id="servicenow-link"
         >
           Raise a request with the service desk
         </a>
diff --git a/src/__tests__/app/nhs-app-template-submitted/__snapshots__/page.test.tsx.snap b/src/__tests__/app/nhs-app-template-submitted/__snapshots__/page.test.tsx.snap
@@ -64,6 +64,7 @@ exports[`NhsAppTemplateSubmittedPage 1`] = `
       <p>
         <a
           href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"
+          id="servicenow-link"
         >
           Raise a request with the service desk
         </a>
diff --git a/src/__tests__/app/text-message-template-submitted/__snapshots__/page.test.tsx.snap b/src/__tests__/app/text-message-template-submitted/__snapshots__/page.test.tsx.snap
@@ -64,6 +64,7 @@ exports[`SmsTemplateSubmitted 1`] = `
       <p>
         <a
           href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"
+          id="servicenow-link"
         >
           Raise a request with the service desk
         </a>
diff --git a/src/__tests__/components/forms/CreateSmsTemplate/__snapshots__/CreateSmsTemplate.test.tsx.snap b/src/__tests__/components/forms/CreateSmsTemplate/__snapshots__/CreateSmsTemplate.test.tsx.snap
@@ -155,6 +155,7 @@ exports[`CreateSmsTemplate component renders page 1`] = `
         >
           <p
             class="nhsuk-u-margin-bottom-0"
+            id="character-count"
           >
             0 characters
           </p>
@@ -508,6 +509,7 @@ exports[`CreateSmsTemplate component renders page one error 1`] = `
         >
           <p
             class="nhsuk-u-margin-bottom-0"
+            id="character-count"
           >
             0 characters
           </p>
@@ -875,6 +877,7 @@ exports[`CreateSmsTemplate component renders page with multiple errors 1`] = `
         >
           <p
             class="nhsuk-u-margin-bottom-0"
+            id="character-count"
           >
             0 characters
           </p>
@@ -1186,6 +1189,7 @@ exports[`CreateSmsTemplate component renders page with preloaded field values 1`
         >
           <p
             class="nhsuk-u-margin-bottom-0"
+            id="character-count"
           >
             16 characters
           </p>
diff --git a/src/app/preview-text-message-template/[sessionId]/page.tsx b/src/app/preview-text-message-template/[sessionId]/page.tsx
@@ -7,8 +7,8 @@ import { ReviewSMSTemplate } from '@forms/ReviewSMSTemplate';
 
 const isValid = (session?: Session) =>
   session?.templateType === TemplateType.SMS &&
-  session?.smsTemplateMessage !== undefined &&
-  session?.smsTemplateName !== undefined;
+  Boolean(session?.smsTemplateName) &&
+  Boolean(session?.smsTemplateMessage);
 
 const PreviewSMSTemplatePage = async ({ params: { sessionId } }: PageProps) => {
   const session = await getSession(sessionId);
diff --git a/src/app/submit-text-message-template/[sessionId]/page.tsx b/src/app/submit-text-message-template/[sessionId]/page.tsx
@@ -7,8 +7,8 @@ import { getSession } from '@utils/form-actions';
 
 const isValid = (session?: Session) =>
   session?.templateType === TemplateType.SMS &&
-  session?.smsTemplateMessage !== undefined &&
-  session?.smsTemplateName !== undefined;
+  Boolean(session?.smsTemplateName) &&
+  Boolean(session?.smsTemplateMessage);
 
 const SubmitSmsTemplatePage = async ({ params: { sessionId } }: PageProps) => {
   const session = await getSession(sessionId);
diff --git a/src/components/forms/CreateSmsTemplate/CreateSmsTemplate.tsx b/src/components/forms/CreateSmsTemplate/CreateSmsTemplate.tsx
@@ -77,7 +77,7 @@ export const CreateSmsTemplate: FC<PageComponentProps> = ({ initialState }) => {
             errorProps={{ id: 'smsTemplateMessage-error-message' }}
           />
           <div style={useJsEnabledStyle()} id='smsMessageCharacterCount'>
-            <p className='nhsuk-u-margin-bottom-0'>
+            <p className='nhsuk-u-margin-bottom-0' id='character-count'>
               {smsTemplateMessage.length} characters
             </p>
             <p>
diff --git a/src/components/molecules/TemplateSubmitted/TemplateSubmitted.tsx b/src/components/molecules/TemplateSubmitted/TemplateSubmitted.tsx
@@ -52,7 +52,10 @@ export const TemplateSubmitted = ({
         <p>{notLiveText}</p>
         <h3>{liveHeading}</h3>
         <p>
-          <Link href='https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5'>
+          <Link
+            id='servicenow-link'
+            href='https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5'
+          >
             {liveLinkText}
           </Link>{' '}
           {liveText}
diff --git a/tests/test-team/helpers/session-factory.ts b/tests/test-team/helpers/session-factory.ts
@@ -8,6 +8,13 @@ export const SessionFactory = {
     });
   },
 
+  createSmsSession: (id: string): Session => {
+    return SessionFactory.create({
+      id,
+      templateType: TemplateType.SMS,
+    });
+  },
+
   create: ({
     id,
     templateType,
diff --git a/tests/test-team/helpers/template-factory.ts b/tests/test-team/helpers/template-factory.ts
@@ -1,18 +1,11 @@
-import { Template, TemplateType } from './types';
+import { Template } from './types';
 
 type BaseTemplateFields = Omit<
   Template,
   'version' | '__typename' | 'createdAt' | 'updatedAt'
 >;
 
 export const TemplateFactory = {
-  createEmailTemplate: (props: Omit<BaseTemplateFields, 'type'>): Template => {
-    return TemplateFactory.create({
-      ...props,
-      type: TemplateType.EMAIL,
-    });
-  },
-
   create: (props: BaseTemplateFields): Template => {
     return {
       ...props,
diff --git a/tests/test-team/pages/sms/template-mgmt-create-sms-page.ts b/tests/test-team/pages/sms/template-mgmt-create-sms-page.ts
@@ -0,0 +1,43 @@
+import { Locator, Page } from '@playwright/test';
+import { TemplateMgmtBasePage } from '../template-mgmt-base-page';
+import { TemplateMgmtMessageFormatting } from '../template-mgmt-message-formatting';
+
+export class TemplateMgmtCreateSmsPage extends TemplateMgmtBasePage {
+  public readonly nameInput: Locator;
+
+  public readonly messageTextArea: Locator;
+
+  public readonly errorSummary: Locator;
+
+  public readonly personalisationFields: Locator;
+
+  public readonly namingYourTemplate: Locator;
+
+  public readonly pricingLink: Locator;
+
+  public readonly characterCountText: Locator;
+
+  public readonly messageFormatting: TemplateMgmtMessageFormatting;
+
+  constructor(page: Page) {
+    super(page);
+    this.nameInput = page.locator('[id="smsTemplateName"]');
+    this.messageTextArea = page.locator('[id="smsTemplateMessage"]');
+    this.errorSummary = page.locator('[class="nhsuk-error-summary"]');
+    this.personalisationFields = page.locator(
+      '[data-testid="personalisation-details"]'
+    );
+    this.namingYourTemplate = page.locator(
+      '[data-testid="how-to-name-your-template"]'
+    );
+    this.pricingLink = page.locator('[data-testid="sms-pricing-link"]');
+    this.characterCountText = page.locator('[id="character-count"]');
+    this.messageFormatting = new TemplateMgmtMessageFormatting(page);
+  }
+
+  async loadPage(sessionId: string) {
+    await this.navigateTo(
+      `/templates/create-text-message-template/${sessionId}`
+    );
+  }
+}
diff --git a/tests/test-team/pages/sms/template-mgmt-preview-sms-page.ts b/tests/test-team/pages/sms/template-mgmt-preview-sms-page.ts
@@ -0,0 +1,35 @@
+import { Locator, Page } from '@playwright/test';
+import { TemplateMgmtBasePage } from '../template-mgmt-base-page';
+
+export class TemplateMgmtPreviewSmsPage extends TemplateMgmtBasePage {
+  public readonly editRadioOption: Locator;
+
+  public readonly submitRadioOption: Locator;
+
+  public readonly errorSummary: Locator;
+
+  public readonly messageText: Locator;
+
+  public readonly whoYourSmsWillBeSentFrom: Locator;
+
+  constructor(page: Page) {
+    super(page);
+    this.editRadioOption = page.locator(
+      '[id="reviewSMSTemplateAction-sms-edit"]'
+    );
+    this.submitRadioOption = page.locator(
+      '[id="reviewSMSTemplateAction-sms-submit"]'
+    );
+    this.errorSummary = page.locator('[class="nhsuk-error-summary"]');
+    this.messageText = page.locator('[id="preview-content-message"]');
+    this.whoYourSmsWillBeSentFrom = page.locator(
+      '[data-testid="preview-message-details"]'
+    );
+  }
+
+  async loadPage(sessionId: string) {
+    await this.navigateTo(
+      `/templates/preview-text-message-template/${sessionId}`
+    );
+  }
+}
diff --git a/tests/test-team/pages/template-mgmt-submit-page.ts b/tests/test-team/pages/template-mgmt-submit-page.ts
@@ -1,18 +1,23 @@
 import { Locator, Page } from '@playwright/test';
-import { TemplateMgmtBasePage } from '../template-mgmt-base-page';
+import { TemplateMgmtBasePage } from './template-mgmt-base-page';
 
-export class TemplateMgmtSubmitEmailPage extends TemplateMgmtBasePage {
+export class TemplateMgmtSubmitPage extends TemplateMgmtBasePage {
   public readonly submitButton: Locator;
 
-  constructor(page: Page) {
+  constructor(
+    page: Page,
+    private readonly channelIdentifier: string
+  ) {
     super(page);
     this.submitButton = page
       .locator('[id="submit-template-button"]')
       .and(page.getByRole('button'));
   }
 
   async loadPage(sessionId: string) {
-    await this.navigateTo(`/templates/submit-email-template/${sessionId}`);
+    await this.navigateTo(
+      `/templates/submit-${this.channelIdentifier}-template/${sessionId}`
+    );
   }
 
   async clickSubmitTemplateButton() {
diff --git a/tests/test-team/pages/template-mgmt-template-submitted-page.ts b/tests/test-team/pages/template-mgmt-template-submitted-page.ts
@@ -8,20 +8,28 @@ export class TemplateMgmtTemplateSubmittedPage extends TemplateMgmtBasePage {
 
   public readonly createAnotherTemplateLink: Locator;
 
-  constructor(page: Page) {
+  public readonly serviceNowLink: Locator;
+
+  constructor(
+    page: Page,
+    private readonly channelIdentifier: string
+  ) {
     super(page);
     this.templateIdText = page.locator('[id="template-id"]');
     this.templateNameText = page.locator('[id="template-name"]');
     this.createAnotherTemplateLink = page.locator(
       '[id="create-another-template"]'
     );
+    this.serviceNowLink = page.locator('[id="servicenow-link"]');
   }
 
   async clickCreateAnotherTemplateLink() {
     await this.createAnotherTemplateLink.click();
   }
 
   async loadPage(templateId: string) {
-    await this.navigateTo(`/templates/email-template-submitted/${templateId}`);
+    await this.navigateTo(
+      `/templates/${this.channelIdentifier}-template-submitted/${templateId}`
+    );
   }
 }
diff --git a/tests/test-team/template-mgmt-component-tests/email/template-mgmt-create-email-page.component.ts b/tests/test-team/template-mgmt-component-tests/email/template-mgmt-create-email-page.component.ts
@@ -14,7 +14,7 @@ const sessions = {
   empty: SessionFactory.createEmailSession('empty-email-session'),
   submit: SessionFactory.createEmailSession('submit-email-session'),
   submitAndReturn: SessionFactory.createEmailSession(
-    'submit-and-return-session'
+    'submit-and-return-create-email-session'
   ),
   goBackAndReturn: SessionFactory.createEmailSession('go-back-email-session'),
   noEmailTemplateType: SessionFactory.create({
diff --git a/tests/test-team/template-mgmt-component-tests/email/template-mgmt-email-submitted-page.component.ts b/tests/test-team/template-mgmt-component-tests/email/template-mgmt-email-submitted-page.component.ts
diff --git a/tests/test-team/template-mgmt-component-tests/email/template-mgmt-submit-email-page.component.ts b/tests/test-team/template-mgmt-component-tests/email/template-mgmt-submit-email-page.component.ts
diff --git a/tests/test-team/template-mgmt-component-tests/sms/template-mgmt-create-sms-page.component.ts b/tests/test-team/template-mgmt-component-tests/sms/template-mgmt-create-sms-page.component.ts
diff --git a/tests/test-team/template-mgmt-component-tests/sms/template-mgmt-preview-sms-page.component.ts b/tests/test-team/template-mgmt-component-tests/sms/template-mgmt-preview-sms-page.component.ts
diff --git a/tests/test-team/template-mgmt-component-tests/template-mgmt-create-sms-template-page.component.ts b/tests/test-team/template-mgmt-component-tests/template-mgmt-create-sms-template-page.component.ts
diff --git a/tests/test-team/template-mgmt-component-tests/template-mgmt-submit-page.component.ts b/tests/test-team/template-mgmt-component-tests/template-mgmt-submit-page.component.ts
diff --git a/tests/test-team/template-mgmt-component-tests/template-mgmt-submitted-page.component.ts b/tests/test-team/template-mgmt-component-tests/template-mgmt-submitted-page.component.ts

Original file line number	Diff line number	Diff line change
@@ -64,6 +64,7 @@ exports[`EmailTemplateSubmitted 1`] = `
`64`	`64`	`<p>`
`65`	`65`	`<a`
`66`	`66`	`href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"`
	`67`	`+ id="servicenow-link"`
`67`	`68`	`>`
`68`	`69`	`Raise a request with the service desk`
`69`	`70`	`</a>`
Original file line number	Diff line number	Diff line change
@@ -64,6 +64,7 @@ exports[`NhsAppTemplateSubmittedPage 1`] = `
`64`	`64`	`<p>`
`65`	`65`	`<a`
`66`	`66`	`href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"`
	`67`	`+ id="servicenow-link"`
`67`	`68`	`>`
`68`	`69`	`Raise a request with the service desk`
`69`	`70`	`</a>`
Original file line number	Diff line number	Diff line change
@@ -64,6 +64,7 @@ exports[`SmsTemplateSubmitted 1`] = `
`64`	`64`	`<p>`
`65`	`65`	`<a`
`66`	`66`	`href="https://nhsdigitallive.service-now.com/nhs_digital?id=sc_cat_item&sys_id=6208dbce1be759102eee65b9bd4bcbf5"`
	`67`	`+ id="servicenow-link"`
`67`	`68`	`>`
`68`	`69`	`Raise a request with the service desk`
`69`	`70`	`</a>`
Original file line number	Diff line number	Diff line change
@@ -155,6 +155,7 @@ exports[`CreateSmsTemplate component renders page 1`] = `
`155`	`155`	`>`
`156`	`156`	`<p`
`157`	`157`	`class="nhsuk-u-margin-bottom-0"`
	`158`	`+ id="character-count"`
`158`	`159`	`>`
`159`	`160`	`0 characters`
`160`	`161`	`</p>`
@@ -508,6 +509,7 @@ exports[`CreateSmsTemplate component renders page one error 1`] = `
`508`	`509`	`>`
`509`	`510`	`<p`
`510`	`511`	`class="nhsuk-u-margin-bottom-0"`
	`512`	`+ id="character-count"`
`511`	`513`	`>`
`512`	`514`	`0 characters`
`513`	`515`	`</p>`
@@ -875,6 +877,7 @@ exports[`CreateSmsTemplate component renders page with multiple errors 1`] = `
`875`	`877`	`>`
`876`	`878`	`<p`
`877`	`879`	`class="nhsuk-u-margin-bottom-0"`
	`880`	`+ id="character-count"`
`878`	`881`	`>`
`879`	`882`	`0 characters`
`880`	`883`	`</p>`
@@ -1186,6 +1189,7 @@ exports[`CreateSmsTemplate component renders page with preloaded field values 1`
`1186`	`1189`	`>`
`1187`	`1190`	`<p`
`1188`	`1191`	`class="nhsuk-u-margin-bottom-0"`
	`1192`	`+ id="character-count"`
`1189`	`1193`	`>`
`1190`	`1194`	`16 characters`
`1191`	`1195`	`</p>`