CCM-11496: unit test

Author: harrim91

lambdas/backend-api/src/__tests__/domain/get-cascade-template-ids.test.ts

@@ -0,0 +1,89 @@
+import type { CascadeItem } from 'nhs-notify-backend-client';
+import { getCascadeTemplateIds } from '../../domain/get-cascade-template-ids';
+
+describe('getCascadeTemplateIds', () => {
+  it('should return empty array when cascade is empty', () => {
+    const cascade: CascadeItem[] = [];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual([]);
+  });
+
+  it('should return default template id when cascade item has only default template', () => {
+    const cascade: CascadeItem[] = [
+      {
+        defaultTemplateId: 'template-1',
+      } as CascadeItem,
+    ];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual(['template-1']);
+  });
+
+  it('should return conditional template ids when cascade item has conditional templates', () => {
+    const cascade: CascadeItem[] = [
+      {
+        conditionalTemplates: [
+          { templateId: 'template-1' },
+          { templateId: 'template-2' },
+        ],
+      } as CascadeItem,
+    ];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual(['template-1', 'template-2']);
+  });
+
+  it('should return both default and conditional template ids from multiple cascade items', () => {
+    const cascade: CascadeItem[] = [
+      {
+        defaultTemplateId: 'template-1',
+      } as CascadeItem,
+      {
+        conditionalTemplates: [
+          { templateId: 'template-2' },
+          { templateId: 'template-3' },
+        ],
+      } as CascadeItem,
+    ];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual(['template-1', 'template-2', 'template-3']);
+  });
+
+  it('should remove duplicate template ids', () => {
+    const cascade: CascadeItem[] = [
+      {
+        defaultTemplateId: 'template-1',
+      } as CascadeItem,
+      {
+        conditionalTemplates: [
+          { templateId: 'template-1' },
+          { templateId: 'template-2' },
+        ],
+      } as CascadeItem,
+    ];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual(['template-1', 'template-2']);
+  });
+
+  it('should filter out null default template ids', () => {
+    const cascade: CascadeItem[] = [
+      {
+        defaultTemplateId: null,
+      } as CascadeItem,
+      {
+        defaultTemplateId: 'template-1',
+      } as CascadeItem,
+    ];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual(['template-1']);
+  });
+
+  it('should handle cascade items with both conditional and default templates', () => {
+    const cascade: CascadeItem[] = [
+      {
+        defaultTemplateId: 'template-1',
+        conditionalTemplates: [{ templateId: 'template-2' }],
+      } as CascadeItem,
+    ];
+    const result = getCascadeTemplateIds(cascade);
+    expect(result).toEqual(['template-1', 'template-2']);
+  });
+});

lambdas/backend-api/src/domain/get-cascade-template-ids.ts

@@ -1,18 +1,24 @@
 import type { CascadeItem } from 'nhs-notify-backend-client';
 
 export function getCascadeTemplateIds(cascade: CascadeItem[]): string[] {
-  return cascade
-    .flatMap((cascadeItem) => {
-      if (cascadeItem.conditionalTemplates) {
-        return cascadeItem.conditionalTemplates.map(
-          (template) => template.templateId
-        );
+  const templateIds: string[] = [];
+
+  for (const item of cascade) {
+    // Add default template id if it exists and is not null
+    if (item.defaultTemplateId) {
+      templateIds.push(item.defaultTemplateId);
+    }
+
+    // Add conditional template ids if they exist
+    if (item.conditionalTemplates) {
+      for (const conditionalTemplate of item.conditionalTemplates) {
+        if (conditionalTemplate.templateId) {
+          templateIds.push(conditionalTemplate.templateId);
+        }
       }
+    }
+  }
 
-      return cascadeItem.defaultTemplateId;
-    })
-    .filter(
-      (templateId, i, list): templateId is string =>
-        typeof templateId === 'string' && list.indexOf(templateId) === i
-    );
+  // Remove duplicates and return
+  return [...new Set(templateIds)];
 }