CCM-8962: add submit and delete routes

Author: bhansell1

.gitignore

@@ -61,6 +61,7 @@ reports
 tests/screenshots/*
 plugin-cache/
 
+# terraform
 *.terraform*
 terraform.tfstate
 terraform.tfstate.backup
@@ -84,3 +85,6 @@ tests/test-team/playwright-report/
 tests/test-team/blob-report/
 tests/test-team/playwright/.cache/
 lambdas/backend-api/src/email/email-template.json
+
+# vscode
+.vscode/settings.local.json

.vscode/settings.json

@@ -1,11 +1,15 @@
 {
   "markdownlint.config": {
     "MD013": false,
-    "MD024": { "siblings_only": true },
+    "MD024": {
+      "siblings_only": true
+    },
     "MD033": false
   },
   "editor.codeActionsOnSave": {
     "source.fixAll.eslint": "explicit"
   },
-  "eslint.codeActionsOnSave.mode": "problems"
-}
+  "eslint.codeActionsOnSave.mode": "problems",
+  "jestrunner.jestPath": "/Users/benjamin.hansell/projects/nhs-notify-web-template-management/node_modules/jest/bin/jest.js",
+  "jestrunner.projectPath": "/Users/benjamin.hansell/projects/nhs-notify-web-template-management/frontend"
+}

frontend/src/__tests__/components/forms/DeleteTemplate/server-action.test.ts

@@ -4,7 +4,7 @@ import {
   deleteTemplateNoAction,
 } from '@forms/DeleteTemplate/server-action';
 import { NHSAppTemplate } from 'nhs-notify-web-template-management-utils';
-import { saveTemplate } from '@utils/form-actions';
+import { setTemplateToDeleted } from '@utils/form-actions';
 
 jest.mock('next/navigation');
 jest.mock('@utils/form-actions');
@@ -27,7 +27,7 @@ test('redirects', async () => {
 
 test('calls form action and redirects', async () => {
   const mockRedirect = jest.mocked(redirect);
-  const mockSaveTemplate = jest.mocked(saveTemplate);
+  const mockSetTemplateToDeleted = jest.mocked(setTemplateToDeleted);
 
   const mockTemplate: NHSAppTemplate = {
     id: 'template-id',
@@ -41,10 +41,7 @@ test('calls form action and redirects', async () => {
 
   await deleteTemplateYesAction(mockTemplate);
 
-  expect(mockSaveTemplate).toHaveBeenCalledWith({
-    ...mockTemplate,
-    templateStatus: 'DELETED',
-  });
+  expect(mockSetTemplateToDeleted).toHaveBeenCalledWith('template-id');
 
   expect(mockRedirect).toHaveBeenCalledWith(
     '/manage-templates',

frontend/src/__tests__/components/forms/SubmitTemplate/server-action.test.ts

@@ -4,7 +4,7 @@
 import { submitTemplate } from '@forms/SubmitTemplate/server-action';
 import { getMockFormData } from '@testhelpers';
 import { redirect } from 'next/navigation';
-import { getTemplate, saveTemplate } from '@utils/form-actions';
+import { getTemplate, setTemplateToSubmitted } from '@utils/form-actions';
 import { TemplateDto } from 'nhs-notify-backend-client';
 
 jest.mock('next/navigation');
@@ -13,7 +13,7 @@ jest.mock('@utils/amplify-utils');
 
 const redirectMock = jest.mocked(redirect);
 const getTemplateMock = jest.mocked(getTemplate);
-const saveTemplateMock = jest.mocked(saveTemplate);
+const setTemplateToSubmittedMock = jest.mocked(setTemplateToSubmitted);
 
 const mockNhsAppTemplate = {
   templateType: 'NHS_APP',
@@ -63,7 +63,7 @@ describe('submitTemplate', () => {
   it('should handle error when failing to save template', async () => {
     getTemplateMock.mockResolvedValueOnce(mockNhsAppTemplate);
 
-    saveTemplateMock.mockImplementationOnce(() => {
+    setTemplateToSubmittedMock.mockImplementationOnce(() => {
       throw new Error('failed to save template');
     });
 
@@ -85,17 +85,8 @@ describe('submitTemplate', () => {
 
     await submitTemplate('submit-route', formData);
 
-    expect(saveTemplateMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        createdAt: '2025-01-13T10:19:25.579Z',
-        id: '1',
-        message: 'body',
-        name: 'name',
-        templateStatus: 'SUBMITTED',
-        templateType: 'NHS_APP',
-        updatedAt: '2025-01-13T10:19:25.579Z',
-      })
-    );
+    expect(setTemplateToSubmittedMock).toHaveBeenCalledWith('1');
+
     expect(redirectMock).toHaveBeenCalledWith('/submit-route/1', 'push');
   });
 });

frontend/src/__tests__/utils/form-actions.test.ts

@@ -12,6 +12,8 @@ import {
   getTemplate,
   getTemplates,
   createLetterTemplate,
+  setTemplateToDeleted,
+  setTemplateToSubmitted,
 } from '@utils/form-actions';
 import { getAccessTokenServer } from '@utils/amplify-utils';
 import { TemplateDto } from 'nhs-notify-backend-client';
@@ -283,7 +285,7 @@ describe('form-actions', () => {
     });
 
     const updateTemplateInput: NHSAppTemplate = {
-      id: 'pickle',
+      id: 'id',
       templateType: 'NHS_APP',
       templateStatus: 'NOT_YET_SUBMITTED',
       name: 'name',
@@ -312,7 +314,7 @@ describe('form-actions', () => {
     });
 
     const updateTemplateInput: NHSAppTemplate = {
-      id: 'pickle',
+      id: 'id',
       templateType: 'NHS_APP',
       templateStatus: 'NOT_YET_SUBMITTED',
       name: 'name',
@@ -337,7 +339,7 @@ describe('form-actions', () => {
     authIdTokenServerMock.mockResolvedValueOnce(undefined);
 
     const updateTemplateInput: NHSAppTemplate = {
-      id: 'pickle',
+      id: 'id',
       templateType: 'NHS_APP',
       templateStatus: 'NOT_YET_SUBMITTED',
       name: 'name',
@@ -483,4 +485,102 @@ describe('form-actions', () => {
 
     expect(actualOrder).toEqual(expectedOrder);
   });
+
+  describe('setTemplateToSubmitted', () => {
+    test('submitTemplate successfully', async () => {
+      const responseData = {
+        id: 'id',
+        templateType: 'NHS_APP',
+        templateStatus: 'NOT_YET_SUBMITTED',
+        name: 'name',
+        message: 'message',
+        createdAt: '2025-01-13T10:19:25.579Z',
+        updatedAt: '2025-01-13T10:19:25.579Z',
+      } satisfies TemplateDto;
+
+      mockedTemplateClient.submitTemplate.mockResolvedValueOnce({
+        data: responseData,
+      });
+
+      const response = await setTemplateToSubmitted('id');
+
+      expect(mockedTemplateClient.submitTemplate).toHaveBeenCalledWith(
+        'id',
+        'token'
+      );
+
+      expect(response).toEqual(responseData);
+    });
+
+    test('submitTemplate - should thrown error when saving unexpectedly fails', async () => {
+      mockedTemplateClient.submitTemplate.mockResolvedValueOnce({
+        error: {
+          code: 400,
+          message: 'Bad request',
+        },
+      });
+
+      await expect(setTemplateToSubmitted('id')).rejects.toThrow(
+        'Failed to save template data'
+      );
+
+      expect(mockedTemplateClient.submitTemplate).toHaveBeenCalledWith(
+        'id',
+        'token'
+      );
+    });
+
+    test('submitTemplate - should thrown error when no token', async () => {
+      authIdTokenServerMock.mockReset();
+      authIdTokenServerMock.mockResolvedValueOnce(undefined);
+
+      await expect(setTemplateToSubmitted('id')).rejects.toThrow(
+        'Failed to get access token'
+      );
+    });
+  });
+
+  describe('setTemplateToDeleted', () => {
+    test('deleteTemplate successfully', async () => {
+      mockedTemplateClient.deleteTemplate.mockResolvedValueOnce({
+        data: undefined,
+      });
+
+      const response = await setTemplateToDeleted('id');
+
+      expect(mockedTemplateClient.deleteTemplate).toHaveBeenCalledWith(
+        'id',
+        'token'
+      );
+
+      expect(response).toEqual(undefined);
+    });
+
+    test('deleteTemplate - should thrown error when saving unexpectedly fails', async () => {
+      mockedTemplateClient.deleteTemplate.mockResolvedValueOnce({
+        error: {
+          code: 400,
+          message: 'Bad request',
+        },
+      });
+
+      await expect(setTemplateToDeleted('id')).rejects.toThrow(
+        'Failed to save template data'
+      );
+
+      expect(mockedTemplateClient.deleteTemplate).toHaveBeenCalledWith(
+        'id',
+        'token'
+      );
+    });
+
+    test('deleteTemplate - should thrown error when no token', async () => {
+      authIdTokenServerMock.mockReset();
+      authIdTokenServerMock.mockResolvedValueOnce(undefined);
+
+      await expect(setTemplateToDeleted('id')).rejects.toThrow(
+        'Failed to get access token'
+      );
+    });
+  });
 });

frontend/src/components/forms/DeleteTemplate/server-action.ts

@@ -1,5 +1,5 @@
 import { redirect, RedirectType } from 'next/navigation';
-import { saveTemplate } from '@utils/form-actions';
+import { setTemplateToDeleted } from '@utils/form-actions';
 import { TemplateDto } from 'nhs-notify-backend-client';
 
 export const deleteTemplateNoAction = async () => {
@@ -9,10 +9,7 @@ export const deleteTemplateNoAction = async () => {
 export const deleteTemplateYesAction = async (
   template: TemplateDto
 ): Promise<never> => {
-  await saveTemplate({
-    ...template,
-    templateStatus: 'DELETED',
-  });
+  await setTemplateToDeleted(template.id);
 
   redirect('/manage-templates', RedirectType.push);
 };

frontend/src/components/forms/SubmitTemplate/server-action.ts

@@ -1,7 +1,7 @@
 'use server';
 
 import { redirect, RedirectType } from 'next/navigation';
-import { getTemplate, saveTemplate } from '@utils/form-actions';
+import { getTemplate, setTemplateToSubmitted } from '@utils/form-actions';
 import { z } from 'zod';
 import { validateTemplate } from 'nhs-notify-web-template-management-utils';
 import { logger } from 'nhs-notify-web-template-management-utils/logger';
@@ -26,10 +26,7 @@ export async function submitTemplate(route: string, formData: FormData) {
   }
 
   try {
-    await saveTemplate({
-      ...validatedTemplate,
-      templateStatus: 'SUBMITTED',
-    });
+    await setTemplateToSubmitted(templateId);
   } catch (error) {
     logger.error('Failed to submit template', {
       error,

frontend/src/utils/form-actions.ts

@@ -78,6 +78,43 @@ export async function saveTemplate(
   return data;
 }
 
+export async function setTemplateToSubmitted(
+  templateId: string
+): Promise<TemplateDto> {
+  const token = await getAccessTokenServer();
+
+  if (!token) {
+    throw new Error('Failed to get access token');
+  }
+
+  const { data, error } = await templateClient.submitTemplate(
+    templateId,
+    token
+  );
+
+  if (error) {
+    logger.error('Failed to save template', { error });
+    throw new Error('Failed to save template data');
+  }
+
+  return data;
+}
+
+export async function setTemplateToDeleted(templateId: string): Promise<void> {
+  const token = await getAccessTokenServer();
+
+  if (!token) {
+    throw new Error('Failed to get access token');
+  }
+
+  const { error } = await templateClient.deleteTemplate(templateId, token);
+
+  if (error) {
+    logger.error('Failed to save template', { error });
+    throw new Error('Failed to save template data');
+  }
+}
+
 export async function getTemplate(
   templateId: string
 ): Promise<TemplateDto | undefined> {

infrastructure/terraform/modules/backend-api/iam_role_api_gateway_execution_role.tf

@@ -52,6 +52,8 @@ data "aws_iam_policy_document" "api_gateway_execution_policy" {
       module.create_template_lambda.function_arn,
       module.create_letter_template_lambda.function_arn,
       module.update_template_lambda.function_arn,
+      module.submit_template_lambda.function_arn,
+      module.delete_template_lambda.function_arn,
       module.get_template_lambda.function_arn,
       module.list_template_lambda.function_arn
     ]

infrastructure/terraform/modules/backend-api/locals.tf

@@ -10,6 +10,8 @@ locals {
     CREATE_LAMBDA_ARN        = module.create_template_lambda.function_arn
     CREATE_LETTER_LAMBDA_ARN = module.create_letter_template_lambda.function_arn
     UPDATE_LAMBDA_ARN        = module.update_template_lambda.function_arn
+    SUBMIT_LAMBDA_ARN        = module.submit_template_lambda.function_arn
+    DELETE_LAMBDA_ARN        = module.delete_template_lambda.function_arn
     GET_LAMBDA_ARN           = module.get_template_lambda.function_arn
     LIST_LAMBDA_ARN          = module.list_template_lambda.function_arn
   })
@@ -19,6 +21,8 @@ locals {
     create_letter_template = "src/templates/create-letter.ts"
     get_template           = "src/templates/get.ts"
     update_template        = "src/templates/update.ts"
+    submit_template        = "src/templates/submit.ts"
+    delete_template        = "src/templates/delete.ts"
     list_template          = "src/templates/list.ts"
     template_client        = "src/index.ts"
   }