Skip to content

Commit b35f39d

Browse files
chris-elliott-nhsdchris-elliott-nhsd
committed
CCM-7940: Fix e2e tests
1 parent 4886e1f commit b35f39d

File tree

6 files changed

+46
-51
lines changed

6 files changed

+46
-51
lines changed

‎lambdas/backend-api/build.sh‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ npx esbuild \
1313
--loader:.node=file \
1414
--entry-names=[name]/[name] \
1515
--outdir=dist \
16+
--external:pdfjs-dist \
1617
src/templates/copy-scanned-object-to-internal.ts \
1718
src/templates/create-letter.ts \
1819
src/templates/create.ts \

‎lambdas/backend-api/src/__tests__/templates/api/create.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe('Template API - Create', () => {
4444
code: 400,
4545
message: 'Validation failed',
4646
details: {
47-
templateType: 'Required',
47+
templateType: 'Invalid input: expected string, received undefined',
4848
},
4949
},
5050
data: undefined,
@@ -65,7 +65,7 @@ describe('Template API - Create', () => {
6565
statusCode: 400,
6666
technicalMessage: 'Validation failed',
6767
details: {
68-
templateType: 'Required',
68+
templateType: 'Invalid input: expected string, received undefined',
6969
},
7070
}),
7171
});

‎lambdas/backend-api/src/__tests__/templates/api/update.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe('Template API - Update', () => {
4545
code: 400,
4646
message: 'Validation failed',
4747
details: {
48-
templateType: 'Required',
48+
templateType: 'Invalid input: expected string, received undefined',
4949
},
5050
},
5151
data: undefined,
@@ -67,7 +67,7 @@ describe('Template API - Update', () => {
6767
statusCode: 400,
6868
technicalMessage: 'Validation failed',
6969
details: {
70-
templateType: 'Required',
70+
templateType: 'Invalid input: expected string, received undefined',
7171
},
7272
}),
7373
});

‎tests/test-team/template-mgmt-api-tests/create-letter-template.api.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ test.describe('POST /v1/letter-template', () => {
420420
statusCode: 400,
421421
technicalMessage: 'Request failed validation',
422422
details: {
423-
name: 'Required',
423+
name: 'Invalid input: expected string, received undefined',
424424
},
425425
});
426426
});

‎tests/test-team/template-mgmt-api-tests/create-template.api.spec.ts‎

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ test.describe('POST /v1/template', () => {
5353
statusCode: 400,
5454
technicalMessage: 'Request failed validation',
5555
details: {
56-
templateType:
57-
"Invalid discriminator value. Expected 'NHS_APP' | 'EMAIL' | 'SMS'",
56+
templateType: 'Invalid input',
5857
},
5958
});
6059
});
@@ -80,8 +79,7 @@ test.describe('POST /v1/template', () => {
8079
statusCode: 400,
8180
technicalMessage: 'Request failed validation',
8281
details: {
83-
templateType:
84-
"Invalid discriminator value. Expected 'NHS_APP' | 'EMAIL' | 'SMS'",
82+
templateType: 'Invalid input',
8583
},
8684
});
8785
});
@@ -107,8 +105,7 @@ test.describe('POST /v1/template', () => {
107105
statusCode: 400,
108106
technicalMessage: 'Request failed validation',
109107
details: {
110-
templateType:
111-
"Invalid discriminator value. Expected 'NHS_APP' | 'EMAIL' | 'SMS'",
108+
templateType: 'Invalid input',
112109
},
113110
});
114111
});
@@ -259,7 +256,7 @@ test.describe('POST /v1/template', () => {
259256
statusCode: 400,
260257
technicalMessage: 'Request failed validation',
261258
details: {
262-
name: 'Required',
259+
name: 'Invalid input: expected string, received undefined',
263260
},
264261
});
265262
});
@@ -284,7 +281,7 @@ test.describe('POST /v1/template', () => {
284281
statusCode: 400,
285282
technicalMessage: 'Request failed validation',
286283
details: {
287-
name: 'String must contain at least 1 character(s)',
284+
name: 'Too small: expected string to have >=1 characters',
288285
},
289286
});
290287
});
@@ -311,7 +308,7 @@ test.describe('POST /v1/template', () => {
311308
statusCode: 400,
312309
technicalMessage: 'Request failed validation',
313310
details: {
314-
message: 'Required',
311+
message: 'Invalid input: expected string, received undefined',
315312
},
316313
});
317314
});
@@ -336,7 +333,7 @@ test.describe('POST /v1/template', () => {
336333
statusCode: 400,
337334
technicalMessage: 'Request failed validation',
338335
details: {
339-
message: 'String must contain at least 1 character(s)',
336+
message: 'Too small: expected string to have >=1 characters',
340337
},
341338
});
342339
});
@@ -363,7 +360,7 @@ test.describe('POST /v1/template', () => {
363360
statusCode: 400,
364361
technicalMessage: 'Request failed validation',
365362
details: {
366-
message: 'String must contain at most 5000 character(s)',
363+
message: 'Too big: expected string to have <=5000 characters',
367364
},
368365
});
369366
});
@@ -495,7 +492,7 @@ test.describe('POST /v1/template', () => {
495492
statusCode: 400,
496493
technicalMessage: 'Request failed validation',
497494
details: {
498-
name: 'Required',
495+
name: 'Invalid input: expected string, received undefined',
499496
},
500497
});
501498
});
@@ -520,7 +517,7 @@ test.describe('POST /v1/template', () => {
520517
statusCode: 400,
521518
technicalMessage: 'Request failed validation',
522519
details: {
523-
name: 'String must contain at least 1 character(s)',
520+
name: 'Too small: expected string to have >=1 characters',
524521
},
525522
});
526523
});
@@ -547,7 +544,7 @@ test.describe('POST /v1/template', () => {
547544
statusCode: 400,
548545
technicalMessage: 'Request failed validation',
549546
details: {
550-
message: 'Required',
547+
message: 'Invalid input: expected string, received undefined',
551548
},
552549
});
553550
});
@@ -572,7 +569,7 @@ test.describe('POST /v1/template', () => {
572569
statusCode: 400,
573570
technicalMessage: 'Request failed validation',
574571
details: {
575-
message: 'String must contain at least 1 character(s)',
572+
message: 'Too small: expected string to have >=1 characters',
576573
},
577574
});
578575
});
@@ -599,7 +596,7 @@ test.describe('POST /v1/template', () => {
599596
statusCode: 400,
600597
technicalMessage: 'Request failed validation',
601598
details: {
602-
message: 'String must contain at most 918 character(s)',
599+
message: 'Too big: expected string to have <=918 characters',
603600
},
604601
});
605602
});
@@ -704,7 +701,7 @@ test.describe('POST /v1/template', () => {
704701
statusCode: 400,
705702
technicalMessage: 'Request failed validation',
706703
details: {
707-
name: 'Required',
704+
name: 'Invalid input: expected string, received undefined',
708705
},
709706
});
710707
});
@@ -729,7 +726,7 @@ test.describe('POST /v1/template', () => {
729726
statusCode: 400,
730727
technicalMessage: 'Request failed validation',
731728
details: {
732-
name: 'String must contain at least 1 character(s)',
729+
name: 'Too small: expected string to have >=1 characters',
733730
},
734731
});
735732
});
@@ -756,7 +753,7 @@ test.describe('POST /v1/template', () => {
756753
statusCode: 400,
757754
technicalMessage: 'Request failed validation',
758755
details: {
759-
subject: 'Required',
756+
subject: 'Invalid input: expected string, received undefined',
760757
},
761758
});
762759
});
@@ -781,7 +778,7 @@ test.describe('POST /v1/template', () => {
781778
statusCode: 400,
782779
technicalMessage: 'Request failed validation',
783780
details: {
784-
subject: 'String must contain at least 1 character(s)',
781+
subject: 'Too small: expected string to have >=1 characters',
785782
},
786783
});
787784
});
@@ -808,7 +805,7 @@ test.describe('POST /v1/template', () => {
808805
statusCode: 400,
809806
technicalMessage: 'Request failed validation',
810807
details: {
811-
message: 'Required',
808+
message: 'Invalid input: expected string, received undefined',
812809
},
813810
});
814811
});
@@ -833,7 +830,7 @@ test.describe('POST /v1/template', () => {
833830
statusCode: 400,
834831
technicalMessage: 'Request failed validation',
835832
details: {
836-
message: 'String must contain at least 1 character(s)',
833+
message: 'Too small: expected string to have >=1 characters',
837834
},
838835
});
839836
});
@@ -860,7 +857,7 @@ test.describe('POST /v1/template', () => {
860857
statusCode: 400,
861858
technicalMessage: 'Request failed validation',
862859
details: {
863-
message: 'String must contain at most 100000 character(s)',
860+
message: 'Too big: expected string to have <=100000 characters',
864861
},
865862
});
866863
});

0 commit comments

Comments
 (0)