CCM-11496: fixes

Author: harrim91

frontend/src/app/message-plans/move-to-production/[routingConfigId]/__snapshots__/page.test.tsx.snap

@@ -54,15 +54,15 @@ exports[`matches snapshot 1`] = `
           Moving message plans from draft to production means that they are ready to send.
         </p>
         <p>
-          Messages will only be sent to recipients when you make a request with
+          Messages will only be sent to recipients when you make a request with 
           <a
             href="https://digital.nhs.uk/developer/api-catalogue/nhs-notify"
             rel="noopener noreferrer"
             target="_blank"
           >
             NHS Notify API
           </a>
-           or
+           or 
           <a
             href="https://digital.nhs.uk/developer/api-catalogue/nhs-notify-mesh"
             rel="noopener noreferrer"

frontend/src/utils/form-actions.ts

@@ -219,8 +219,6 @@ export async function createRoutingConfig(
 export async function submitRoutingConfig(id: string) {
   const { accessToken } = await getSessionServer();
 
-  console.log({ accessToken });
-
   if (!accessToken) {
     throw new Error('Failed to get access token');
   }

lambdas/backend-client/src/routing-config-api-client.ts

@@ -167,7 +167,7 @@ export const routingConfigurationApiClient = {
     }
 
     const url =
-      `/v1/routing-configuration/${id}/submit` satisfies OpenApiToTemplate<
+      `/v1/routing-configuration/${parseResult.data}/submit` satisfies OpenApiToTemplate<
         PatchV1RoutingConfigurationByRoutingConfigIdSubmitData['url']
       >;
 

scripts/config/pre-commit.yaml

@@ -5,7 +5,7 @@ repos:
       - id: trailing-whitespace
         exclude: |
           (?x)^(
-            frontend/src/__tests__/.*\.tsx\.snap |
+            frontend/src/.*\.tsx\.snap |
             frontend/src/__tests__/utils/markdownit/fixtures/index\.ts
           )$
       - id: detect-aws-credentials

tests/test-team/template-mgmt-routing-component-tests/move-to-production-page.routing-component.spec.ts

@@ -12,6 +12,7 @@ import {
   assertSignOutLink,
   assertSkipToMainContent,
 } from 'helpers/template-mgmt-common.steps';
+import { RoutingMessagePlansPage } from 'pages/routing/message-plans-page';
 import { RoutingMoveToProductionPage } from 'pages/routing/move-to-production-page';
 
 const storageHelper = new RoutingConfigStorageHelper();
@@ -53,7 +54,7 @@ test.describe('Create Message Plan Page', () => {
     const routingConfig =
       RoutingConfigFactory.create(user).withTemplates('NHSAPP');
 
-    storageHelper.seed([routingConfig.dbEntry]);
+    await storageHelper.seed([routingConfig.dbEntry]);
 
     const moveToProductionPage = new RoutingMoveToProductionPage(page);
 
@@ -66,7 +67,21 @@ test.describe('Create Message Plan Page', () => {
     await moveToProductionPage.submitButton.click();
 
     await expect(page).toHaveURL(`${baseURL}/templates/message-plans`);
-    // TODO: CCM-11496 - assert status
+
+    const messagePlansPage = new RoutingMessagePlansPage(page);
+
+    await messagePlansPage.productionMessagePlansTable.click();
+
+    const productionIdCells =
+      messagePlansPage.productionMessagePlansTable.getByTestId(
+        'message-plan-id-cell'
+      );
+
+    const productionCellsText = await productionIdCells.allTextContents();
+
+    expect(productionCellsText).toContainEqual(
+      expect.stringContaining(routingConfig.dbEntry.id)
+    );
   });
 
   test('links to preview page for the message plan', async ({
@@ -76,7 +91,7 @@ test.describe('Create Message Plan Page', () => {
     const routingConfig =
       RoutingConfigFactory.create(user).withTemplates('NHSAPP');
 
-    storageHelper.seed([routingConfig.dbEntry]);
+    await storageHelper.seed([routingConfig.dbEntry]);
 
     const moveToProductionPage = new RoutingMoveToProductionPage(page);
 
@@ -93,14 +108,14 @@ test.describe('Create Message Plan Page', () => {
     );
   });
 
-  test('cancel button links to the message plan list page', async ({
+  test('cancel button links to the message plan list page, does not move the plan to production', async ({
     baseURL,
     page,
   }) => {
     const routingConfig =
       RoutingConfigFactory.create(user).withTemplates('NHSAPP');
 
-    storageHelper.seed([routingConfig.dbEntry]);
+    await storageHelper.seed([routingConfig.dbEntry]);
 
     const moveToProductionPage = new RoutingMoveToProductionPage(page);
 
@@ -113,5 +128,19 @@ test.describe('Create Message Plan Page', () => {
     await moveToProductionPage.cancelLink.click();
 
     await expect(page).toHaveURL(`${baseURL}/templates/message-plans`);
+
+    const messagePlansPage = new RoutingMessagePlansPage(page);
+
+    await messagePlansPage.draftMessagePlansTable.click();
+
+    const draftIdCells = messagePlansPage.draftMessagePlansTable.getByTestId(
+      'message-plan-id-cell'
+    );
+
+    const draftCellsText = await draftIdCells.allTextContents();
+
+    expect(draftCellsText).toContainEqual(
+      expect.stringContaining(routingConfig.dbEntry.id)
+    );
   });
 });