CCM-8572: PR feedback

Author: harrim91

infrastructure/terraform/components/sandbox/README.md

@@ -30,6 +30,8 @@ No requirements.
 | <a name="output_api_base_url"></a> [api\_base\_url](#output\_api\_base\_url) | n/a |
 | <a name="output_cognito_user_pool_client_id"></a> [cognito\_user\_pool\_client\_id](#output\_cognito\_user\_pool\_client\_id) | n/a |
 | <a name="output_cognito_user_pool_id"></a> [cognito\_user\_pool\_id](#output\_cognito\_user\_pool\_id) | n/a |
+| <a name="output_internal_bucket_name"></a> [internal\_bucket\_name](#output\_internal\_bucket\_name) | n/a |
+| <a name="output_quarantine_bucket_name"></a> [quarantine\_bucket\_name](#output\_quarantine\_bucket\_name) | n/a |
 | <a name="output_templates_table_name"></a> [templates\_table\_name](#output\_templates\_table\_name) | n/a |
 <!-- vale on -->
 <!-- markdownlint-enable -->

infrastructure/terraform/modules/backend-api/README.md

@@ -51,6 +51,8 @@ No requirements.
 | Name | Description |
 |------|-------------|
 | <a name="output_api_base_url"></a> [api\_base\_url](#output\_api\_base\_url) | n/a |
+| <a name="output_internal_bucket_name"></a> [internal\_bucket\_name](#output\_internal\_bucket\_name) | n/a |
+| <a name="output_quarantine_bucket_name"></a> [quarantine\_bucket\_name](#output\_quarantine\_bucket\_name) | n/a |
 | <a name="output_templates_table_name"></a> [templates\_table\_name](#output\_templates\_table\_name) | n/a |
 <!-- vale on -->
 <!-- markdownlint-enable -->

infrastructure/terraform/modules/backend-api/cloudwatch_event_rule_quarantine_tags_added.tf

@@ -9,6 +9,12 @@ resource "aws_cloudwatch_event_rule" "quarantine_tags_added" {
       bucket = {
         name = [module.s3bucket_quarantine.id]
       }
+      object = {
+        key = [
+          { prefix = "pdf-template/" },
+          { prefix = "test-data/" },
+        ]
+      }
     }
   })
 }

infrastructure/terraform/modules/backend-api/cloudwatch_event_rule_virus_scan_failed.tf

@@ -11,7 +11,7 @@ resource "aws_cloudwatch_event_rule" "virus_scan_failed" {
       }
       object = {
         tags = {
-          GuardDutyMalwareScanStatus = ["THREATS_FOUND", "UNSUPPORTED", "ACCESS_DENIED", "FAILED"]
+          GuardDutyMalwareScanStatus = [{ anything-but = "NO_THREATS_FOUND" }]
         }
       }
     }

lambdas/backend-api/src/templates/infra/template-repository.ts

@@ -260,7 +260,7 @@ export class TemplateRepository {
       updates.push('#templateStatus = :templateStatusFailed');
       ExpressionAttributeNames['#templateStatus'] = 'templateStatus';
       ExpressionAttributeValues[':templateStatusFailed'] =
-        'VIRUS_SCAN_FAILED' as TemplateStatus;
+        'VIRUS_SCAN_FAILED' satisfies TemplateStatus;
     }
 
     try {