cleanup

Author: alexnuttall

frontend/src/__tests__/components/molecules/PreviewTemplateDetails.test.tsx

@@ -203,16 +203,10 @@ describe('PreviewTemplateDetailsLetter', () => {
   });
 
   it('If the template is client-owned, the clientId is used to construct download link', () => {
-    const container = render(
+    const { getByTestId } = render(
       <PreviewTemplateDetailsLetter
         template={{
-          id: 'template-id',
-          owner: 'CLIENT#client',
-          name: 'Example letter',
-          templateStatus: 'PROOF_AVAILABLE',
-          templateType: 'LETTER',
-          letterType: 'x0',
-          language: 'en',
+          createdAt: '2025-01-13T10:19:25.579Z',
           files: {
             pdfTemplate: {
               fileName: 'file.pdf',
@@ -227,12 +221,22 @@ describe('PreviewTemplateDetailsLetter', () => {
               },
             },
           },
-          createdAt: '2025-01-13T10:19:25.579Z',
+          id: 'template-id',
+          language: 'en',
+          letterType: 'x0',
+          name: 'Example letter',
+          owner: 'CLIENT#client',
+          templateStatus: 'PROOF_AVAILABLE',
+          templateType: 'LETTER',
           updatedAt: '2025-01-13T10:19:25.579Z',
         }}
       />
     );
 
-    expect(container.asFragment()).toMatchSnapshot();
+    const link = getByTestId('proof-link_a.pdf');
+    expect(link).toHaveAttribute(
+      'href',
+      '/templates/files/client/proofs/template-id/a.pdf'
+    );
   });
 });

frontend/src/__tests__/components/molecules/__snapshots__/PreviewTemplateDetails.test.tsx.snap

@@ -119,158 +119,6 @@ exports[`PreviewTemplateDetailsEmail matches snapshot 1`] = `
 </DocumentFragment>
 `;
 
-exports[`PreviewTemplateDetailsLetter If the template is client-owned, the clientId is used to construct download link 1`] = `
-<DocumentFragment>
-  <h1
-    class="preview__heading"
-    data-testid="preview-message__heading"
-  >
-    Example letter
-  </h1>
-  <div
-    class="nhsuk-width-container nhsuk-u-margin-bottom-6 nhsuk-body-m"
-  >
-    <dl
-      class="nhsuk-summary-list nhsuk-u-margin-bottom-4 preview"
-    >
-      <div
-        class="nhsuk-summary-list__row"
-      >
-        <dt
-          class="nhsuk-summary-list__key"
-        >
-          Template ID
-        </dt>
-        <dd
-          class="nhsuk-summary-list__value"
-        >
-          template-id
-        </dd>
-      </div>
-      <div
-        class="nhsuk-summary-list__row"
-      >
-        <dt
-          class="nhsuk-summary-list__key"
-        >
-          Type
-        </dt>
-        <dd
-          class="nhsuk-summary-list__value"
-        >
-          Standard letter
-        </dd>
-      </div>
-      <div
-        class="nhsuk-summary-list__row"
-      >
-        <dt
-          class="nhsuk-summary-list__key"
-        >
-          Status
-        </dt>
-        <dd
-          class="nhsuk-summary-list__value"
-        >
-          <strong
-            class="nhsuk-tag nhsuk-tag--orange"
-          >
-            Proof available
-          </strong>
-        </dd>
-      </div>
-      <div
-        class="nhsuk-summary-list__row"
-      >
-        <dt
-          class="nhsuk-summary-list__key"
-        >
-          Template file
-        </dt>
-        <dd
-          class="nhsuk-summary-list__value"
-        >
-          <div
-            class="container"
-          >
-            <svg
-              class="icon"
-              fill="none"
-              height="26"
-              viewBox="0 0 20 26"
-              width="20"
-              xmlns="http://www.w3.org/2000/svg"
-            >
-              <path
-                d="M0 0V26H20V6.59375L19.7188 6.28125L13.7188 0.28125L13.4062 0H0ZM2 2H12V8H18V24H2V2ZM14 3.4375L16.5625 6H14V3.4375Z"
-                fill="#4C6272"
-              />
-            </svg>
-            <p
-              class="text"
-            >
-              file.pdf
-            </p>
-          </div>
-        </dd>
-      </div>
-    </dl>
-    <dl
-      class="nhsuk-summary-list nhsuk-u-margin-bottom-4 preview"
-    >
-      <div
-        class="nhsuk-summary-list__row"
-      >
-        <dt
-          class="nhsuk-summary-list__key"
-        >
-          Template proof files
-        </dt>
-        <dd
-          class="nhsuk-summary-list__value"
-        >
-          <ul
-            class="proofs"
-          >
-            <li>
-              <a
-                data-testid="proof-link_a.pdf"
-                href="/templates/files/client/proofs/template-id/a.pdf"
-                rel="noopener noreferrer"
-                target="_blank"
-              >
-                <div
-                  class="container"
-                >
-                  <svg
-                    class="icon"
-                    fill="none"
-                    height="26"
-                    viewBox="0 0 20 26"
-                    width="20"
-                    xmlns="http://www.w3.org/2000/svg"
-                  >
-                    <path
-                      d="M0 0V26H20V6.59375L19.7188 6.28125L13.7188 0.28125L13.4062 0H0ZM2 2H12V8H18V24H2V2ZM14 3.4375L16.5625 6H14V3.4375Z"
-                      fill="#4C6272"
-                    />
-                  </svg>
-                  <p
-                    class="text"
-                  >
-                    a.pdf
-                  </p>
-                </div>
-              </a>
-            </li>
-          </ul>
-        </dd>
-      </div>
-    </dl>
-  </div>
-</DocumentFragment>
-`;
-
 exports[`PreviewTemplateDetailsLetter if status is PROOF_AVAILABLE, but no proofs are registered on the template, proof section is hidden (this is unexpected) 1`] = `
 <DocumentFragment>
   <h1