CCM-12736: update assertions

Author: harrim91

tests/test-team/helpers/db/routing-config-storage-helper.ts

@@ -2,9 +2,7 @@ import { DynamoDBClient } from '@aws-sdk/client-dynamodb';
 import {
   BatchWriteCommand,
   DynamoDBDocumentClient,
-  GetCommand,
 } from '@aws-sdk/lib-dynamodb';
-import type { RoutingConfigDbEntry } from 'helpers/types';
 import type { RoutingConfig } from 'nhs-notify-backend-client';
 
 type RoutingConfigKey = { id: string; clientId: string };
@@ -18,20 +16,6 @@ export class RoutingConfigStorageHelper {
 
   private adHocKeys: RoutingConfigKey[] = [];
 
-  async get(key: RoutingConfigKey): Promise<RoutingConfigDbEntry | null> {
-    const { Item } = await this.dynamo.send(
-      new GetCommand({
-        TableName: process.env.ROUTING_CONFIG_TABLE_NAME,
-        Key: {
-          id: key.id,
-          owner: this.clientOwnerKey(key.clientId),
-        },
-      })
-    );
-
-    return Item as RoutingConfigDbEntry;
-  }
-
   /**
    * Seed a load of routing configs into the database
    */

tests/test-team/template-mgmt-routing-component-tests/create-message-plan.routing-component.spec.ts

@@ -199,7 +199,7 @@ test.describe('Create Message Plan Page', () => {
           page: createMessagePlanPage,
           id: '',
           baseURL,
-          expectedUrl: '/templates/message-plans/choose-message-order',
+          expectedUrl: 'templates/message-plans/choose-message-order',
         };
 
         await assertSkipToMainContent(props);

tests/test-team/template-mgmt-routing-component-tests/edit-message-plan-settings.routing-component.spec.ts

@@ -55,7 +55,7 @@ test('common page tests', async ({ page, baseURL }) => {
     page: editPage,
     id: plan.dbEntry.id,
     baseURL,
-    expectedUrl: `/templates/message-plans/choose-templates/${plan.dbEntry.id}`,
+    expectedUrl: `templates/message-plans/choose-templates/${plan.dbEntry.id}`,
   };
 
   await assertSkipToMainContent(props);
@@ -101,10 +101,14 @@ test.describe('single campaign client', () => {
       `${baseURL}/templates/message-plans/choose-templates/${plan.dbEntry.id}`
     );
 
-    const latest = await storageHelper.get(plan.dbEntry);
+    // reload the edit page - should display the latest data
+    await editPage.loadPage(plan.dbEntry.id);
+
+    await expect(editPage.nameField).toHaveValue('New name!');
 
-    expect(latest?.name).toBe('New name!');
-    expect(latest?.campaignId).toBe(plan.dbEntry.campaignId);
+    await expect(editPage.singleCampaignIdElement).toHaveText(
+      plan.dbEntry.campaignId
+    );
   });
 
   test('displays error if name is empty', async ({ page }) => {
@@ -182,10 +186,14 @@ test.describe('client has multiple campaigns', () => {
       `${baseURL}/templates/message-plans/choose-templates/${plan.dbEntry.id}`
     );
 
-    const latest = await storageHelper.get(plan.dbEntry);
+    // reload the edit page - should display the latest data
+    await editPage.loadPage(plan.dbEntry.id);
+
+    await expect(editPage.nameField).toHaveValue('Updated name');
 
-    expect(latest?.name).toBe('Updated name');
-    expect(latest?.campaignId).toBe(userWithMultipleCampaigns.campaignIds?.[1]);
+    await expect(editPage.campaignIdSelector).toHaveValue(
+      userWithMultipleCampaigns.campaignIds?.[1] as string
+    );
   });
 
   test('displays error if campaign id is not selected', async ({ page }) => {