CCM-8601: hide test data row optionally

Author: alexnuttall

frontend/src/__tests__/app/preview-letter-template/page.test.tsx

@@ -103,8 +103,9 @@ describe('PreviewLetterTemplatePage', () => {
       pdfTemplateInputFile: undefined as unknown as string,
     },
     {
-      description: 'a letter lacking testPersonalisationInputFile',
-      testPersonalisationInputFile: undefined as unknown as string,
+      description:
+        'a letter where testPersonalisationInputFile is the wrong data type',
+      testPersonalisationInputFile: 9 as unknown as string,
     },
   ])(
     'should redirect to invalid-template when template is $description',

frontend/src/__tests__/components/molecules/PreviewTemplate.test.tsx

@@ -82,6 +82,24 @@ describe('PreviewTemplate component', () => {
     expect(container.asFragment()).toMatchSnapshot();
   });
 
+  it('renders letter template when testPersonalisationInputFile is not set', () => {
+    const container = render(
+      <PreviewTemplate.Letter
+        template={{
+          id: 'template-id',
+          name: 'Example template',
+          templateStatus: TemplateStatus.SUBMITTED,
+          templateType: TemplateType.LETTER,
+          letterType: LetterType.STANDARD,
+          language: Language.FRENCH,
+          pdfTemplateInputFile: 'file.pdf',
+        }}
+      />
+    );
+
+    expect(container.asFragment()).toMatchSnapshot();
+  });
+
   it('renders component correctly', () => {
     render(
       <PreviewTemplate

frontend/src/__tests__/components/molecules/__snapshots__/PreviewTemplate.test.tsx.snap

@@ -214,6 +214,122 @@ exports[`PreviewTemplate component matches submitted snapshot 1`] = `
 </DocumentFragment>
 `;
 
+exports[`PreviewTemplate component renders letter template when testPersonalisationInputFile is not set 1`] = `
+<DocumentFragment>
+  <h1
+    class="review__heading"
+    data-testid="preview-message__heading"
+  >
+    Example template
+  </h1>
+  <div
+    class="nhsuk-width-container nhsuk-u-margin-bottom-6 nhsuk-body-m"
+  >
+    <div
+      class="preview"
+    >
+      <div
+        class="nhsuk-grid-row preview__row"
+      >
+        <div
+          class="nhsuk-grid-column-one-third preview__col"
+        >
+          <div
+            class="preview__col_heading"
+          >
+            Template ID
+          </div>
+        </div>
+        <div
+          class="nhsuk-grid-column-two-thirds col"
+        >
+          template-id
+        </div>
+      </div>
+      <div
+        class="nhsuk-grid-row preview__row"
+      >
+        <div
+          class="nhsuk-grid-column-one-third preview__col"
+        >
+          <div
+            class="preview__col_heading"
+          >
+            Type
+          </div>
+        </div>
+        <div
+          class="nhsuk-grid-column-two-thirds col"
+        >
+          Letter - French
+        </div>
+      </div>
+      <div
+        class="nhsuk-grid-row preview__row"
+      >
+        <div
+          class="nhsuk-grid-column-one-third preview__col"
+        >
+          <div
+            class="preview__col_heading"
+          >
+            Status
+          </div>
+        </div>
+        <div
+          class="nhsuk-grid-column-two-thirds col"
+        >
+          <strong
+            class="nhsuk-tag nhsuk-tag--grey"
+          >
+            Submitted
+          </strong>
+        </div>
+      </div>
+      <div
+        class="nhsuk-grid-row preview__row"
+      >
+        <div
+          class="nhsuk-grid-column-one-third preview__col"
+        >
+          <div
+            class="preview__col_heading"
+          >
+            Template file
+          </div>
+        </div>
+        <div
+          class="nhsuk-grid-column-two-thirds col"
+        >
+          <div
+            class="container"
+          >
+            <svg
+              class="icon"
+              fill="none"
+              height="26"
+              viewBox="0 0 20 26"
+              width="20"
+              xmlns="http://www.w3.org/2000/svg"
+            >
+              <path
+                d="M0 0V26H20V6.59375L19.7188 6.28125L13.7188 0.28125L13.4062 0H0ZM2 2H12V8H18V24H2V2ZM14 3.4375L16.5625 6H14V3.4375Z"
+                fill="#4C6272"
+              />
+            </svg>
+            <p
+              class="text"
+            >
+              file.pdf
+            </p>
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+</DocumentFragment>
+`;
+
 exports[`PreviewTemplate component renders without content preview 1`] = `
 <DocumentFragment>
   <h1

frontend/src/components/molecules/ManageTemplates/ManageTemplates.tsx

@@ -26,14 +26,17 @@ const generateViewTemplateLink = (template: TemplateDTO): string => {
   return `/${previewTemplatePages(template.templateType)}/${template.id}`;
 };
 
-const typeDisplayMappings = (template: TemplateDTO) =>
-  template.templateType === TemplateType.LETTER &&
-  'letterType' in template &&
-  template.letterType &&
-  'language' in template &&
-  template.language
+const typeDisplayMappings = (template: TemplateDTO): string => {
+  console.log(template);
+
+  return template.templateType === TemplateType.LETTER &&
+    'letterType' in template &&
+    template.letterType &&
+    'language' in template &&
+    template.language
     ? letterTypeDisplayMappings(template.letterType, template.language)
     : templateTypeDisplayMappings(template.templateType);
+};
 
 export function ManageTemplates({
   templateList,

frontend/src/components/molecules/PreviewTemplate/PreviewTemplate.tsx

@@ -169,11 +169,17 @@ PreviewTemplate.Letter = ({ template }: { template: LetterTemplate }) => (
         id: 'templatefile',
         content: <Filename filename={template.pdfTemplateInputFile} />,
       },
-      {
-        title: 'Test personalisation file',
-        id: 'testdatafile',
-        content: <Filename filename={template.testPersonalisationInputFile} />,
-      },
+      ...(template.testPersonalisationInputFile
+        ? [
+            {
+              title: 'Test personalisation file',
+              id: 'testdatafile',
+              content: (
+                <Filename filename={template.testPersonalisationInputFile} />
+              ),
+            },
+          ]
+        : []),
     ]}
   />
 );

utils/utils/src/enum.ts

@@ -16,7 +16,7 @@ export const languageMapping = (language: Language) =>
 
 const letterTypeMapping = (letterType: LetterType) =>
   ({
-    [LetterType.AUDIO]: 'Audio',
+    [LetterType.AUDIO]: 'Audio CD',
     [LetterType.BRAILLE]: 'Braille',
     [LetterType.BSL]: 'British Sign Language',
     [LetterType.STANDARD]: 'Standard',

utils/utils/src/zod-validators.ts

@@ -55,7 +55,7 @@ export const $LetterTemplate = $TemplateBase.extend({
   letterType: z.nativeEnum(LetterType),
   language: z.nativeEnum(Language),
   pdfTemplateInputFile: z.string(),
-  testPersonalisationInputFile: z.string(),
+  testPersonalisationInputFile: z.string().optional(),
 });
 const $SubmittedLetterTemplate = $LetterTemplate.extend({
   templateStatus: z.literal(TemplateStatus.SUBMITTED),