CCM-11148 Improve test coverage

Author: nicki-nhs

frontend/src/__tests__/app/internal/features/route.test.ts

@@ -3,7 +3,7 @@ import { getSessionServer } from '@utils/amplify-utils';
 import { fetchClient } from '@utils/server-features';
 import { FEATURES, initialFeatureFlags } from '@utils/features';
 import { NextRequest, NextResponse } from 'next/server';
-import { ErrorCase } from 'nhs-notify-backend-client';
+import { ErrorCase, Result } from 'nhs-notify-backend-client';
 
 jest.mock('@utils/amplify-utils');
 jest.mock('@utils/server-features');
@@ -45,6 +45,7 @@ describe('features route', () => {
   });
 
   it('returns initialFeatureFlags if no access token', async () => {
+    mockGetSessionServer.mockReset();
     mockGetSessionServer.mockResolvedValueOnce({});
 
     const req = createRequest();
@@ -81,4 +82,14 @@ describe('features route', () => {
 
     expect(json).toEqual(allFeaturesEnabled);
   });
+
+  it('returns initialFeatureFlags if fetchClient returns undefined', async () => {
+    mockFetchClient.mockResolvedValueOnce({} as Result<null>);
+
+    const req = createRequest();
+    const res = await getFeatures(req);
+    const json = await res.json();
+
+    expect(json).toEqual(initialFeatureFlags);
+  });
 });

frontend/src/__tests__/components/providers/features-provider.test.tsx

@@ -85,5 +85,34 @@ describe('FeatureFlagProvider', () => {
         expect(screen.getByTestId('routing')).toHaveTextContent('false');
       });
     });
+
+    it('should fall back to default flags when response.ok is false', async () => {
+      (global.fetch as jest.Mock).mockResolvedValue({
+        ok: false,
+        json: async () => ({ proofing: true, routing: true }),
+      });
+
+      renderWithProvider();
+
+      await waitFor(() => {
+        expect(screen.getByTestId('loaded')).toHaveTextContent('true');
+        expect(screen.getByTestId('proofing')).toHaveTextContent('false');
+        expect(screen.getByTestId('routing')).toHaveTextContent('false');
+      });
+    });
+  });
+
+  it('should not fetch feature flags when authStatus is neither authenticated or unauthenticated', async () => {
+    mockUseAuthStatus.mockReturnValue('configuring');
+
+    renderWithProvider();
+
+    await waitFor(() => {
+      expect(screen.getByTestId('loaded')).toHaveTextContent('false');
+      expect(screen.getByTestId('proofing')).toHaveTextContent('false');
+      expect(screen.getByTestId('routing')).toHaveTextContent('false');
+    });
+
+    expect(global.fetch).not.toHaveBeenCalled();
   });
 });

frontend/src/components/providers/features-provider.tsx

@@ -46,6 +46,7 @@ export function FeatureFlagProvider({
 
         if (!response.ok) {
           setFeatureFlags(initialFeatureFlags);
+          return;
         }
 
         const data: ClientFeatures = await response.json();