CCM-10981: wip

Author: bhansell1

.github/actions/node-modules-cache/action.yaml

@@ -8,10 +8,6 @@ inputs:
     description: "Path(s) to package-lock.json for cache key"
     required: false
     default: "**/package-lock.json"
-  install_on_miss:
-    description: "Run npm ci when cache is missing"
-    required: false
-    default: "false"
 runs:
   using: "composite"
   steps:
@@ -32,7 +28,7 @@ runs:
         restore-keys: |
           ${{ runner.os }}-node-${{ inputs.node_version }}-
     - name: "Install dependencies (cache miss)"
-      if: steps.node-modules-cache.outputs.cache-hit != 'true' && inputs.install_on_miss == 'true'
+      if: steps.node-modules-cache.outputs.cache-hit != 'true'
       shell: bash
       run: |
         npm ci

.github/workflows/cicd-1-pull-request.yaml

@@ -92,7 +92,7 @@ jobs:
     secrets: inherit
   test-stage: # Recommended maximum execution time is 5 minutes
     name: "Test stage"
-    needs: [metadata]
+    needs: [metadata, commit-stage]
     uses: ./.github/workflows/stage-2-test.yaml
     with:
       build_datetime: "${{ needs.metadata.outputs.build_datetime }}"

.github/workflows/stage-2-test.yaml

@@ -52,8 +52,6 @@ jobs:
         uses: ./.github/actions/node-modules-cache
         with:
           node_version: "${{ inputs.nodejs_version }}"
-          cache_lock_path: "**/package-lock.json"
-          install_on_miss: "true"
 
   check-generated-dependencies:
     name: "Check generated dependencies"