Skip to content

Commit cb7b724

Browse files
CCM-9247: Add error log
1 parent fe45c29 commit cb7b724

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

lambdas/backend-api/src/__tests__/templates/api/process-proof.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { mockDeep } from 'jest-mock-extended';
22
import { createHandler } from '../../../templates/api/process-proof';
33
import { TemplateRepository } from '../../../templates/infra';
44
import { LetterFileRepository } from '@backend-api/templates/infra/letter-file-repository';
5+
import type { Logger } from 'nhs-notify-web-template-management-utils/logger';
56

67
test.each([
78
[
@@ -35,6 +36,7 @@ test.each([
3536
const handler = createHandler({
3637
templateRepository,
3738
letterFileRepository,
39+
logger: mockDeep<Logger>(),
3840
});
3941

4042
await handler({

lambdas/backend-api/src/templates/api/process-proof.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,17 @@ import { guardDutyEventValidator } from 'nhs-notify-web-template-management-util
22
import type { TemplateRepository } from '../infra';
33
import { LetterProofRepository } from '../infra/letter-proof-repository';
44
import { LetterFileRepository } from '../infra/letter-file-repository';
5+
import type { Logger } from 'nhs-notify-web-template-management-utils/logger';
56

67
export const createHandler =
78
({
89
templateRepository,
910
letterFileRepository,
11+
logger,
1012
}: {
1113
templateRepository: TemplateRepository;
1214
letterFileRepository: LetterFileRepository;
15+
logger: Logger;
1316
}) =>
1417
async (event: unknown) => {
1518
const {
@@ -38,6 +41,11 @@ export const createHandler =
3841
versionId,
3942
internalKey
4043
);
44+
} else {
45+
logger.error({
46+
description: 'File found that did not pass virus scan',
47+
objectKey,
48+
});
4149
}
4250

4351
// we will copy to the download bucket here as well

lambdas/backend-api/src/templates/container.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,5 @@ export const createTemplateRepositoryContainer = () => {
8383
export const createLetterFileRepositoryAndTemplateRepositoryContainer = () => ({
8484
...createTemplateRepositoryContainer(),
8585
...createLetterFileRepositoryContainer(),
86+
logger,
8687
});

0 commit comments

Comments
 (0)