CCM-8585: use ISO codes for languages internally

alexnuttall · alexnuttall · commit cd8c5d82e451 · 2025-03-03T14:15:15.000Z
diff --git a/frontend/src/__tests__/app/copy-template/page.test.tsx b/frontend/src/__tests__/app/copy-template/page.test.tsx
@@ -40,7 +40,7 @@ describe('CopyTemplatePage', () => {
     createdAt: '2025-01-13T10:19:25.579Z',
     updatedAt: '2025-01-13T10:19:25.579Z',
     letterType: LetterType.BSL,
-    language: Language.FRENCH,
+    language: Language.FR,
     pdfTemplateInputFile: 'file.pdf',
     testPersonalisationInputFile: 'file.csv',
   };
diff --git a/frontend/src/__tests__/app/preview-email-template/page.test.tsx b/frontend/src/__tests__/app/preview-email-template/page.test.tsx
@@ -79,7 +79,7 @@ describe('PreviewEmailTemplatePage', () => {
       templateType: TemplateType.LETTER,
       name: 'template-name',
       letterType: LetterType.STANDARD,
-      language: Language.ENGLISH,
+      language: Language.EN,
       pdfTemplateInputFile: 'template.pdf',
       testPersonalisationInputFile: 'test-data.csv',
     },
diff --git a/frontend/src/__tests__/app/preview-letter-template/page.test.tsx b/frontend/src/__tests__/app/preview-letter-template/page.test.tsx
@@ -27,7 +27,7 @@ const templateDTO = {
   createdAt: '2025-01-13T10:19:25.579Z',
   updatedAt: '2025-01-13T10:19:25.579Z',
   letterType: LetterType.STANDARD,
-  language: Language.ENGLISH,
+  language: Language.EN,
   pdfTemplateInputFile: 'template.pdf',
   testPersonalisationInputFile: 'test-data.csv',
 } satisfies TemplateDTO;
diff --git a/frontend/src/__tests__/app/preview-nhs-app-template/page.test.tsx b/frontend/src/__tests__/app/preview-nhs-app-template/page.test.tsx
@@ -77,7 +77,7 @@ describe('PreviewNhsAppTemplatePage', () => {
       templateType: TemplateType.LETTER,
       name: 'template-name',
       letterType: LetterType.STANDARD,
-      language: Language.ENGLISH,
+      language: Language.EN,
       pdfTemplateInputFile: 'template.pdf',
       testPersonalisationInputFile: 'test-data.csv',
     },
diff --git a/frontend/src/__tests__/app/preview-text-message-template/page.test.tsx b/frontend/src/__tests__/app/preview-text-message-template/page.test.tsx
@@ -75,7 +75,7 @@ describe('PreviewSMSTemplatePage', () => {
       templateType: TemplateType.LETTER,
       name: 'template-name',
       letterType: LetterType.STANDARD,
-      language: Language.ENGLISH,
+      language: Language.EN,
       pdfTemplateInputFile: 'template.pdf',
       testPersonalisationInputFile: 'test-data.csv',
     },
diff --git a/frontend/src/__tests__/components/forms/ReviewLetterTemplate/ReviewLetterTemplate.test.tsx b/frontend/src/__tests__/components/forms/ReviewLetterTemplate/ReviewLetterTemplate.test.tsx
@@ -41,7 +41,7 @@ describe('Review letter form renders', () => {
           validationError: undefined,
           name: 'test-template-letter',
           id: 'template-id',
-          language: Language.ENGLISH,
+          language: Language.EN,
           letterType: LetterType.BRAILLE,
           pdfTemplateInputFile: 'file.pdf',
           testPersonalisationInputFile: 'test-data.csv',
@@ -64,7 +64,7 @@ describe('Review letter form renders', () => {
           validationError: undefined,
           name: 'test-template-letter',
           id: 'template-id',
-          language: Language.ENGLISH,
+          language: Language.EN,
           letterType: LetterType.BRAILLE,
           pdfTemplateInputFile: 'file.pdf',
           testPersonalisationInputFile: 'test-data.csv',
@@ -87,7 +87,7 @@ describe('Review letter form renders', () => {
           },
           name: 'test-template-letter',
           id: 'template-id',
-          language: Language.GERMAN,
+          language: Language.DE,
           letterType: LetterType.AUDIO,
           pdfTemplateInputFile: 'file.pdf',
           testPersonalisationInputFile: 'test-data.csv',
@@ -105,7 +105,7 @@ describe('Review letter form renders', () => {
           validationError: undefined,
           name: 'test-template-email',
           id: 'template-id',
-          language: Language.HINDI,
+          language: Language.HI,
           letterType: LetterType.STANDARD,
           pdfTemplateInputFile: 'file.pdf',
           testPersonalisationInputFile: 'test-data.csv',
diff --git a/frontend/src/__tests__/components/forms/ReviewLetterTemplate/server-action.test.ts b/frontend/src/__tests__/components/forms/ReviewLetterTemplate/server-action.test.ts
@@ -20,7 +20,7 @@ const initialState: LetterTemplate = {
   templateType: TemplateType.LETTER,
   templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
   name: 'template-name',
-  language: Language.ALBANIAN,
+  language: Language.SQ,
   letterType: LetterType.STANDARD,
   pdfTemplateInputFile: 'file.pdf',
   testPersonalisationInputFile: 'test-data.csv',
diff --git a/frontend/src/__tests__/components/molecules/ManageTemplates.test.tsx b/frontend/src/__tests__/components/molecules/ManageTemplates.test.tsx
@@ -38,7 +38,7 @@ const manageTemplatesProps = {
       name: 'Template 3',
       createdAt: '2021-02-01T00:00:00.000Z',
       letterType: LetterType.STANDARD,
-      language: Language.FRENCH,
+      language: Language.FR,
       pdfTemplateInputFile: 'file.pdf',
       testPersonalisationInputFile: 'file.csv',
       updatedAt: '2021-02-01T00:00:00.000Z',
diff --git a/frontend/src/__tests__/components/molecules/PreviewTemplate.test.tsx b/frontend/src/__tests__/components/molecules/PreviewTemplate.test.tsx
@@ -64,7 +64,7 @@ describe('PreviewTemplate component', () => {
           templateStatus: TemplateStatus.SUBMITTED,
           templateType: TemplateType.LETTER,
           letterType: LetterType.STANDARD,
-          language: Language.FRENCH,
+          language: Language.FR,
           pdfTemplateInputFile: 'file.pdf',
           testPersonalisationInputFile: 'file.csv',
         }}
@@ -91,7 +91,7 @@ describe('PreviewTemplate component', () => {
           templateStatus: TemplateStatus.SUBMITTED,
           templateType: TemplateType.LETTER,
           letterType: LetterType.STANDARD,
-          language: Language.FRENCH,
+          language: Language.FR,
           pdfTemplateInputFile: 'file.pdf',
         }}
       />
diff --git a/infrastructure/terraform/modules/backend-api/spec.tmpl.json b/infrastructure/terraform/modules/backend-api/spec.tmpl.json
@@ -353,35 +353,35 @@
       "Language": {
         "type": "string",
         "enum": [
-          "ALBANIAN",
-          "ARABIC",
-          "BULGARIAN",
-          "CHINESE",
-          "ENGLISH",
-          "FRENCH",
-          "GERMAN",
-          "GUJARATI",
-          "HINDI",
-          "HUNGARIAN",
-          "ITALIAN",
-          "LATVIAN",
-          "LITHUANIAN",
-          "MODERN GREEK",
-          "NEPALI",
-          "PERSIAN",
-          "POLISH",
-          "PUNJABI",
-          "ROMANIAN",
-          "RUSSIAN",
-          "SLOVAK",
-          "SOMALI",
-          "SPANISH",
-          "TURKISH",
-          "BENGALI",
-          "KURDISH",
-          "PORTUGUESE",
-          "TAMIL",
-          "URDU"
+          "ar",
+          "bg",
+          "bn",
+          "de",
+          "el",
+          "en",
+          "es",
+          "fa",
+          "fr",
+          "gu",
+          "hi",
+          "hu",
+          "it",
+          "ku",
+          "lt",
+          "lv",
+          "ne",
+          "pa",
+          "pl",
+          "pt",
+          "ro",
+          "ru",
+          "sk",
+          "so",
+          "sq",
+          "ta",
+          "tr",
+          "ur",
+          "zh"
         ]
       },
       "LetterType": {
diff --git a/lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts b/lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts
@@ -253,7 +253,7 @@ describe('templateClient', () => {
           updatedAt: new Date().toISOString(),
           templateStatus: TemplateStatus.NOT_YET_SUBMITTED,
           letterType: LetterType.BSL,
-          language: Language.FRENCH,
+          language: Language.FR,
           pdfTemplateInputFile: 'file.pdf',
           testPersonalisationInputFile: 'file.csv',
           owner: 'owner',
diff --git a/lambdas/backend-client/src/types/generated/models/Language.ts b/lambdas/backend-client/src/types/generated/models/Language.ts
@@ -3,33 +3,33 @@
 /* tslint:disable */
 /* eslint-disable */
 export enum Language {
-    ALBANIAN = 'ALBANIAN',
-    ARABIC = 'ARABIC',
-    BULGARIAN = 'BULGARIAN',
-    CHINESE = 'CHINESE',
-    ENGLISH = 'ENGLISH',
-    FRENCH = 'FRENCH',
-    GERMAN = 'GERMAN',
-    GUJARATI = 'GUJARATI',
-    HINDI = 'HINDI',
-    HUNGARIAN = 'HUNGARIAN',
-    ITALIAN = 'ITALIAN',
-    LATVIAN = 'LATVIAN',
-    LITHUANIAN = 'LITHUANIAN',
-    MODERN_GREEK = 'MODERN GREEK',
-    NEPALI = 'NEPALI',
-    PERSIAN = 'PERSIAN',
-    POLISH = 'POLISH',
-    PUNJABI = 'PUNJABI',
-    ROMANIAN = 'ROMANIAN',
-    RUSSIAN = 'RUSSIAN',
-    SLOVAK = 'SLOVAK',
-    SOMALI = 'SOMALI',
-    SPANISH = 'SPANISH',
-    TURKISH = 'TURKISH',
-    BENGALI = 'BENGALI',
-    KURDISH = 'KURDISH',
-    PORTUGUESE = 'PORTUGUESE',
-    TAMIL = 'TAMIL',
-    URDU = 'URDU',
+    AR = 'ar',
+    BG = 'bg',
+    BN = 'bn',
+    DE = 'de',
+    EL = 'el',
+    EN = 'en',
+    ES = 'es',
+    FA = 'fa',
+    FR = 'fr',
+    GU = 'gu',
+    HI = 'hi',
+    HU = 'hu',
+    IT = 'it',
+    KU = 'ku',
+    LT = 'lt',
+    LV = 'lv',
+    NE = 'ne',
+    PA = 'pa',
+    PL = 'pl',
+    PT = 'pt',
+    RO = 'ro',
+    RU = 'ru',
+    SK = 'sk',
+    SO = 'so',
+    SQ = 'sq',
+    TA = 'ta',
+    TR = 'tr',
+    UR = 'ur',
+    ZH = 'zh',
 }
diff --git a/tests/test-team/helpers/factories/template-factory.ts b/tests/test-team/helpers/factories/template-factory.ts
@@ -41,7 +41,7 @@ export const TemplateFactory = {
       name,
       templateType: TemplateType.LETTER,
       letterType: LetterType.STANDARD,
-      language: Language.ENGLISH,
+      language: Language.EN,
       pdfTemplateInputFile: 'file.pdf',
       testPersonalisationInputFile: 'test-data.csv',
     });
diff --git a/utils/utils/src/__tests__/enum.test.ts b/utils/utils/src/__tests__/enum.test.ts
@@ -34,13 +34,13 @@ describe('templateTypeDisplayMappings', () => {
 
 describe('letterTypeDisplayMappings', () => {
   const letterCases: [LetterType, Language, string][] = [
-    [LetterType.STANDARD, Language.ENGLISH, 'Standard letter'],
-    [LetterType.STANDARD, Language.BENGALI, 'Letter - Bengali'],
-    [LetterType.STANDARD, Language.MODERN_GREEK, 'Letter - Modern Greek'],
-    [LetterType.BRAILLE, Language.ENGLISH, 'Braille letter'],
-    [LetterType.AUDIO, Language.ENGLISH, 'Audio CD letter'],
-    [LetterType.LARGE_PRINT, Language.ENGLISH, 'Large print letter'],
-    [LetterType.BSL, Language.ENGLISH, 'British Sign Language letter'],
+    [LetterType.STANDARD, Language.EN, 'Standard letter'],
+    [LetterType.STANDARD, Language.BN, 'Letter - Bengali'],
+    [LetterType.STANDARD, Language.EL, 'Letter - Greek'],
+    [LetterType.BRAILLE, Language.EN, 'Braille letter'],
+    [LetterType.AUDIO, Language.EN, 'Audio CD letter'],
+    [LetterType.LARGE_PRINT, Language.EN, 'Large print letter'],
+    [LetterType.BSL, Language.EN, 'British Sign Language letter'],
   ];
 
   test.each(letterCases)(
diff --git a/utils/utils/src/enum.ts b/utils/utils/src/enum.ts
@@ -9,11 +9,37 @@ import {
 export { TemplateType, TemplateStatus };
 
 export const languageMapping = (language: Language) =>
-  language
-    .split(' ')
-    .map((word) => `${word[0]}${word.slice(1).toLocaleLowerCase()}`)
-    .join(' ');
-
+  ({
+    [Language.AR]: 'Arabic',
+    [Language.BG]: 'Bulgarian',
+    [Language.BN]: 'Bengali',
+    [Language.DE]: 'German',
+    [Language.EL]: 'Greek',
+    [Language.EN]: 'English',
+    [Language.ES]: 'Spanish',
+    [Language.FA]: 'Persian',
+    [Language.FR]: 'French',
+    [Language.GU]: 'Gujurati',
+    [Language.HI]: 'Hindi',
+    [Language.HU]: 'Hungarian',
+    [Language.IT]: 'Italian',
+    [Language.KU]: 'Kurdish',
+    [Language.LT]: 'Lithuanian',
+    [Language.LV]: 'Latvian',
+    [Language.NE]: 'Nepali',
+    [Language.PA]: 'Punjabi',
+    [Language.PL]: 'Polish',
+    [Language.PT]: 'Portuguese',
+    [Language.RO]: 'Romanian',
+    [Language.RU]: 'Russian',
+    [Language.SK]: 'Slovak',
+    [Language.SO]: 'Somali',
+    [Language.SQ]: 'Albanian',
+    [Language.TA]: 'Tamil',
+    [Language.TR]: 'Turkish',
+    [Language.UR]: 'Urdu',
+    [Language.ZH]: 'Chinese',
+  })[language];
 const letterTypeMapping = (letterType: LetterType) =>
   ({
     [LetterType.AUDIO]: 'Audio CD',
@@ -27,7 +53,7 @@ export const letterTypeDisplayMappings = (
   letterType: LetterType,
   language: Language
 ) =>
-  language === Language.ENGLISH
+  language === Language.EN
     ? `${letterTypeMapping(letterType)} letter`
     : `Letter - ${languageMapping(language)}`;
 
