rename TemplateRepository

Author: alexnuttall

lambdas/sftp-letters/src/__tests__/app/send.test.ts

@@ -1,5 +1,5 @@
 import { mock } from 'jest-mock-extended';
-import { TemplateRepository } from '../../infra/template-repository';
+import { TemplateLockRepository } from '../../infra/template-lock-repository';
 import { UserDataRepository } from '../../infra/user-data-repository';
 import { App } from '../../app/send';
 import { SyntheticBatch, Manifest } from '../../domain/synthetic-batch';
@@ -19,7 +19,7 @@ const messageId = 'message-id';
 
 function setup() {
   const userDataRepository = mock<UserDataRepository>();
-  const templateRepository = mock<TemplateRepository>();
+  const templateRepository = mock<TemplateLockRepository>();
   const syntheticBatch = mock<SyntheticBatch>();
   const { logger, logMessages } = createMockLogger();
 

lambdas/sftp-letters/src/__tests__/domain/test-data.test.ts

@@ -1,16 +1,16 @@
-/* eslint-disable security/detect-non-literal-fs-filename */
-import { readFileSync } from 'node:fs';
-import path from 'node:path';
 import { parseTestPersonalisation } from '../../domain/test-data';
 
-const testDataCsv = readFileSync(
-  path.resolve(__dirname, '..', 'fixtures', 'test-data.csv'),
-  'utf8'
-);
-const testDataCsvInvalid = readFileSync(
-  path.resolve(__dirname, '..', 'fixtures', 'test-data-invalid.csv'),
-  'utf8'
-);
+const testDataCsv = `Personalisation field,Short length data example,Medium length data example,Long length data example
+appointment_date,Monday 1 May 2025,Saturday 10 April 2025,Wednesday 10 September 2025
+appointment_time,1:56pm,11:56am,12:56pm
+appointment_location,"The Epping Breast Screening Unit, St Margaret's Hospital, The Plain, Epping, Essex, CM16 6TN","The Royal Shrewsbury Hospital, Breast Screening Office, Treatment Centre, Mytton Oak Road, Shrewsbury, SY3 8XQ","City, Sandwell & Walsall BSS, The Rosewood Centre, Sandwell & West Birmingham Hospitals NHS Trust, The Birmingham Treatment Centre, City Hospital, Dudley Road, Birmingham, B18 7QH"
+contact_telephone_number,020 3299 9010,020 3299 9010,020 3299 9010
+`;
+
+const testDataCsvInvalid = `parameter,short example,medium example,long example
+appointment_date,Wednesday 10 September 2025
+appointment_time,12:56pm,11:56am,1:56pm
+`;
 
 describe('parseTestPersonalisation', () => {
   test('parses valid test data', () => {

lambdas/sftp-letters/src/__tests__/fixtures/test-data-invalid.csv

@@ -1,5 +1,5 @@
 import { DynamoDBDocumentClient, UpdateCommand } from '@aws-sdk/lib-dynamodb';
-import { TemplateRepository } from '../../infra/template-repository';
+import { TemplateLockRepository } from '../../infra/template-lock-repository';
 import 'aws-sdk-client-mock-jest';
 import { mockClient } from 'aws-sdk-client-mock';
 import { isoDateRegExp } from 'nhs-notify-web-template-management-test-helper-utils';
@@ -14,7 +14,7 @@ const sendLockTtlMs = 50_000;
 function setup() {
   const client = mockClient(DynamoDBDocumentClient);
 
-  const templateRepository = new TemplateRepository(
+  const templateRepository = new TemplateLockRepository(
     client as unknown as DynamoDBDocumentClient,
     templatesTableName,
     () => mockDate,
@@ -24,7 +24,7 @@ function setup() {
   return { templateRepository, mocks: { client } };
 }
 
-describe('TemplateRepository', () => {
+describe('TemplateLockRepository', () => {
   describe('acquireLock', () => {
     test('returns true when database update succeeds', async () => {
       const { mocks, templateRepository } = setup();

lambdas/sftp-letters/src/__tests__/fixtures/test-data.csv

@@ -2,7 +2,7 @@ import type { SftpClient } from '../infra/sftp-client';
 import type { UserDataRepository } from '../infra/user-data-repository';
 import type { Logger } from 'nhs-notify-web-template-management-utils/logger';
 import type { SyntheticBatch } from '../domain/synthetic-batch';
-import type { TemplateRepository } from '../infra/template-repository';
+import type { TemplateLockRepository } from '../infra/template-lock-repository';
 import { parseTestPersonalisation } from '../domain/test-data';
 import { serialiseCsv } from '../infra/serialise-csv';
 import { z } from 'zod';
@@ -13,7 +13,7 @@ import type { ProofingRequest } from '../infra/types';
 export class App {
   constructor(
     private readonly userDataRepository: UserDataRepository,
-    private readonly templateRepository: TemplateRepository,
+    private readonly templateRepository: TemplateLockRepository,
     private readonly sftpEnvironment: string,
     private readonly batch: SyntheticBatch,
     private readonly logger: Logger

…ests__/infra/template-repository.test.ts …_/infra/template-lock-repository.test.tslambdas/sftp-letters/src/__tests__/infra/template-repository.test.ts renamed to lambdas/sftp-letters/src/__tests__/infra/template-lock-repository.test.ts lambdas/sftp-letters/src/__tests__/infra/template-repository.test.ts renamed to lambdas/sftp-letters/src/__tests__/infra/template-lock-repository.test.ts

@@ -6,7 +6,7 @@ import { loadConfig } from './config/config';
 import { App } from './app/send';
 import { logger } from 'nhs-notify-web-template-management-utils/logger';
 import { SyntheticBatch } from './domain/synthetic-batch';
-import { TemplateRepository } from './infra/template-repository';
+import { TemplateLockRepository } from './infra/template-lock-repository';
 import { DynamoDBDocumentClient } from '@aws-sdk/lib-dynamodb';
 import { DynamoDBClient } from '@aws-sdk/client-dynamodb';
 import ksuid from 'ksuid';
@@ -43,7 +43,7 @@ export function createContainer() {
   // eslint-disable-next-line unicorn/consistent-function-scoping
   const getDate = () => new Date();
 
-  const templateRepository = new TemplateRepository(
+  const templateRepository = new TemplateLockRepository(
     ddbDocClient,
     templatesTableName,
     getDate,

lambdas/sftp-letters/src/app/send.ts

@@ -2,7 +2,7 @@ import { ConditionalCheckFailedException } from '@aws-sdk/client-dynamodb';
 import { DynamoDBDocumentClient, UpdateCommand } from '@aws-sdk/lib-dynamodb';
 import { TemplateUpdateBuilder } from 'nhs-notify-entity-update-command-builder';
 
-export class TemplateRepository {
+export class TemplateLockRepository {
   constructor(
     private readonly client: DynamoDBDocumentClient,
     private readonly templatesTableName: string,