CCM-12225: Fix tests

Author: chris-elliott-nhsd

lambdas/backend-api/src/__tests__/templates/infra/template-repository.test.ts

@@ -2108,6 +2108,7 @@ describe('templateRepository', () => {
           '#templateType': 'templateType',
           '#updatedAt': 'updatedAt',
           '#proofingEnabled': 'proofingEnabled',
+          '#supplierReferences': 'supplierReferences',
         },
         ExpressionAttributeValues: {
           ':condition_1_templateStatus': 'PENDING_PROOF_REQUEST',
@@ -2116,13 +2117,14 @@ describe('templateRepository', () => {
           ':condition_5_proofingEnabled': true,
           ':templateStatus': 'WAITING_FOR_PROOF',
           ':updatedAt': '2024-12-27T00:00:00.000Z',
+          ':supplierReferences': {},
         },
         Key: { id: 'template-id', owner: ownerWithClientPrefix },
         ReturnValues: 'ALL_NEW',
         ReturnValuesOnConditionCheckFailure: 'ALL_OLD',
         TableName: 'templates',
         UpdateExpression:
-          'SET #templateStatus = :templateStatus, #updatedAt = :updatedAt',
+          'SET #templateStatus = :templateStatus, #supplierReferences = if_not_exists(#supplierReferences, :supplierReferences), #updatedAt = :updatedAt',
       });
     });
 

lambdas/backend-api/src/templates/infra/template-repository.ts

@@ -652,6 +652,11 @@ export class TemplateRepository {
       )
         .setStatus('WAITING_FOR_PROOF')
         .expectedStatus('PENDING_PROOF_REQUEST')
+
+        // dynamodb does not support conditional initialising of maps, so we have to
+        // initialise an empty map here, then we set supplier-specific values in the
+        // per-supplier sftp send lambda
+        .initialiseSupplierReferences()
         .expectedTemplateType('LETTER')
         .expectedClientId(user.clientId)
         .expectTemplateExists()

utils/entity-update-command-builder/src/__tests__/common/update-command-builder.test.ts

@@ -105,6 +105,29 @@ describe('UpdateExpressionBuilder', () => {
     });
   });
 
+  describe('setValueIfNotExists', () => {
+    test("sets value if it doesn't exist", () => {
+      const builder = new UpdateCommandBuilder<Record<string, string>>(
+        mockTableName,
+        mockEntityKeys
+      );
+
+      const res = builder.setValueIfNotExists('newKey', 'newValue').finalise();
+
+      expect(res).toEqual({
+        TableName: mockTableName,
+        Key: mockEntityKeys,
+        ExpressionAttributeValues: {
+          ':newKey': 'newValue',
+        },
+        ExpressionAttributeNames: {
+          '#newKey': 'newKey',
+        },
+        UpdateExpression: 'SET #newKey = if_not_exists(#newKey, :newKey)',
+      });
+    });
+  });
+
   describe('conditions', () => {
     const operandTestCases: [op: ConditionOperator, negated: boolean][] = [
       ['<', false],

utils/entity-update-command-builder/src/__tests__/template-update-builder.test.ts

@@ -200,6 +200,36 @@ describe('TemplateUpdateBuilder', () => {
     });
   });
 
+  describe('initialiseSupplierReferences', () => {
+    test('initialises supplier references', () => {
+      const builder = new TemplateUpdateBuilder(
+        mockTableName,
+        mockOwner,
+        mockId
+      );
+
+      const res = builder.initialiseSupplierReferences().build();
+
+      expect(res).toEqual({
+        ExpressionAttributeNames: {
+          '#supplierReferences': 'supplierReferences',
+          '#updatedAt': 'updatedAt',
+        },
+        ExpressionAttributeValues: {
+          ':supplierReferences': {},
+          ':updatedAt': '2025-01-01T09:00:00.000Z',
+        },
+        Key: {
+          id: 'Hello2',
+          owner: 'Hello1',
+        },
+        TableName: 'TABLE_NAME',
+        UpdateExpression:
+          'SET #supplierReferences = if_not_exists(#supplierReferences, :supplierReferences), #updatedAt = :updatedAt',
+      });
+    });
+  });
+
   describe('setLockTime', () => {
     test('sets lock time if no lock exists', () => {
       const builder = new TemplateUpdateBuilder(

utils/entity-update-command-builder/src/common/update-command-builder.ts

@@ -45,6 +45,17 @@ export class UpdateCommandBuilder<Entity> {
     return this;
   }
 
+  setValueIfNotExists<T extends Prop<Entity>, K extends PropType<Entity, T>>(
+    attributeName: T,
+    value: K
+  ) {
+    this._expressionAttributeNames[`#${attributeName}`] = attributeName;
+    this._expressionAttributeValues[`:${attributeName}`] = value;
+    this._updateExpressionSet.SET[attributeName] =
+      `#${attributeName} = if_not_exists(#${attributeName}, :${attributeName})`;
+    return this;
+  }
+
   addToValue<T extends Prop<Entity>, K extends PropType<Entity, T>>(
     attributeName: T,
     value: K

utils/entity-update-command-builder/src/template-update-builder.ts

@@ -49,6 +49,11 @@ export class TemplateUpdateBuilder extends EntityUpdateBuilder<DatabaseTemplate>
     return this;
   }
 
+  initialiseSupplierReferences() {
+    this.updateBuilder.setValueIfNotExists('supplierReferences', {});
+    return this;
+  }
+
   setSupplierReference(supplier: string, supplierReference: string) {
     this.updateBuilder.setValueInMap(
       'supplierReferences',