Skip to content

Commit e0f612c

Browse files
committed
CCM-10004: merge
2 parents 25f133a + eff90d4 commit e0f612c

File tree

73 files changed

+2421
-236
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+2421
-236
lines changed

.github/workflows/pr_closed.yaml

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,63 @@ jobs:
5454
targetAccountGroup: "nhs-notify-template-management-dev"
5555
targetComponent: ${{ matrix.component }}
5656
terraformAction: "apply"
57+
58+
check-event-schemas-version-change:
59+
name: Check for event schemas package version change
60+
needs: check-merge-or-workflow-dispatch
61+
if: needs.check-merge-or-workflow-dispatch.outputs.deploy == 'true'
62+
outputs:
63+
version_changed: ${{ steps.check-version.outputs.version_changed }}
64+
runs-on: ubuntu-latest
65+
permissions:
66+
contents: read
67+
packages: read
68+
steps:
69+
- name: Checkout code
70+
uses: actions/[email protected]
71+
72+
- name: Use Node.js 20
73+
uses: actions/setup-node@v4
74+
with:
75+
node-version: '20.18.2'
76+
registry-url: 'https://npm.pkg.github.com'
77+
78+
- name: check if local version differs from latest published version
79+
id: check-version
80+
run: |
81+
published_version=$(npm view @nhsdigital/nhs-notify-event-schemas-template-management --json 2>/dev/null | jq -r '.["dist-tags"].latest')
82+
local_version=$(cat packages/event-schemas/package.json | jq -r '.version')
83+
if [[ $local_version = $published_version ]]; then
84+
echo "Local version is the same as the latest published version - skipping publish"
85+
echo "version_changed=false" >> $GITHUB_OUTPUT
86+
else
87+
echo "Local version is different to the latest published version - publishing new version"
88+
echo "version_changed=true" >> $GITHUB_OUTPUT
89+
fi
90+
91+
publish-event-schemas:
92+
name: Publish event schemas package to GitHub package registry
93+
needs: check-event-schemas-version-change
94+
if: needs.check-event-schemas-version-change.outputs.version_changed == 'true'
95+
runs-on: ubuntu-latest
96+
permissions:
97+
contents: read
98+
packages: write
99+
100+
steps:
101+
- name: Checkout code
102+
uses: actions/[email protected]
103+
104+
- name: Use Node.js 20
105+
uses: actions/setup-node@v4
106+
with:
107+
node-version: '20.18.2'
108+
registry-url: 'https://npm.pkg.github.com'
109+
110+
- name: Install dependencies
111+
run: npm ci
112+
113+
- name: Publish to GitHub Packages
114+
run: npm publish --workspace packages/event-schemas
115+
env:
116+
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ acceptance-test-report
3535
# production
3636
/build
3737
dist
38+
*.tgz
3839

3940
# misc
4041
.DS_Store

.vscode/settings.json

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
{
2+
"editor.codeActionsOnSave": {
3+
"source.fixAll.eslint": "explicit"
4+
},
5+
"eslint.codeActionsOnSave.mode": "problems",
6+
"eslint.useFlatConfig": false,
27
"markdownlint.config": {
38
"MD013": false,
49
"MD024": {
510
"siblings_only": true
611
},
712
"MD033": false
8-
},
9-
"editor.codeActionsOnSave": {
10-
"source.fixAll.eslint": "explicit"
11-
},
12-
"eslint.codeActionsOnSave.mode": "problems"
13+
}
1314
}

data-migration/user-transfer/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"@types/node": "^20.17.32",
1313
"jest": "^29.7.0",
1414
"jest-html-reporter": "^3.10.2",
15-
"jest-mock-extended": "^4.0.0-beta1",
15+
"jest-mock-extended": "^3.0.7",
1616
"typescript": "^5.8.2"
1717
},
1818
"main": "src/handler.ts",

frontend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"react": "^19.0.0",
2121
"react-dom": "^19.0.0",
2222
"react-idle-timer": "^5.7.2",
23-
"zod": "^4.0.5"
23+
"zod": "^4.0.17"
2424
},
2525
"devDependencies": {
2626
"@testing-library/jest-dom": "^6.6.3",

infrastructure/terraform/modules/backend-api/pipes_pipe_template_table_events.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
resource "aws_pipes_pipe" "template_table_events" {
2+
depends_on = [module.sqs_template_table_events_pipe_dlq]
3+
24
name = "${local.csi}-template-table-events"
35
role_arn = aws_iam_role.pipe_template_table_events.arn
46
source = aws_dynamodb_table.templates.stream_arn

lambdas/authorizer/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"jwks-rsa": "^3.2.0",
66
"jwt-decode": "^4.0.0",
77
"nhs-notify-web-template-management-utils": "^0.0.1",
8-
"zod": "^4.0.5"
8+
"zod": "^4.0.17"
99
},
1010
"devDependencies": {
1111
"@swc/core": "^1.11.13",

lambdas/backend-api/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"parse-multipart-data": "^1.5.0",
1919
"pdfjs-dist": "5.1.91",
2020
"winston": "^3.17.0",
21-
"zod": "^4.0.5"
21+
"zod": "^4.0.17"
2222
},
2323
"devDependencies": {
2424
"@swc/core": "^1.11.13",

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { File } from 'node:buffer';
12
import { randomUUID } from 'node:crypto';
23
import { mock } from 'jest-mock-extended';
34
import type {

lambdas/backend-api/src/__tests__/templates/domain/template-pdf.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ test('has the given key attributes', () => {
1010
templateId: 'template-id',
1111
clientId: 'template-owner',
1212
},
13-
Buffer.from('')
13+
Uint8Array.from('')
1414
);
1515

1616
expect(pdf.templateId).toBe('template-id');
@@ -26,7 +26,7 @@ test('parse with no custom personalisation', async () => {
2626
templateId: 'template-id',
2727
clientId: 'template-owner',
2828
},
29-
file
29+
new Uint8Array(file)
3030
);
3131
await pdf.parse();
3232

@@ -76,7 +76,7 @@ test('parse with custom personalisation', async () => {
7676
templateId: 'template-id',
7777
clientId: 'template-owner',
7878
},
79-
file
79+
new Uint8Array(file)
8080
);
8181
await pdf.parse();
8282

0 commit comments

Comments
 (0)