CCM-10424 Fix teardown step and use replace instead of push for redirects

Author: nicki-nhs

frontend/src/__tests__/app/create-letter-template/page.test.tsx

@@ -74,7 +74,7 @@ describe('CreateLetterTemplatePage', () => {
 
     expect(mockRedirect).toHaveBeenCalledWith(
       '/create-letter-template/client-id-and-campaign-id-required',
-      RedirectType.push
+      RedirectType.replace
     );
   });
 
@@ -97,7 +97,7 @@ describe('CreateLetterTemplatePage', () => {
 
     expect(mockRedirect).toHaveBeenCalledWith(
       '/create-letter-template/client-id-and-campaign-id-required',
-      RedirectType.push
+      RedirectType.replace
     );
   });
 });

frontend/src/app/create-letter-template/page.tsx

@@ -18,7 +18,7 @@ const CreateLetterTemplatePage = async () => {
   if (!accessToken || !clientId)
     return redirect(
       '/create-letter-template/client-id-and-campaign-id-required',
-      RedirectType.push
+      RedirectType.replace
     );
 
   const clientConfiguration = await fetchClient(accessToken);
@@ -28,7 +28,7 @@ const CreateLetterTemplatePage = async () => {
   if (!clientConfiguration || clientConfiguration.error || !campaignId)
     return redirect(
       '/create-letter-template/client-id-and-campaign-id-required',
-      RedirectType.push
+      RedirectType.replace
     );
 
   return <LetterTemplateForm initialState={initialState} />;

tests/test-team/helpers/client/client-helper.ts

@@ -80,11 +80,13 @@ export class ClientConfigurationHelper {
   }
 
   async teardown(ids: string[]) {
-    await this.ssmClient.send(
-      new DeleteParametersCommand({
-        Names: ids.map((id) => this.ssmKey(id)),
-      })
-    );
+    if (ids.length) {
+      await this.ssmClient.send(
+        new DeleteParametersCommand({
+          Names: ids.map((id) => this.ssmKey(id)),
+        })
+      );
+    }
   }
 
   private ssmKey(clientId: string) {