CCM-11492 Update test function

Author: nicki-nhs

tests/test-team/pages/template-mgmt-base-page-dynamic.ts

@@ -19,12 +19,14 @@ export abstract class TemplateMgmtBasePageDynamic extends TemplateMgmtBasePage {
     await this.navigateTo(`/${appUrlSegment}/${pageUrlSegment}/${idParameter}`);
   }
 
-  static getIdFromUrl(
-    fullUrl: string,
-    pageSegment: string
-  ): string | undefined {
-    // eslint-disable-next-line security/detect-non-literal-regexp
-    const match = fullUrl.match(new RegExp(`${pageSegment}/([^#/?]+)`));
+  getIdFromUrl(): string | undefined {
+    const { pageUrlSegment } = this
+      .constructor as typeof TemplateMgmtBasePageDynamic;
+
+    const match = this.page
+      .url()
+      // eslint-disable-next-line security/detect-non-literal-regexp
+      .match(new RegExp(`${pageUrlSegment}/([^#/?]+)`));
     const id = match ? match[1] : undefined;
     return id;
   }

tests/test-team/template-mgmt-routing-component-tests/choose-templates.routing-component.spec.ts

@@ -266,10 +266,7 @@ test.describe('Routing - Choose Templates page', () => {
       /\/templates\/message-plans\/choose-templates\//
     );
 
-    const routingConfigId = TemplateMgmtBasePageDynamic.getIdFromUrl(
-      page.url(),
-      'choose-templates'
-    );
+    const routingConfigId = chooseTemplatesPage.getIdFromUrl();
 
     await test.step('app channel with no template has only choose link', async () => {
       await expect(chooseTemplatesPage.nhsApp.templateName).toBeHidden();