CCM-9051: dedupe more iam policy statements

Author: alexnuttall

infrastructure/terraform/modules/backend-api/module_lambda_process_proof.tf

@@ -64,7 +64,7 @@ data "aws_iam_policy_document" "process_proof" {
   }
 
   statement {
-    sid    = "AllowKMSAccessDynamoDB"
+    sid    = "AllowKMSAccess"
     effect = "Allow"
 
     actions = [
@@ -80,20 +80,6 @@ data "aws_iam_policy_document" "process_proof" {
     ]
   }
 
-  statement {
-    sid    = "AllowKMSAccessSQSDLQ"
-    effect = "Allow"
-
-    actions = [
-      "kms:Decrypt",
-      "kms:GenerateDataKey",
-    ]
-
-    resources = [
-      var.kms_key_arn,
-    ]
-  }
-
   statement {
     sid    = "AllowS3QuarantineGetObject"
     effect = "Allow"

infrastructure/terraform/modules/backend-api/module_lambda_request_proof.tf

@@ -62,7 +62,7 @@ data "aws_iam_policy_document" "request_proof_lambda_policy" {
   }
 
   statement {
-    sid    = "AllowDdbKMSAccess"
+    sid    = "AllowKMSAccess"
     effect = "Allow"
 
     actions = [
@@ -77,18 +77,4 @@ data "aws_iam_policy_document" "request_proof_lambda_policy" {
       var.kms_key_arn
     ]
   }
-
-  statement {
-    sid    = "AllowSqsKMSAccess"
-    effect = "Allow"
-
-    actions = [
-      "kms:Decrypt",
-      "kms:GenerateDataKey",
-    ]
-
-    resources = [
-      var.kms_key_arn,
-    ]
-  }
 }

infrastructure/terraform/modules/backend-api/module_lambda_set_letter_file_virus_scan_status_for_upload.tf

@@ -67,18 +67,4 @@ data "aws_iam_policy_document" "set_file_virus_scan_status_for_upload" {
       var.kms_key_arn
     ]
   }
-
-  statement {
-    sid    = "AllowKMSAccessSQSDLQ"
-    effect = "Allow"
-
-    actions = [
-      "kms:Decrypt",
-      "kms:GenerateDataKey",
-    ]
-
-    resources = [
-      var.kms_key_arn,
-    ]
-  }
 }