CCM-8585: unit test

Author: alexnuttall

lambdas/backend-api/src/templates/app/template-client.ts

@@ -10,7 +10,7 @@ import {
   isTemplateDtoValid,
   LetterFiles,
   TemplateStatus,
-  $CreateNonLetter,
+  $CreateNonLetterSchema,
   $UpdateNonLetter,
 } from 'nhs-notify-backend-client';
 import {
@@ -36,7 +36,7 @@ export class TemplateClient implements ITemplateClient {
   ): Promise<Result<TemplateDto>> {
     const log = logger.child({ template });
 
-    const validationResult = await validate($CreateNonLetter, template);
+    const validationResult = await validate($CreateNonLetterSchema, template);
 
     if (validationResult.error) {
       log.error('Request failed validation', {

lambdas/backend-client/src/__tests__/schemas/template-schema.test.ts

@@ -1,4 +1,5 @@
 import {
+  $CreateNonLetterSchema,
   CreateTemplate,
   isCreateTemplateValid,
   isTemplateDtoValid,
@@ -150,6 +151,27 @@ describe('Template schemas', () => {
     }
   );
 
+  test('$CreateNonLetterSchema should fail when input is a letter', () => {
+    const letter: CreateTemplate = {
+      templateType: 'LETTER',
+      letterType: 'q1',
+      language: 'ar',
+      name: 'letter',
+    };
+
+    const result = $CreateNonLetterSchema.safeParse(letter);
+
+    expect(result.error?.flatten()).toEqual(
+      expect.objectContaining({
+        fieldErrors: {
+          templateType: [
+            "Invalid discriminator value. Expected 'NHS_APP' | 'EMAIL' | 'SMS'",
+          ],
+        },
+      })
+    );
+  });
+
   test('$EmailTemplateFields - should fail validation, when no subject', async () => {
     const result = $CreateTemplateSchema.safeParse({
       name: 'Test Template',
@@ -218,13 +240,6 @@ describe('Template schemas', () => {
         templateType: 'LETTER',
         letterType: 'x0',
         language: 'en',
-        files: {
-          pdfTemplate: {
-            fileName: 'template.pdf',
-            currentVersion: '123',
-            virusScanStatus: 'FAILED',
-          },
-        },
       },
     ])('should pass validation %p', async (template) => {
       const result = $CreateTemplateSchema.safeParse(template);

lambdas/backend-client/src/schemas/template-schema.ts

@@ -141,7 +141,7 @@ export const $LetterPropertiesWithType = $LetterProperties.merge(
   z.object({ templateType: z.literal('LETTER') })
 );
 
-export const $CreateNonLetter = schemaFor<
+export const $CreateNonLetterSchema = schemaFor<
   Exclude<CreateTemplate, { templateType: 'LETTER' }>,
   Exclude<ValidatedCreateTemplate, { templateType: 'LETTER' }>
 >()(