comments

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/infra/template-repository.test.ts

@@ -1628,7 +1628,7 @@ describe('templateRepository', () => {
     });
   });
 
-  describe('getUserTemplateOwner', () => {
+  describe('assertTemplateOwnership', () => {
     test('gets owner field based on templateId', async () => {
       const { templateRepository, mocks } = setup();
 
@@ -1640,7 +1640,7 @@ describe('templateRepository', () => {
         ],
       });
 
-      const owner = await templateRepository.getUserTemplateOwner(
+      const owner = await templateRepository.assertTemplateOwnership(
         user,
         templateId
       );
@@ -1666,7 +1666,7 @@ describe('templateRepository', () => {
         ],
       });
 
-      const owner = await templateRepository.getUserTemplateOwner(
+      const owner = await templateRepository.assertTemplateOwnership(
         user,
         'template-id'
       );
@@ -1689,7 +1689,7 @@ describe('templateRepository', () => {
       });
 
       await expect(
-        templateRepository.getUserTemplateOwner(user, 'template-id')
+        templateRepository.assertTemplateOwnership(user, 'template-id')
       ).rejects.toThrow('Unexpectedly found more than one template owner');
     });
   });

lambdas/backend-api/src/templates/infra/template-repository.ts

@@ -181,7 +181,7 @@ export class TemplateRepository {
     ];
 
     try {
-      const owner = await this.getUserTemplateOwner(user, templateId);
+      const owner = await this.assertTemplateOwnership(user, templateId);
 
       if (!owner) return failure(ErrorCase.NOT_FOUND, `Template not found`);
 
@@ -229,7 +229,7 @@ export class TemplateRepository {
     };
 
     try {
-      const owner = await this.getUserTemplateOwner(user, templateId);
+      const owner = await this.assertTemplateOwnership(user, templateId);
 
       if (!owner) return failure(ErrorCase.NOT_FOUND, `Template not found`);
 
@@ -266,7 +266,7 @@ export class TemplateRepository {
     ];
 
     try {
-      const owner = await this.getUserTemplateOwner(user, templateId);
+      const owner = await this.assertTemplateOwnership(user, templateId);
 
       if (!owner) return failure(ErrorCase.NOT_FOUND, `Template not found`);
 
@@ -306,7 +306,7 @@ export class TemplateRepository {
     };
 
     try {
-      const owner = await this.getUserTemplateOwner(user, templateId);
+      const owner = await this.assertTemplateOwnership(user, templateId);
 
       if (!owner) return failure(ErrorCase.NOT_FOUND, `Template not found`);
 
@@ -740,7 +740,7 @@ export class TemplateRepository {
     }
   }
 
-  async getUserTemplateOwner(
+  async assertTemplateOwnership(
     user: User,
     templateId: string
   ): Promise<string | undefined> {

lambdas/backend-client/src/schemas/client.ts

@@ -5,7 +5,6 @@ import { ClientConfiguration, ClientFeatures } from '../types/generated';
 const $ClientFeatures = schemaFor<ClientFeatures>()(
   z.object({
     proofing: z.boolean(),
-    clientOwnership: z.boolean().optional(),
   })
 );