remove unnecessary attr_exists checks on updates

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/infra/routing-config-repository/repository.test.ts

@@ -237,10 +237,8 @@ describe('RoutingConfigRepository', () => {
       expect(result).toEqual({ data: completed });
 
       expect(mocks.dynamo).toHaveReceivedCommandWith(UpdateCommand, {
-        ConditionExpression:
-          '#status = :condition_1_status AND attribute_exists (#id)',
+        ConditionExpression: '#status = :condition_1_status',
         ExpressionAttributeNames: {
-          '#id': 'id',
           '#status': 'status',
           '#updatedAt': 'updatedAt',
           '#updatedBy': 'updatedBy',
@@ -411,13 +409,11 @@ describe('RoutingConfigRepository', () => {
       expect(result).toEqual({ data: updated });
 
       expect(mocks.dynamo).toHaveReceivedCommandWith(UpdateCommand, {
-        ConditionExpression:
-          '#status = :condition_1_status AND attribute_exists (#id)',
+        ConditionExpression: '#status = :condition_1_status',
         ExpressionAttributeNames: {
           '#campaignId': 'campaignId',
           '#cascade': 'cascade',
           '#cascadeGroupOverrides': 'cascadeGroupOverrides',
-          '#id': 'id',
           '#name': 'name',
           '#status': 'status',
           '#updatedAt': 'updatedAt',
@@ -461,13 +457,11 @@ describe('RoutingConfigRepository', () => {
       expect(result).toEqual({ data: routingConfig });
 
       expect(mocks.dynamo).toHaveReceivedCommandWith(UpdateCommand, {
-        ConditionExpression:
-          '#status = :condition_1_status AND attribute_exists (#id)',
+        ConditionExpression: '#status = :condition_1_status',
         ExpressionAttributeNames: {
           '#campaignId': 'campaignId',
           '#cascade': 'cascade',
           '#cascadeGroupOverrides': 'cascadeGroupOverrides',
-          '#id': 'id',
           '#name': 'name',
           '#status': 'status',
           '#updatedAt': 'updatedAt',

lambdas/backend-api/src/__tests__/templates/infra/template-repository.test.ts

@@ -2084,9 +2084,8 @@ describe('templateRepository', () => {
 
       expect(mocks.ddbDocClient).toHaveReceivedCommandWith(UpdateCommand, {
         ConditionExpression:
-          '#templateStatus = :condition_1_templateStatus AND #templateType = :condition_2_templateType AND #clientId = :condition_3_clientId AND attribute_exists (#id) AND #proofingEnabled = :condition_5_proofingEnabled',
+          '#templateStatus = :condition_1_templateStatus AND #templateType = :condition_2_templateType AND #clientId = :condition_3_clientId AND #proofingEnabled = :condition_4_proofingEnabled',
         ExpressionAttributeNames: {
-          '#id': 'id',
           '#clientId': 'clientId',
           '#templateStatus': 'templateStatus',
           '#templateType': 'templateType',
@@ -2099,7 +2098,7 @@ describe('templateRepository', () => {
           ':condition_1_templateStatus': 'PENDING_PROOF_REQUEST',
           ':condition_2_templateType': 'LETTER',
           ':condition_3_clientId': clientId,
-          ':condition_5_proofingEnabled': true,
+          ':condition_4_proofingEnabled': true,
           ':templateStatus': 'WAITING_FOR_PROOF',
           ':updatedAt': '2024-12-27T00:00:00.000Z',
           ':updatedBy': userId,

lambdas/backend-api/src/templates/infra/routing-config-repository/repository.ts

@@ -88,7 +88,6 @@ export class RoutingConfigRepository {
       .setName(name)
       .setCascadeGroupOverrides(cascadeGroupOverrides)
       .expectedStatus('DRAFT')
-      .expectRoutingConfigExists()
       .build();
 
     try {
@@ -122,7 +121,6 @@ export class RoutingConfigRepository {
     )
       .setStatus('COMPLETED')
       .expectedStatus('DRAFT')
-      .expectRoutingConfigExists()
       .setUpdatedByUserAt(user.userId)
       .build();
 

lambdas/backend-api/src/templates/infra/template-repository.ts

@@ -663,7 +663,6 @@ export class TemplateRepository {
         .initialiseSupplierReferences()
         .expectedTemplateType('LETTER')
         .expectedClientId(user.clientId)
-        .expectTemplateExists()
         .expectProofingEnabled()
         .build();