CCM-7908 case fixing tfvars

Author: aidenvaines-cgi

infrastructure/terraform/components/app/ssm_parameter_amplify_password.tf

@@ -1,13 +1,15 @@
 resource "aws_ssm_parameter" "amplify_password" {
   count = var.enable_amplify_basic_auth ? 1 : 0
 
-  name  = "/${local.csi}/amplify_password"
+  name        = "/${local.csi}/amplify_password"
+  description = "The Basic Auth password used for the amplify app. This parameter is sourced from Github Environment variables"
+
   type  = "String"
-  value = var.AMPLIFY_BASIC_AUTH_SECRET != "unset" ?  var.AMPLIFY_BASIC_AUTH_SECRET : random_password.password[0].result
+  value = var.amplify_basic_auth_secret != "unset" ?  var.amplify_basic_auth_secret : random_password.password[0].result
 }
 
 resource "random_password" "password" {
-  count = var.enable_amplify_basic_auth && var.AMPLIFY_BASIC_AUTH_SECRET == "unset" ? 1 : 0
+  count = var.enable_amplify_basic_auth && var.amplify_basic_auth_secret == "unset" ? 1 : 0
 
   length  = 16
   special = true

infrastructure/terraform/components/app/variables.tf

@@ -94,7 +94,7 @@ variable "enable_amplify_basic_auth" {
 }
 
 # Github Environments only handles uppercase envvars
-variable "AMPLIFY_BASIC_AUTH_SECRET" {
+variable "amplify_basic_auth_secret" {
   type        = string
   description = "Secret key/password to use for Amplify Basic Auth - This is entended to be read from CI variables and not commited to any codebase"
   default     = "unset"