CCM--11496: move form action to correct file

Author: harrim91

frontend/src/__tests__/app/message-plans/create-message-plan/server-action.test.ts

@@ -8,14 +8,14 @@ import type {
 import type { MessageOrder } from 'nhs-notify-web-template-management-utils';
 import { createMessagePlanServerAction } from '@app/message-plans/create-message-plan/server-action';
 import { NextRedirectError } from '@testhelpers/next-redirect';
-import { createRoutingConfig } from '@utils/form-actions';
+import { createRoutingConfig } from '@utils/message-plans';
 
 jest.mock('next/navigation');
 jest.mocked(redirect).mockImplementation((url, type) => {
   throw new NextRedirectError(url, type);
 });
 
-jest.mock('@utils/form-actions');
+jest.mock('@utils/message-plans');
 jest.mocked(createRoutingConfig).mockResolvedValue(
   mock<RoutingConfig>({
     id: 'mock-routing-config-id',

frontend/src/__tests__/utils/form-actions.test.ts

@@ -15,18 +15,12 @@ import {
   setTemplateToDeleted,
   setTemplateToSubmitted,
   requestTemplateProof,
-  createRoutingConfig,
-  submitRoutingConfig,
 } from '@utils/form-actions';
 import { getSessionServer } from '@utils/amplify-utils';
-import { RoutingConfig, TemplateDto } from 'nhs-notify-backend-client';
+import { TemplateDto } from 'nhs-notify-backend-client';
 import { templateApiClient } from 'nhs-notify-backend-client/src/template-api-client';
-import { routingConfigurationApiClient } from 'nhs-notify-backend-client/src/routing-config-api-client';
-import { randomUUID } from 'node:crypto';
-import { mock } from 'jest-mock-extended';
 
 const mockedTemplateClient = jest.mocked(templateApiClient);
-const mockedRoutingConfigClient = jest.mocked(routingConfigurationApiClient);
 const authIdTokenServerMock = jest.mocked(getSessionServer);
 
 jest.mock('@utils/amplify-utils');
@@ -686,163 +680,4 @@ describe('form-actions', () => {
       );
     });
   });
-
-  describe('createRoutingConfig', () => {
-    test('creates a routing config', async () => {
-      const now = new Date();
-      const id = randomUUID();
-
-      mockedRoutingConfigClient.create.mockImplementationOnce(
-        async (input) => ({
-          data: {
-            ...input,
-            id,
-            clientId: 'client1',
-            createdAt: now.toISOString(),
-            status: 'DRAFT',
-            updatedAt: now.toISOString(),
-          },
-        })
-      );
-
-      const result = await createRoutingConfig({
-        name: 'My Routing Config',
-        campaignId: 'my-campaign-id',
-        cascade: [
-          {
-            channelType: 'primary',
-            channel: 'NHSAPP',
-            cascadeGroups: ['standard'],
-            defaultTemplateId: null,
-          },
-        ],
-        cascadeGroupOverrides: [{ name: 'standard' }],
-      });
-
-      expect(mockedRoutingConfigClient.create).toHaveBeenCalledWith(
-        {
-          name: 'My Routing Config',
-          campaignId: 'my-campaign-id',
-          cascade: [
-            {
-              channelType: 'primary',
-              channel: 'NHSAPP',
-              cascadeGroups: ['standard'],
-              defaultTemplateId: null,
-            },
-          ],
-          cascadeGroupOverrides: [{ name: 'standard' }],
-        },
-        'token'
-      );
-
-      expect(result).toEqual({
-        id,
-        clientId: 'client1',
-        createdAt: now.toISOString(),
-        status: 'DRAFT',
-        updatedAt: now.toISOString(),
-        name: 'My Routing Config',
-        campaignId: 'my-campaign-id',
-        cascade: [
-          {
-            channelType: 'primary',
-            channel: 'NHSAPP',
-            cascadeGroups: ['standard'],
-            defaultTemplateId: null,
-          },
-        ],
-        cascadeGroupOverrides: [{ name: 'standard' }],
-      });
-    });
-
-    test('errors when no token', async () => {
-      authIdTokenServerMock.mockResolvedValueOnce({});
-
-      await expect(
-        createRoutingConfig({
-          name: 'My Routing Config',
-          campaignId: 'my-campaign-id',
-          cascade: [
-            {
-              channelType: 'primary',
-              channel: 'NHSAPP',
-              cascadeGroups: ['standard'],
-              defaultTemplateId: null,
-            },
-          ],
-          cascadeGroupOverrides: [{ name: 'standard' }],
-        })
-      ).rejects.toThrow('Failed to get access token');
-
-      expect(mockedRoutingConfigClient.create).not.toHaveBeenCalled();
-    });
-
-    test('errors when request fails', async () => {
-      mockedRoutingConfigClient.create.mockResolvedValueOnce({
-        error: {
-          errorMeta: {
-            code: 400,
-            description: 'Bad request',
-          },
-        },
-      });
-
-      await expect(
-        createRoutingConfig({
-          name: 'My Routing Config',
-          campaignId: 'my-campaign-id',
-          cascade: [
-            {
-              channelType: 'primary',
-              channel: 'NHSAPP',
-              cascadeGroups: ['standard'],
-              defaultTemplateId: null,
-            },
-          ],
-          cascadeGroupOverrides: [{ name: 'standard' }],
-        })
-      ).rejects.toThrow('Failed to create message plan');
-    });
-  });
-
-  describe('submitRoutingConfig', () => {
-    it('submits the routing config', async () => {
-      mockedRoutingConfigClient.submit.mockResolvedValueOnce({
-        data: mock<RoutingConfig>(),
-      });
-
-      await submitRoutingConfig('id');
-
-      expect(mockedRoutingConfigClient.submit).toHaveBeenCalledWith(
-        'id',
-        'token'
-      );
-    });
-
-    it('throws if there is no token', async () => {
-      authIdTokenServerMock.mockResolvedValueOnce({});
-
-      await expect(() => submitRoutingConfig('id')).rejects.toThrow(
-        'Failed to get access token'
-      );
-
-      expect(mockedRoutingConfigClient.submit).not.toHaveBeenCalled();
-    });
-
-    it('throws if the api request returns an error', async () => {
-      mockedRoutingConfigClient.submit.mockResolvedValueOnce({
-        error: {
-          errorMeta: {
-            code: 400,
-            description: 'Bad request',
-          },
-        },
-      });
-
-      await expect(() => submitRoutingConfig('id')).rejects.toThrow(
-        'Failed to submit message plan'
-      );
-    });
-  });
 });

frontend/src/__tests__/utils/message-plans.test.ts

@@ -1,3 +1,5 @@
+import { randomUUID } from 'node:crypto';
+import { mock } from 'jest-mock-extended';
 import {
   getRoutingConfig,
   updateRoutingConfig,
@@ -6,6 +8,7 @@ import {
   getRoutingConfigs,
   countRoutingConfigs,
   createRoutingConfig,
+  submitRoutingConfig,
 } from '@utils/message-plans';
 import { getSessionServer } from '@utils/amplify-utils';
 import { routingConfigurationApiClient } from 'nhs-notify-backend-client/src/routing-config-api-client';
@@ -24,7 +27,6 @@ import {
   NHS_APP_TEMPLATE,
   SMS_TEMPLATE,
 } from '@testhelpers/helpers';
-import { randomUUID } from 'node:crypto';
 
 jest.mock('@utils/amplify-utils');
 jest.mock('nhs-notify-backend-client/src/routing-config-api-client');
@@ -675,4 +677,44 @@ describe('Message plans actions', () => {
       ).rejects.toThrow('Failed to create message plan');
     });
   });
+
+  describe('submitRoutingConfig', () => {
+    it('submits the routing config', async () => {
+      routingConfigApiMock.submit.mockResolvedValueOnce({
+        data: mock<RoutingConfig>(),
+      });
+
+      await submitRoutingConfig('id');
+
+      expect(routingConfigApiMock.submit).toHaveBeenCalledWith(
+        'id',
+        'mock-token'
+      );
+    });
+
+    it('throws if there is no token', async () => {
+      getSessionServerMock.mockResolvedValueOnce({});
+
+      await expect(() => submitRoutingConfig('id')).rejects.toThrow(
+        'Failed to get access token'
+      );
+
+      expect(routingConfigApiMock.submit).not.toHaveBeenCalled();
+    });
+
+    it('throws if the api request returns an error', async () => {
+      routingConfigApiMock.submit.mockResolvedValueOnce({
+        error: {
+          errorMeta: {
+            code: 400,
+            description: 'Bad request',
+          },
+        },
+      });
+
+      await expect(() => submitRoutingConfig('id')).rejects.toThrow(
+        'Failed to submit message plan'
+      );
+    });
+  });
 });

frontend/src/app/message-plans/create-message-plan/server-action.ts

@@ -12,7 +12,7 @@ import {
   type FormState,
   type MessageOrder,
 } from 'nhs-notify-web-template-management-utils';
-import { createRoutingConfig } from '@utils/form-actions';
+import { createRoutingConfig } from '@utils/message-plans';
 
 const $MessagePlanFormData = z.object({
   campaignId: z.string().min(1, { error: 'Select a campaign' }),

frontend/src/utils/form-actions.ts

@@ -4,13 +4,11 @@ import { getSessionServer } from '@utils/amplify-utils';
 import {
   CreateUpdateTemplate,
   isTemplateDtoValid,
-  RoutingConfig,
   TemplateDto,
   ValidatedTemplateDto,
 } from 'nhs-notify-backend-client';
 import { logger } from 'nhs-notify-web-template-management-utils/logger';
 import { templateApiClient } from 'nhs-notify-backend-client/src/template-api-client';
-import { routingConfigurationApiClient } from 'nhs-notify-backend-client/src/routing-config-api-client';
 import { sortAscByUpdatedAt } from './sort';
 
 export async function createTemplate(
@@ -190,43 +188,3 @@ export async function getTemplates(): Promise<TemplateDto[]> {
 
   return sortAscByUpdatedAt(sortedData);
 }
-
-export async function createRoutingConfig(
-  routingConfig: Pick<
-    RoutingConfig,
-    'name' | 'campaignId' | 'cascade' | 'cascadeGroupOverrides'
-  >
-): Promise<RoutingConfig> {
-  const { accessToken } = await getSessionServer();
-
-  if (!accessToken) {
-    throw new Error('Failed to get access token');
-  }
-
-  const { data, error } = await routingConfigurationApiClient.create(
-    routingConfig,
-    accessToken
-  );
-
-  if (error) {
-    logger.error('Failed to create message plan', error);
-    throw new Error('Failed to create message plan');
-  }
-
-  return data;
-}
-
-export async function submitRoutingConfig(id: string) {
-  const { accessToken } = await getSessionServer();
-
-  if (!accessToken) {
-    throw new Error('Failed to get access token');
-  }
-
-  const { error } = await routingConfigurationApiClient.submit(id, accessToken);
-
-  if (error) {
-    logger.error('Failed to submit message plan', error);
-    throw new Error('Failed to submit message plan');
-  }
-}

frontend/src/utils/message-plans.ts

@@ -188,3 +188,18 @@ export async function getTemplatesByIds(
 
   return templates;
 }
+
+export async function submitRoutingConfig(id: string) {
+  const { accessToken } = await getSessionServer();
+
+  if (!accessToken) {
+    throw new Error('Failed to get access token');
+  }
+
+  const { error } = await routingConfigurationApiClient.submit(id, accessToken);
+
+  if (error) {
+    logger.error('Failed to submit message plan', error);
+    throw new Error('Failed to submit message plan');
+  }
+}