CCM-8585: api client tests

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -953,7 +953,7 @@ describe('templateClient', () => {
         false,
         mocks.templateRepository,
         mocks.letterUploadRepository,
-        mocks.generateId
+        mocks.generateVersionId
       );
 
       mocks.templateRepository.get.mockResolvedValueOnce({
@@ -1047,7 +1047,7 @@ describe('templateClient', () => {
         false,
         mocks.templateRepository,
         mocks.letterUploadRepository,
-        mocks.generateId
+        mocks.generateVersionId
       );
 
       const template: TemplateDto = {

lambdas/backend-api/src/__tests__/templates/infra/letter-upload-repository.test.ts

@@ -1,21 +1,16 @@
 import { PutObjectCommand, S3Client } from '@aws-sdk/client-s3';
 import { LetterUploadRepository } from '@backend-api/templates/infra/letter-upload-repository';
-import type { Logger } from '@backend-api/utils/logger';
 import 'aws-sdk-client-mock-jest';
 import { mockClient } from 'aws-sdk-client-mock';
-import { mock } from 'jest-mock-extended';
 
 const quarantineBucketName = 'q_bucket';
 
 const setup = () => {
   const s3Client = mockClient(S3Client);
 
-  const logger = mock<Logger>();
-
   const letterUploadRepository = new LetterUploadRepository(
     s3Client as unknown as S3Client,
-    quarantineBucketName,
-    logger
+    quarantineBucketName
   );
 
   return { letterUploadRepository, mocks: { s3Client } };

lambdas/backend-api/src/templates/container.ts

@@ -5,7 +5,6 @@ import { DynamoDBClient } from '@aws-sdk/client-dynamodb';
 import { S3Client } from '@aws-sdk/client-s3';
 import { LetterUploadRepository } from './infra/letter-upload-repository';
 import { randomUUID } from 'node:crypto';
-import { logger } from '../logger';
 
 export function createContainer() {
   const enableLetters = process.env.ENABLE_LETTERS_BACKEND === 'true';
@@ -50,5 +49,5 @@ export function createContainer() {
     generateId
   );
 
-  return { templateClient, logger };
+  return { templateClient };
 }

lambdas/backend-api/src/templates/infra/letter-upload-repository.ts

@@ -1,13 +1,11 @@
 import { ErrorCase } from 'nhs-notify-backend-client';
 import { ApplicationResult, failure, success } from '../../utils';
 import { PutObjectCommand, S3Client } from '@aws-sdk/client-s3';
-import type { Logger } from '@backend-api/utils/logger';
 
 export class LetterUploadRepository {
   constructor(
     private readonly client: S3Client,
-    private readonly bucketName: string,
-    private readonly logger: Logger
+    private readonly bucketName: string
   ) {}
 
   async upload(

lambdas/backend-client/src/__tests__/template-api-client.test.ts

@@ -1,6 +1,6 @@
 import axios from 'axios';
 import MockAdapter from 'axios-mock-adapter';
-import { TemplateApiClient, templateClient } from '../template-api-client';
+import { TemplateApiClient } from '../template-api-client';
 
 const axiosMock = new MockAdapter(axios);
 
@@ -76,6 +76,91 @@ describe('TemplateAPIClient', () => {
     expect(result.error).toBeUndefined();
   });
 
+  test('createLetterTemplate - should return error', async () => {
+    axiosMock.onPost('/v1/letter-template').reply(400, {
+      statusCode: 400,
+      technicalMessage: 'Bad request',
+      details: {
+        message: 'Invalid request',
+      },
+    });
+
+    const client = new TemplateApiClient();
+
+    const result = await client.createLetterTemplate(
+      {
+        name: 'test',
+        templateType: 'LETTER',
+        language: 'de',
+        letterType: 'q1',
+        files: { pdfTemplate: { fileName: 'template.pdf' } },
+      },
+      testToken,
+      new File(['pdf'], 'template.pdf', { type: 'application/pdf' })
+    );
+
+    expect(result.error).toEqual({
+      code: 400,
+      message: 'Bad request',
+      details: {
+        message: 'Invalid request',
+      },
+    });
+
+    expect(result.data).toBeUndefined();
+
+    expect(axiosMock.history.post.length).toBe(1);
+  });
+
+  test('createLetterTemplate - should return template', async () => {
+    axiosMock.onPost('/v1/letter-template').reply(201, {
+      statusCode: 201,
+      template: {
+        id: 'id',
+        name: 'test',
+        templateType: 'LETTER',
+        language: 'de',
+        letterType: 'q1',
+        files: {
+          pdfTemplate: { fileName: 'template.pdf' },
+          testDataCsv: { fileName: 'test-data.csv' },
+        },
+      },
+    });
+
+    const client = new TemplateApiClient();
+
+    const result = await client.createLetterTemplate(
+      {
+        name: 'test',
+        templateType: 'LETTER',
+        language: 'de',
+        letterType: 'q1',
+        files: {
+          pdfTemplate: { fileName: 'template.pdf' },
+          testDataCsv: { fileName: 'test-data.csv' },
+        },
+      },
+      testToken,
+      new File(['pdf'], 'template.pdf', { type: 'application/pdf' }),
+      new File(['pdf'], 'test-data.csv', { type: 'test/csv' })
+    );
+
+    expect(result.data).toEqual({
+      id: 'id',
+      name: 'test',
+      templateType: 'LETTER',
+      language: 'de',
+      letterType: 'q1',
+      files: {
+        pdfTemplate: { fileName: 'template.pdf' },
+        testDataCsv: { fileName: 'test-data.csv' },
+      },
+    });
+
+    expect(result.error).toBeUndefined();
+  });
+
   test('updateTemplate - should return error', async () => {
     axiosMock.onPost('/v1/template/real-id').reply(400, {
       statusCode: 400,

lambdas/backend-client/src/template-api-client.ts

@@ -70,6 +70,7 @@ export class TemplateApiClient implements ITemplateClient {
         error: response.error,
       };
     }
+
     return {
       data: response.data.template,
     };