CCM-12744: fixes

Author: harrim91

lambdas/backend-client/src/routing-config-api-client.ts

@@ -132,21 +132,10 @@ export const routingConfigurationApiClient = {
     routingConfig: UpdateRoutingConfig,
     lockNumber: number
   ): Promise<Result<RoutingConfig>> {
-    if (!uuidSchema.safeParse(id).success) {
-      return {
-        error: {
-          errorMeta: {
-            code: ErrorCase.VALIDATION_FAILED,
-            description: 'Invalid routing configuration ID format',
-            details: { id },
-          },
-          actualError: undefined,
-        },
-      };
-    }
-    const url = `/v1/routing-configuration/${id}` satisfies OpenApiToTemplate<
-      PatchV1RoutingConfigurationByRoutingConfigIdData['url']
-    >;
+    const url =
+      `/v1/routing-configuration/${encodeURIComponent(id)}` satisfies OpenApiToTemplate<
+        PatchV1RoutingConfigurationByRoutingConfigIdData['url']
+      >;
 
     const { data, error } = await catchAxiosError(
       httpClient.patch<RoutingConfigSuccess>(url, routingConfig, {

tests/test-team/pages/template-mgmt-base-page.ts

@@ -205,7 +205,7 @@ export abstract class TemplateMgmtBasePage {
       : this.pathTemplate;
 
     const regexPattern = normalizedPathTemplate.replaceAll(
-      /:([A-Za-z][\dA-z]*)/g,
+      /:([A-Za-z][\dA-Za-z]*)/g,
       '([^/]+)'
     );
 

tests/test-team/template-mgmt-accessibility/routing.accessibility.spec.ts

@@ -113,11 +113,22 @@ test.describe('Routing - Accessibility', () => {
     });
 
     test('Create message plan', async ({ page, analyze }) =>
-      analyze(new RoutingCreateMessagePlanPage(page)));
+      analyze(
+        new RoutingCreateMessagePlanPage(page).setSearchParam(
+          'messageOrder',
+          messageOrder
+        )
+      ));
 
     test('Create message plan - error', async ({ page, analyze }) =>
-      analyze(new RoutingCreateMessagePlanPage(page), {
-        beforeAnalyze: (p) => p.clickSubmit(),
-      }));
+      analyze(
+        new RoutingCreateMessagePlanPage(page).setSearchParam(
+          'messageOrder',
+          messageOrder
+        ),
+        {
+          beforeAnalyze: (p) => p.clickSubmit(),
+        }
+      ));
   });
 });

tests/test-team/template-mgmt-e2e-tests/template-mgmt-letter-full.e2e.spec.ts

@@ -237,6 +237,8 @@ function requestProof(
         expect(entry, JSON.stringify(pdfHrefs[i])).not.toBeNull();
       }
 
+      await page.reload();
+
       await previewTemplatePage.clickContinueButton();
     }).toPass({ timeout: 60_000 });
 

tests/test-team/template-mgmt-event-tests/routing-config.event.spec.ts

@@ -28,17 +28,18 @@ test.describe('Event publishing - Routing Config', () => {
   test('Expect no events', async ({ request }) => {
     const id = randomUUID();
 
+    const messagePlan = RoutingConfigFactory.create(user, { id }).dbEntry;
+
     const start = new Date();
 
-    await storageHelper.seed([
-      RoutingConfigFactory.create(user, { id }).dbEntry,
-    ]);
+    await storageHelper.seed([messagePlan]);
 
     const submittedResponse = await request.patch(
       `${process.env.API_BASE_URL}/v1/routing-configuration/${id}/submit`,
       {
         headers: {
           Authorization: await user.getAccessToken(),
+          'X-Lock-Number': String(messagePlan.lockNumber),
         },
       }
     );