CCM-10980: standardise test reports (#592)

Author: mark-r-bjss

.github/actions/acceptance-tests/action.yaml

@@ -44,30 +44,9 @@ runs:
       run: |
         make test-${{ inputs.testType }}
 
-    - name: Archive ui-e2e test results
-      if: ${{ inputs.testType == 'ui-e2e' }}
+    - name: Archive test results
       uses: actions/upload-artifact@v4
+      if: always()
       with:
-        name: UI E2E test report
-        path: "tests/test-team/playwright-report"
-
-    - name: Archive ui-component test results
-      if: ${{ inputs.testType == 'ui-component' }}
-      uses: actions/upload-artifact@v4
-      with:
-        name: UI-component test report
-        path: "tests/test-team/playwright-report"
-
-    - name: Archive api test results
-      if: ${{ inputs.testType == 'api' }}
-      uses: actions/upload-artifact@v4
-      with:
-        name: API test report
-        path: "tests/test-team/playwright-report"
-
-    - name: Archive accessibility results
-      if: ${{ inputs.testType == 'accessibility' }}
-      uses: actions/upload-artifact@v4
-      with:
-        name: accessibility
-        path: "tests/accessibility/.reports/accessibility"
+        name: ${{ inputs.testType }} - test report
+        path: "tests/acceptance-test-report"

.github/workflows/cicd-1-pull-request.yaml

@@ -6,8 +6,6 @@ on:
   push:
     branches:
       - "**"
-  pull_request:
-    types: [opened, reopened]
 
 jobs:
   metadata:

scripts/tests/accessibility.sh

@@ -4,20 +4,22 @@ set -euo pipefail
 
 # feature flag
 export NEXT_PUBLIC_ENABLE_PROOFING=true
-
 export INCLUDE_AUTH_PAGES=true
 
 npm run accessibility-test-setup -w tests/accessibility
-
 npm run build
-
 mkdir -p ./frontend/public/testing
 cp ./utils/utils/src/email-templates/* ./frontend/public/testing/
 
 npm run app:start --prefix frontend
-
 npm run app:wait --prefix frontend
 
-npm run test:accessibility -w tests/accessibility
+TEST_EXIT_CODE=0
+npm run test:accessibility -w tests/accessibility || TEST_EXIT_CODE=$?
+echo "TEST_EXIT_CODE=$TEST_EXIT_CODE"
 
+mkdir -p ./tests/acceptance-test-report
+cp -r ./tests/accessibility/.reports/accessibility ./tests/acceptance-test-report
 npm run accessibility-test-teardown  -w tests/accessibility
+
+exit $TEST_EXIT_CODE

scripts/tests/api.sh

@@ -4,4 +4,12 @@ set -euo pipefail
 cd "$(git rev-parse --show-toplevel)"
 npx playwright install --with-deps > /dev/null
 cd tests/test-team
-npm run test:api
+TEST_EXIT_CODE=0
+npm run test:api || TEST_EXIT_CODE=$?
+echo "TEST_EXIT_CODE=$TEST_EXIT_CODE"
+
+mkdir -p ../acceptance-test-report
+cp -r ./playwright-report ../acceptance-test-report
+[[ -e test-results ]] && cp -r ./test-results ../acceptance-test-report
+
+exit $TEST_EXIT_CODE

scripts/tests/ui-component.sh

@@ -4,4 +4,12 @@ set -euo pipefail
 cd "$(git rev-parse --show-toplevel)"
 npx playwright install --with-deps > /dev/null
 cd tests/test-team
-npm run test:local-ui
+TEST_EXIT_CODE=0
+npm run test:local-ui || TEST_EXIT_CODE=$?
+echo "TEST_EXIT_CODE=$TEST_EXIT_CODE"
+
+mkdir -p ../acceptance-test-report
+cp -r ./playwright-report ../acceptance-test-report
+[[ -e test-results ]] && cp -r ./test-results ../acceptance-test-report
+
+exit $TEST_EXIT_CODE

scripts/tests/ui-e2e.sh

@@ -4,4 +4,12 @@ set -euo pipefail
 cd "$(git rev-parse --show-toplevel)"
 npx playwright install --with-deps > /dev/null
 cd tests/test-team
-npm run test:e2e
+TEST_EXIT_CODE=0
+npm run test:e2e || TEST_EXIT_CODE=$?
+echo "TEST_EXIT_CODE=$TEST_EXIT_CODE"
+
+mkdir -p ../acceptance-test-report
+cp -r ./playwright-report ../acceptance-test-report
+[[ -e test-results ]] && cp -r ./test-results ../acceptance-test-report
+
+exit $TEST_EXIT_CODE