CCM-10387: ownership by default

Author: alexnuttall

lambdas/backend-api/src/__tests__/templates/app/template-client.test.ts

@@ -183,7 +183,7 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         data,
         user,
-        false,
+        true,
         'NOT_YET_SUBMITTED',
         undefined
       );
@@ -235,7 +235,7 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         data,
         user,
-        false,
+        true,
         'NOT_YET_SUBMITTED',
         undefined
       );
@@ -293,7 +293,7 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         data,
         user,
-        false,
+        true,
         'NOT_YET_SUBMITTED',
         'campaignId'
       );
@@ -401,15 +401,15 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         { ...dataWithFiles, proofingEnabled: true },
         user,
-        false,
+        true,
         'PENDING_UPLOAD',
         'campaignId'
       );
 
       expect(mocks.letterUploadRepository.upload).toHaveBeenCalledWith(
         templateId,
         user,
-        false,
+        true,
         versionId,
         pdf,
         csv
@@ -550,7 +550,7 @@ describe('templateClient', () => {
         expect(mocks.templateRepository.create).toHaveBeenCalledWith(
           { ...dataWithFiles, proofingEnabled: expected },
           user,
-          false,
+          true,
           'PENDING_UPLOAD',
           'campaignId'
         );
@@ -799,7 +799,7 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         { ...dataWithFiles, proofingEnabled: false },
         user,
-        false,
+        true,
         'PENDING_UPLOAD',
         undefined
       );
@@ -925,15 +925,15 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         { ...dataWithFiles, proofingEnabled: false },
         user,
-        false,
+        true,
         'PENDING_UPLOAD',
         undefined
       );
 
       expect(mocks.letterUploadRepository.upload).toHaveBeenCalledWith(
         templateId,
         user,
-        false,
+        true,
         versionId,
         pdf,
         undefined
@@ -1015,15 +1015,15 @@ describe('templateClient', () => {
       expect(mocks.templateRepository.create).toHaveBeenCalledWith(
         { ...dataWithFiles, proofingEnabled: false },
         user,
-        false,
+        true,
         'PENDING_UPLOAD',
         undefined
       );
 
       expect(mocks.letterUploadRepository.upload).toHaveBeenCalledWith(
         templateId,
         user,
-        false,
+        true,
         versionId,
         pdf,
         undefined

lambdas/backend-api/src/templates/app/template-client.ts

@@ -79,7 +79,7 @@ export class TemplateClient {
     const createResult = await this.templateRepository.create(
       validationResult.data,
       user,
-      clientConfigurationResult.data?.features.clientOwnership || false,
+      clientConfigurationResult.data?.features.clientOwnership ?? true,
       'NOT_YET_SUBMITTED',
       clientConfigurationResult.data?.campaignId
     );
@@ -189,7 +189,7 @@ export class TemplateClient {
     };
 
     const clientOwnershipEnabled =
-      clientConfigurationResult.data?.features.clientOwnership || false;
+      clientConfigurationResult.data?.features.clientOwnership ?? true;
 
     const createResult = await this.templateRepository.create(
       letterTemplateFields,

tests/accessibility/test-user-client.ts

@@ -28,7 +28,7 @@ export class TestUserClient {
       new PutParameterCommand({
         Name: `${this.clientSsmPathPrefix}/${clientId}`,
         Value: JSON.stringify({
-          features: { proofing: true, clientOwnership: true },
+          features: { proofing: true },
           campaignId: 'accessibility-test-campaign',
         } satisfies ClientConfiguration),
         Overwrite: true,

tests/test-team/helpers/client/client-helper.ts

@@ -7,7 +7,7 @@ import {
 type ClientConfiguration = {
   features: {
     proofing: boolean;
-    clientOwnership: boolean;
+    clientOwnership?: boolean;
   };
   campaignId?: string;
 };
@@ -24,7 +24,6 @@ export const testClients = {
     campaignId: 'Campaign1',
     features: {
       proofing: true,
-      clientOwnership: true,
     },
   },
   /**
@@ -34,7 +33,6 @@ export const testClients = {
     campaignId: 'Campaign2',
     features: {
       proofing: false,
-      clientOwnership: true,
     },
   },
   /**
@@ -48,7 +46,6 @@ export const testClients = {
     campaignId: undefined,
     features: {
       proofing: false,
-      clientOwnership: true,
     },
   },
   /**