Skip to content

Commit 1dd1c46

Browse files
Kai SpencerKai Spencer
authored andcommitted
Dateinput prop type should be text with inputMode numeric see nhsuk/nhsuk-frontend#666
1 parent be10607 commit 1dd1c46

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/components/date-input/__tests__/__snapshots__/DateInput.test.tsx.snap

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ exports[`DateInput matches snapshot 1`] = `
2222
inputMode="numeric"
2323
inputType="day"
2424
pattern="[0-9]*"
25-
type="number"
25+
type="text"
2626
>
2727
<div
2828
className="nhsuk-date-input__item"
@@ -57,7 +57,7 @@ exports[`DateInput matches snapshot 1`] = `
5757
name="testInput-day"
5858
onChange={[Function]}
5959
pattern="[0-9]*"
60-
type="number"
60+
type="text"
6161
/>
6262
</div>
6363
</div>
@@ -68,7 +68,7 @@ exports[`DateInput matches snapshot 1`] = `
6868
inputMode="numeric"
6969
inputType="month"
7070
pattern="[0-9]*"
71-
type="number"
71+
type="text"
7272
>
7373
<div
7474
className="nhsuk-date-input__item"
@@ -103,7 +103,7 @@ exports[`DateInput matches snapshot 1`] = `
103103
name="testInput-month"
104104
onChange={[Function]}
105105
pattern="[0-9]*"
106-
type="number"
106+
type="text"
107107
/>
108108
</div>
109109
</div>
@@ -114,7 +114,7 @@ exports[`DateInput matches snapshot 1`] = `
114114
inputMode="numeric"
115115
inputType="year"
116116
pattern="[0-9]*"
117-
type="number"
117+
type="text"
118118
>
119119
<div
120120
className="nhsuk-date-input__item"
@@ -149,7 +149,7 @@ exports[`DateInput matches snapshot 1`] = `
149149
name="testInput-year"
150150
onChange={[Function]}
151151
pattern="[0-9]*"
152-
type="number"
152+
type="text"
153153
/>
154154
</div>
155155
</div>

src/components/date-input/components/IndividualDateInputs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ const IndividualDateInput: React.FC<IndividualDateInputProps> = ({
9696
IndividualDateInput.defaultProps = {
9797
pattern: '[0-9]*',
9898
inputMode: 'numeric',
99-
type: 'number',
99+
type: 'text',
100100
};
101101

102102
export const DayInput: React.FC<Omit<IndividualDateInputProps, 'inputType'>> = (props) => (

0 commit comments

Comments
 (0)