Address review comments (sonar)

Author: robkerrybjss

docs/upgrade-to-6.0.md

@@ -453,6 +453,7 @@ To align with NHS.UK frontend, the skip link component focuses the main content
 ```html
 <main class="nhsuk-main-wrapper" id="maincontent">
   <!-- // ... -->
+</main>
 ```
 
 For accessibility reasons, you must make the following changes:

src/components/content-presentation/notification-banner/__tests__/NotificationBanner.test.tsx

@@ -268,16 +268,16 @@ describe('NotificationBanner', () => {
         <NotificationBanner.Heading>4 files uploaded</NotificationBanner.Heading>
         <ul>
           <li>
-            <NotificationBannerLink>government-strategy.pdf</NotificationBannerLink>
+            <NotificationBannerLink>file.pdf</NotificationBannerLink>
           </li>
           <li>
-            <NotificationBannerLink>government-strategy-v2.pdf</NotificationBannerLink>
+            <NotificationBannerLink>file-v2.pdf</NotificationBannerLink>
           </li>
           <li>
-            <NotificationBannerLink>government-strategy-v3-FINAL.pdf</NotificationBannerLink>
+            <NotificationBannerLink>file-v3-FINAL.pdf</NotificationBannerLink>
           </li>
           <li>
-            <NotificationBannerLink>government-strategy-v4-FINAL-v2.pdf</NotificationBannerLink>
+            <NotificationBannerLink>file-v4-FINAL-v2.pdf</NotificationBannerLink>
           </li>
         </ul>
       </NotificationBanner>,
@@ -359,7 +359,7 @@ describe('NotificationBanner', () => {
     const [notificationBannerEl] = modules;
 
     expect(notificationBannerEl?.getAttribute('role')).toBe('region');
-    expect(notificationBannerEl?.getAttribute('data-disable-auto-focus')).toBe(null);
+    expect(notificationBannerEl?.dataset?.disableAutoFocus).toBe(undefined);
   });
 
   it('has alert role', async () => {
@@ -385,6 +385,6 @@ describe('NotificationBanner', () => {
 
     const [notificationBannerEl] = modules;
 
-    expect(notificationBannerEl?.getAttribute('data-disable-auto-focus')).toBe('true');
+    expect(notificationBannerEl?.dataset?.disableAutoFocus).toBe('true');
   });
 });

src/components/content-presentation/notification-banner/__tests__/__snapshots__/NotificationBanner.test.tsx.snap

@@ -456,28 +456,28 @@ exports[`NotificationBanner matches snapshot with list (via server) 1`] = `
           <a
             class="nhsuk-notification-banner__link"
           >
-            government-strategy.pdf
+            file.pdf
           </a>
         </li>
         <li>
           <a
             class="nhsuk-notification-banner__link"
           >
-            government-strategy-v2.pdf
+            file-v2.pdf
           </a>
         </li>
         <li>
           <a
             class="nhsuk-notification-banner__link"
           >
-            government-strategy-v3-FINAL.pdf
+            file-v3-FINAL.pdf
           </a>
         </li>
         <li>
           <a
             class="nhsuk-notification-banner__link"
           >
-            government-strategy-v4-FINAL-v2.pdf
+            file-v4-FINAL-v2.pdf
           </a>
         </li>
       </ul>
@@ -638,7 +638,9 @@ exports[`NotificationBanner matches snapshot with lots of content (via server) 1
         Check if you need to apply the reverse charge to this application
       </h3>
       <p>
-        You will have to apply the 
+        You will have to apply the
+        <!-- -->
+         
         <a
           class="nhsuk-notification-banner__link"
         >
@@ -687,7 +689,8 @@ exports[`NotificationBanner matches snapshot with lots of content 1`] = `
         Check if you need to apply the reverse charge to this application
       </h3>
       <p>
-        You will have to apply the 
+        You will have to apply the
+         
         <a
           class="nhsuk-notification-banner__link"
         >