Allow unused vars as object rest siblings

Author: colinrotherham

eslint.config.js

@@ -43,6 +43,17 @@ export default defineConfig([
       'import/no-named-as-default-member': 'off',
       'import/no-unresolved': 'off',
       'import/no-unused-modules': 'off',
+
+      // Prefer rules that are type aware
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_',
+          ignoreRestSiblings: true,
+        },
+      ],
     },
     settings: {
       'import/resolver': {

src/components/form-elements/checkboxes/Checkboxes.tsx

@@ -72,7 +72,6 @@ const CheckboxesComponent = forwardRef<HTMLDivElement, CheckboxesProps>((props,
 
   return (
     <FormGroup<CheckboxesProps> inputType="checkboxes" {...rest}>
-      {/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
       {({ className, small, name, id, idPrefix, error, ...restRenderProps }) => {
         resetCheckboxIds();
         const contextValue: ICheckboxesContext = {

src/components/form-elements/radios/Radios.tsx

@@ -79,7 +79,6 @@ const RadiosComponent = forwardRef<HTMLDivElement, RadiosProps>((props, forwarde
 
   return (
     <FormGroup<RadiosProps> inputType="radios" {...rest}>
-      {/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
       {({ className, inline, small, name, id, error, ...restRenderProps }) => {
         resetRadioIds();
         const contextValue: IRadiosContext = {

src/components/utils/__tests__/FormGroup.test.tsx

@@ -220,7 +220,6 @@ describe('FormGroup', () => {
     it('string component', async () => {
       const { container } = await renderClient(
         <FormGroup<TextInputProps> inputType="input" error="Oh no there's an error!">
-          {/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
           {({ error, ...rest }) => <input {...rest} />}
         </FormGroup>,
         { className: 'nhsuk-form-group' },
@@ -245,7 +244,6 @@ describe('FormGroup', () => {
           hint="This is a hint"
           label="Form Label"
         >
-          {/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
           {({ error, ...rest }) => <input {...rest} />}
         </FormGroup>
       </main>,
@@ -264,7 +262,6 @@ describe('FormGroup', () => {
         error="This is an error"
         hint="This is a hint"
       >
-        {/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
         {({ error, ...rest }) => <input {...rest} />}
       </FormGroup>,
       { className: 'nhsuk-form-group' },
@@ -279,7 +276,6 @@ describe('FormGroup', () => {
   it('should have no aria-describedby when there is no hint or label', async () => {
     const { container } = await renderClient(
       <FormGroup<TextInputProps> inputType="input">
-        {/* eslint-disable-next-line @typescript-eslint/no-unused-vars */}
         {({ error, ...rest }) => <input {...rest} />}
       </FormGroup>,
       { className: 'nhsuk-form-group' },