most tests fixed, 4 left

Author: ricksmith130

src/components/content-presentation/table/TableHelpers.ts

@@ -1,14 +1,14 @@
 import { Children, isValidElement, ReactElement, ReactNode } from 'react';
-import TableCell from './components/TableCell';
+import TableCell, { TableCellProps } from './components/TableCell';
 
-export const isTableCell = (child: ReactNode): child is ReactElement => {
+export const isTableCell = (child: ReactNode): child is ReactElement<TableCellProps> => {
   return isValidElement(child) && child.type === TableCell;
 };
 
 export const getHeadingsFromChildren = (children: ReactNode): string[] => {
   const headings: string[] = [];
   Children.map(children, (child) => {
-    if (isTableCell(child)) {
+    if (isTableCell(child) && child.props.children != null) {
       headings.push(child.props.children.toString());
     }
   });

src/components/content-presentation/table/components/__tests__/__snapshots__/TableBody.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Table.Body matches snapshot 1`] = `
 <div>

src/components/content-presentation/table/components/__tests__/__snapshots__/TableCell.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Table.Cell matches snapshot 1`] = `
 <div>

src/components/content-presentation/table/components/__tests__/__snapshots__/TableHead.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Table.Head matches snapshot 1`] = `
 <div>

src/components/content-presentation/table/components/__tests__/__snapshots__/TableRow.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Table.Row matches snapshot 1`] = `
 <div>

src/components/form-elements/button/Button.tsx

@@ -38,7 +38,7 @@ const useDebounceTimeout = (
   fn?: EventHandler<SyntheticEvent>,
   timeout: number = DefaultButtonDebounceTimeout,
 ) => {
-  const timeoutRef = useRef<number>(0);
+  const timeoutRef = useRef<number | undefined>(0);
 
   if (!fn) return undefined;
 
@@ -148,7 +148,8 @@ export const ButtonLink: FC<ButtonLinkProps> = ({
   );
 };
 
-const ButtonWrapper: FC<ButtonLinkProps | ButtonProps> = ({ href, as, ...rest }) => {
+const ButtonWrapper: FC<ButtonLinkProps | ButtonProps> = ({ as, ...rest }) => {
+  const { href } = rest as ButtonLinkProps;
   if (as === 'a') {
     return <ButtonLink href={href} {...(rest as ButtonLinkProps)} />;
   }

src/components/form-elements/button/__tests__/__snapshots__/Button.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Button disabled matches snapshot: DisabledButton 1`] = `
 <div>

src/components/navigation/card/components/CardLink.tsx

@@ -1,11 +1,18 @@
-import React, { FC } from 'react';
+import React, { ElementType, FC } from 'react';
 import classNames from 'classnames';
 import { AsElementLink } from '@util/types/LinkTypes';
 
-const CardLink: FC<AsElementLink<'a'>> = ({
+interface CardLinkProps extends AsElementLink {
+  className?: string;
+}
+
+const CardLink: FC<CardLinkProps> = ({
   className,
   asElement: Component = 'a',
   ...rest
-}) => <Component className={classNames('nhsuk-card__link', className)} {...rest} />;
+}) => {
+  const Comp = Component as ElementType;
+  return <Comp className={classNames('nhsuk-card__link', className)} {...rest} />;
+};
 
 export default CardLink;

src/components/navigation/footer/Footer.tsx

@@ -15,7 +15,7 @@ const FooterList: FC<FooterListProps> = ({
 
   if (singleColumn) {
     newChildren = Children.map(newChildren, (child) =>
-      childIsOfComponentType(child, FooterListItem) ? cloneElement(child, { singleColumn }) : child,
+      childIsOfComponentType(child, FooterListItem) ? cloneElement(child as any, { singleColumn }) : child,
     );
   }
 
@@ -51,7 +51,7 @@ interface FooterProps extends HTMLProps<HTMLDivElement> {
 
 interface Footer extends FC<FooterProps> {
   List: FC<FooterListProps>;
-  ListItem: FC<HTMLProps<HTMLAnchorElement>>;
+  ListItem: FC<HTMLProps<HTMLAnchorElement> & { singleColumn?: boolean }>;
   Copyright: FC<HTMLProps<HTMLParagraphElement>>;
 }
 
@@ -74,7 +74,7 @@ const Footer: Footer = ({ className, children, visuallyHiddenText = 'Support lin
   } else {
     newChildren = Children.map(children, (child) =>
       childIsOfComponentType(child, FooterList)
-        ? cloneElement(child, { singleColumn: true })
+        ? cloneElement(child as any, { singleColumn: true })
         : child,
     );
   }

src/components/navigation/footer/__tests__/__snapshots__/Footer.test.tsx.snap

@@ -1,4 +1,4 @@
-// Jest Snapshot v1, https://goo.gl/fbAQLP
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
 exports[`Footer Footer.Copyright matches snapshot: Footer.Copyright 1`] = `
 <div>